samueldr changed the topic of #nixos-dev to: #nixos-dev NixOS Development (#nixos for questions) | NixOS 19.09 is released! https://discourse.nixos.org/t/nixos-19-09-release/4306 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 19.09 RMs: disasm, sphalerite | https://logs.nix.samueldr.com/nixos-dev
<aanderse> is there any particular person or group of people who "manage" the nixos manual?
justanotheruser has quit [Read error: Connection reset by peer]
<samueldr> that's not a good question now, aanderse
<samueldr> :)
<samueldr> depending on what you want, it might be different people (maybe even you?)
<aanderse> no... it isn't... but i want to make some changes to a module and the manual uses the module as an example
<samueldr> ah, so "should the example be updated to stay relevant with the current options?" or something like that?
<aanderse> well... maybe
<samueldr> I don't think there's one single person about the contents of the docs, I would blame the section
<aanderse> or maybe another module should be used as an example
<aanderse> undetermined
<aanderse> i have a sneaking suspicion if i did a git blame it would go back ~5+ years :p
<samueldr> that sounds likely
<samueldr> or a pass at reformatting the docs about a year ago
<aanderse> yeah
<samueldr> though yeah, good spotting of that part of the docs being used as an example...
<aanderse> the httpd module is pretty much abandonware so it probably isn't the best example to be using
<aanderse> and the changes i plan to make probably make the module less than the best example for what that section is demonstrating
<samueldr> at the same time, I feel the demonstrations in that section are weird, like "you can use nix in ways nix was written to be used"
<samueldr> though I can appreciate the fact that it might not be obvious to a new user, which makes the section not useless
<aanderse> i want to make the httpd module better which is already a huge task. i don't want to rewrite the manual. rewriting a part of the manual becomes a prerequisite to what i want to do... :\
<samueldr> this feels like something that we could rewrite using the users.users options
<aanderse> heyo! i like that idea!
<samueldr> options map close enough that I think it should be trivial to make all examples map
<samueldr> a bit more contrived, but at the same time, aren't those examples contrived?
<aanderse> those examples really highlight how horrible the httpd module is, in comparison to nginx
aminechikhaoui has quit [Quit: The Lounge - https://thelounge.github.io]
aminechikhaoui has joined #nixos-dev
drakonis has joined #nixos-dev
ris has quit [Ping timeout: 240 seconds]
ajs124 has quit [Quit: Gateway shutdown]
greizgh has quit [Quit: greizgh]
greizgh has joined #nixos-dev
andi- has quit [Remote host closed the connection]
andi- has joined #nixos-dev
lopsided98_ has quit [Quit: Disconnected]
lopsided98 has joined #nixos-dev
orivej has quit [Ping timeout: 252 seconds]
lopsided98 has quit [Quit: Disconnected]
lopsided98 has joined #nixos-dev
drakonis has quit [Ping timeout: 264 seconds]
<lassulus> v
ajs124 has joined #nixos-dev
orivej has joined #nixos-dev
psyanticy has joined #nixos-dev
cocreature has quit [Ping timeout: 264 seconds]
Profpatsch has quit [Ping timeout: 240 seconds]
cocreature has joined #nixos-dev
Profpatsch has joined #nixos-dev
Jackneill has quit [Ping timeout: 240 seconds]
Jackneill has joined #nixos-dev
drakonis has joined #nixos-dev
orivej has quit [Ping timeout: 240 seconds]
wild_willy has joined #nixos-dev
johnny101 has joined #nixos-dev
wild_willy has quit [Remote host closed the connection]
ckauhaus has joined #nixos-dev
drakonis has quit [Quit: WeeChat 2.6]
Synthetica has quit [Quit: Connection closed for inactivity]
pie_ has quit [Ping timeout: 268 seconds]
MichaelRaskin has joined #nixos-dev
ris has joined #nixos-dev
pie_ has joined #nixos-dev
orivej has joined #nixos-dev
psyanticy has quit [Quit: Connection closed for inactivity]
asymmetric has quit [Changing host]
asymmetric has joined #nixos-dev
ckauhaus has quit [Quit: WeeChat 2.6]
red[m] has joined #nixos-dev
<Ericson2314> FRidh: do we night use the staging job on hydra anymore?
asymmetric has quit [Ping timeout: 240 seconds]
cptchaos83 has quit [Ping timeout: 268 seconds]
cptchaos83 has joined #nixos-dev
asymmetric has joined #nixos-dev
<infinisil> Do we have some written-down policy for how commits in PR's should look like before merging?
<infinisil> Because it seems that arcnmx and me are in a bit of a disagreement regarding that in #66978
<{^_^}> https://github.com/NixOS/nixpkgs/pull/66978 (by arcnmx, 11 weeks ago, open): nixos/digital-ocean-image: init (rebase)
<infinisil> Currently the PR contains 17 commits, many of which are fixups. arcnmx would like to preserve history, but I'd like to have each commit be a logical unit on its own
<infinisil> I hate that something as simple as this holds up the PR, but I really don't like merging something without a clean history
<infinisil> Opinions?
<arcnmx> part of it is more that I don’t feel comfortable erasing someone else’s history, but I already made a mess of mine at the first prompt to squash everything
<infinisil> I wouldn't worry about another person's history, git is usually pretty good at keeping authors
<arcnmx> use the github squash and merge button maybe..! ><
<infinisil> And if not you can use the co-authored-by thing to indicate two authors (which will be shown nicely in github too)
<infinisil> Hm, I don't like using the squash & merge because it means the PR's sha's aren't the same as the one merged, which can make backporting a bit more annoying
<infinisil> And also, here you should have at least 2 commits, one for the maintainer adding and one for the rest. The squash button can't do that
drakonis has joined #nixos-dev