<samueldr>
I hadn't looked at the doc before saying that
<samueldr>
I thought it would find it using one of the XDG mime-like things
<Drakonis>
it kicks in when missing
<Drakonis>
its part of their alternatives system
<samueldr>
and not just use PATH
<Drakonis>
ekleog, how do i wrap it with that again?
<ekleog>
samueldr: oh. so after a bit of investigation, I guess I mistook it with sensible-browser… we'd need an x-terminal-emulator, xdg-terminal or equivalent :/
<Drakonis>
x-terminal-emulator is pretty much anything that emulates an terminal
<samueldr>
ekleog: yeah, it could make even more sense than the debian implementation
<Drakonis>
i want to put xterm there because its part of the standard x environment
<Drakonis>
its not going to cause any issues
<ekleog>
,locate x-terminal-emulator
<ekleog>
,locate xdg-terminal
<{^_^}>
Found in packages: firejail
<{^_^}>
Couldn't find any packages
<ekleog>
hmm? x-terminal-emulator in firejail? but why?
<Drakonis>
fyi, x-terminal-emulator is an symlink to an terminal emulator
<samueldr>
drakonis: I think we both know how alternatives work in debian
<ekleog>
drakonis: I think the best option would be to package xdg-terminal on nixos and depend on it with a wrapper TERMINAL=${TERMINAL:-xdg-terminal} :)
<samueldr>
(sorry if it sounded blunt, the manual things are a bit all around)
<Drakonis>
yeah i get you
<ekleog>
samueldr: about your earlier question with how to handle https://github.com/NixOS/nixpkgs/pull/35069 , I'm not really habilitated to answer, but do you think --enable-64bit would work on i686?
<Drakonis>
doesn't look like an official util though
<ekleog>
probably indeed :) wonder, though, do we still have even one i686-only accessible builder to test with?
<ekleog>
drakonis: it likely isn't developed by the xdg group, indeed, but it looks to do what we're hoping for, ie. figure out the right terminal to call depending on the user's available terminals :)
<jtojnar>
I guess I will add proper default terminal spec to my to do list
<Drakonis>
v. nice
<Drakonis>
but, what's the current solution for the time being?
<jtojnar>
in glib-based apps, it is not possible cleanly (see discourse thread), not sure about Qt
<Drakonis>
the application i'm trying to use is qt based
<Drakonis>
the binaries it tries to run don't exist btw
<Drakonis>
nevermind, i am bad at reading shell
<ekleog>
no current cve for xdg-terminal, though, is it?
<ekleog>
jtojnar: from a bit before you came in, `terminal = QStandardPaths::findExecutable("x-terminal-emulator");` / “TERMINAL is to override that” (from samueldr)
<Drakonis>
its not for xdg-terminal though
<Drakonis>
CVE-2017-18266
<Drakonis>
its for xdg-open, as for the script
<Drakonis>
doesn't seem to be running here
<Drakonis>
xdg-terminal: line 229: detectDE: command not found
<Drakonis>
xdg-terminal: line 165: exit_failure_operation_impossible: command not found
<Drakonis>
ah it depends on another shellscript, great.
<ekleog>
drakonis: did you run it from a patched built xdg-utils?
<Drakonis>
no not yet
<Drakonis>
i'm not entirely sure how to patch the makefile because my shell fu is weaj
<Drakonis>
weak.
<ekleog>
1. clone the repository, 2. change the makefile by removing the #, 3. git diff, 4. add the output of git diff as a patch in the derivation :)
<Drakonis>
oic, ty
<ekleog>
I guess we should have that in documentation somewhere, don't know whether it's already there, and if it is, where, though
<samueldr>
you could commit and git format-patch to even get a nice git commit summary in there
<samueldr>
(I moved to using git format-patch as you can easily dump a couple of commit-like patches)
<samueldr>
first time using nox-review, is it me or is it slow?
<samueldr>
the fetching parts specifically
<samueldr>
I run it inside a fully-fetched nixpkgs repo
<samueldr>
(btw, not complaining, I am doubting I'm thinking I may be misuing it)
<samueldr>
misusing*
<Drakonis>
so, what's the patch format?
<Drakonis>
old file new file old line new line?
<samueldr>
it's the usual patch format, which turns out is what `git diff` outputs
<Drakonis>
ok, so throw that into a file then set that as input?
<samueldr>
look at other patches in nixpkgs, `find . -iname '*.patch'` for how they are integrated into derivations
jtojnar has quit [Remote host closed the connection]
jtojnar has joined #nixos-dev
<Drakonis>
yeah okay i got that done
<Drakonis>
there may be other problems
<Drakonis>
xdg-terminal: configured terminal program '' not found or not executable
<Drakonis>
this line precedes /home/drakonis/.nix-profile/bin/xdg-terminal: line 508: kreadconfig: command not found
<Drakonis>
the line above
<Drakonis>
ekleog, doesn't look like enabling xdg terminal will help
<Drakonis>
because nobody's using it
<jtojnar>
the closest to a standard is the debianism
<ekleog>
<drakonis> ekleog, doesn't look like enabling xdg terminal will help <drakonis> because nobody's using it <-- you can make your derivation use it by wrapping it with a TERMINAL=${TERMINAL:-xdg-terminal} wrapper :)
<Drakonis>
ekleog, actually, its broken because its not set
<Drakonis>
it depends on variables nothing sets up
<ekleog>
?
<Drakonis>
here /home/drakonis/.nix-profile/bin/xdg-terminal: line 508: kreadconfig: command not found
<Drakonis>
xdg-terminal: configured terminal program '' not found or not executable
<Drakonis>
here be dragons
<ekleog>
to me, the problem of the debianism, is that it's either a symlink at a global location (so not usable for nix) or a symlink in some dependency of the derivation, in which case it forces an additional unneeded dependency
<ekleog>
,locate kreadconfig
<{^_^}>
Found in packages: kdeFrameworks.kconfig.dev
<Drakonis>
its not used anymore
<Drakonis>
hmm
<ekleog>
hmm that's something that'd require some hackery to get right, I guess :/
<Drakonis>
yeah
<ekleog>
actually no
<Drakonis>
no?
<ekleog>
well, it's hackery, but… adding /run/current-system/sw/bin to the path could do it
<Drakonis>
which thing are you refering to?
<ekleog>
and I think there's precedent for hardcoding /run/current-system/sw/bin when there's no really better option (seem to remember having done it once for, something like a wrapper)
<Drakonis>
alternatives or the package?
<ekleog>
drakonis: wrapping xdg-terminal in PATH=$PATH:/run/current-system/sw/bin
<ekleog>
s/in/with/
<ekleog>
which should make it work enough to be usable from a wrapper for your derivation (forgot its name) that'd set it with TERMINAL=${TERMINAL:-xdg-terminal}
<ekleog>
while still not adding a dependency on all of kde
<Drakonis>
i'd rather avoid the hackery and have something i can use in the future
<ekleog>
would likely require making sure that kdeFrameworks.kconfig.dev is actually added to the environment packages on kde-enabled nixos systems, though, I guess
<Drakonis>
to solve these problems
<ekleog>
issue is, nix doesn't allow for optional dependencies, afaik (and having kreadconfig defined as nix-shell -p kdeFrameworks.kconfig.dev --run kreadconfig would likely be worse)
<ekleog>
so the only way to get xdg-terminal to work appears to be through some equivalent of this
<ekleog>
and what you are looking for is something that is exactly the equivalent of xdg-terminal : figure out which terminal is available for the current system
<ekleog>
so the two solutions are either work around xdg-terminal's weaknesses, or write a nix-specific xdg-terminal equivalent from scratch :)
<Drakonis>
yes i am
<Drakonis>
the latter seems more interesting though
<Drakonis>
except i wouldn't intend it just for terminals
<Drakonis>
seems super wasteful
<ekleog>
oh, if you're motivated for doing this as a project, then forget all I said and good luck! :)
<Drakonis>
its going to be a difficult long term project :v
<Drakonis>
i just want to get something done beforehand
<Drakonis>
i have an project in elixir i want to finish before getting into this
ma27 has quit [Quit: WeeChat 2.0]
FRidh has joined #nixos-dev
Drakonis has quit [Remote host closed the connection]
phreedom has quit [Remote host closed the connection]
phreedom has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.0]
ma27 has joined #nixos-dev
pierron is now known as nbp
nbp is now known as pierron
pierron is now known as nbp
orivej has joined #nixos-dev
<samueldr>
jtojnar: current channel commit still has that issue
<samueldr>
error: 'mkHomepage' at /Users/samuel/tmp/nixpkgs/nixpkgs/pkgs/development/r-modules/default.nix:54:18 called with unexpected argument 'biocVersion', at /Users/samuel/tmp/nixpkgs/nixpkgs/pkgs/development/r-modules/default.nix:35:21
<samueldr>
(verifying if master has that issue)
<samueldr>
it should be fixed next time the channel moves
<samueldr>
btw, just throwing this here, if the json files stop updating, you can clone nixos-homepage; nix-shell; make nixpkgs/packages-unstable.json.gz; (assuming it's the unstable one that failed)
Sonarpulse has joined #nixos-dev
layus has joined #nixos-dev
<jtojnar>
samueldr: well I am only interested in it because of repology
<samueldr>
yeah, I figured
<samueldr>
still useful to figure out what broke
__Sander__ has quit [Quit: Konversation terminated!]
Mic92 has quit [Ping timeout: 256 seconds]
pie__ has joined #nixos-dev
pie_ has quit [Ping timeout: 256 seconds]
init_6 has quit [Ping timeout: 256 seconds]
Drakonis[m] has joined #nixos-dev
Drakonis[m] has joined #nixos-dev
Drakonis[m] has quit [Changing host]
ma27 has quit [Quit: WeeChat 2.0]
ma27 has joined #nixos-dev
Drakonis has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.0]
ma27 has joined #nixos-dev
ma27 has quit [Client Quit]
ma27 has joined #nixos-dev
ma27 has quit [Client Quit]
ma27 has joined #nixos-dev
ma27 has quit [Client Quit]
ma27 has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.0]
ma27 has joined #nixos-dev
ma27 has quit [Client Quit]
ma27 has joined #nixos-dev
acowley has joined #nixos-dev
Sonarpulse has quit [Ping timeout: 240 seconds]
vcunat has quit [Ping timeout: 240 seconds]
FRidh has quit [Ping timeout: 244 seconds]
sir_guy_carleton has joined #nixos-dev
orivej has quit [Ping timeout: 240 seconds]
Sonarpulse has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.0]
Sonarpulse has quit [Quit: Leaving]
Ericson2314 has joined #nixos-dev
Ericson2314 is now known as Sonarpulse
Sonarpulse is now known as Ericson2314
orivej has joined #nixos-dev
CrystalGamma[m] has left #nixos-dev ["User left"]
Lisanna has quit [Ping timeout: 244 seconds]
Drakonis has quit [Remote host closed the connection]