<LnL>
yeah, both the browser and nix log don't handle the brotli encoding correctly anymore
jtojnar has quit [Remote host closed the connection]
jtojnar has joined #nixos-dev
init_6 has quit []
<infinisil>
Currently reviewing a pull request, but the one doing the pull request doesn't seem to actually respond to my comments (they contain questions). They only implement the requested changes without discussion
<infinisil>
I guess I'll just have to hammer more on it, because there's things that still aren't clear to me, just feels a bit odd to keep having to do that
vcunat has joined #nixos-dev
pie___ has quit [Quit: Leaving]
Drakonis has joined #nixos-dev
goibhniu has joined #nixos-dev
goibhniu has quit [Ping timeout: 244 seconds]
aanderse has joined #nixos-dev
goibhniu has joined #nixos-dev
Drakonis has quit [Remote host closed the connection]
aanderse has quit [Ping timeout: 260 seconds]
aszlig has quit [Quit: Kerneling down for reboot NOW.]
aszlig has joined #nixos-dev
goibhniu has quit [Ping timeout: 260 seconds]
<samueldr>
LnL: I'm trying to gather some data for an eventual RFC, do you think it's right to say the commit I'll link to next was pushed to master without going through a PR?
<samueldr>
(I'm not trying to single anyone out, just the luck of the draw)
<LnL>
not sure about that one, but I do sometimes just push darwin fixes
<samueldr>
hmmmm, though I just found what I wanted while searching randomly, I also have actually-PRs but were rebased and pushed
<samueldr>
so I can only say that there was _at most_ 39.67% of commits on master between 17.09 and 18.03 which didn't go through PRs, since I'm 99% sure there's no way to attribute them to their PRs in that case :(
goibhniu has joined #nixos-dev
<LnL>
it probably was, that's time of 17.09 so I was probably going through the ZHF issues trying to fix as much as possible
<samueldr>
no worries, nobody's in trouble, I'm only looking for numbers
<LnL>
well, it's a good example of something that's not trivial and probably should have gone through a pr :)
orivej has joined #nixos-dev
FRidh has quit [Quit: Konversation terminated!]
orivej has quit [Ping timeout: 256 seconds]
lopsided98 has joined #nixos-dev
Drakonis has joined #nixos-dev
orivej has joined #nixos-dev
Drakonis has quit [Read error: error:1408F10B:SSL routines:ssl3_get_record:wrong version number]
Drakonis has joined #nixos-dev
orivej has quit [Ping timeout: 240 seconds]
vcunat has quit [Quit: Leaving.]
orivej has joined #nixos-dev
goibhniu has quit [Ping timeout: 240 seconds]
goibhniu has joined #nixos-dev
Drakonis has quit [Remote host closed the connection]