gchristensen changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | 18.09 release managers: vcunat and samueldr | https://logs.nix.samueldr.com/nixos-dev
<aszlig> shlevy, niksnut: ^
<samueldr> hi all, I have small request; I'd prefer not to merge my own PRs and work, since in addition to being vain (lol), I kinda like the idea of authors not closing their non-trivial PRs
<samueldr> 18.09 being awfully close to branch-off, https://github.com/NixOS/nixpkgs/pull/33686 is the only one
<{^_^}> #33686 (by samueldr, 32 weeks ago, open): (Installation media) Bootloader artwork refresh
<samueldr> I authored that needs a nudge; I will merge it myself if needs be
pie_ has quit [Ping timeout: 272 seconds]
aanderse has joined #nixos-dev
Lisanna has quit [Quit: Lisanna]
sorear has quit []
sorear has joined #nixos-dev
mingc has quit [*.net *.split]
cocreature has quit [*.net *.split]
andi- has quit [*.net *.split]
andi- has joined #nixos-dev
cocreature has joined #nixos-dev
Drakonis has joined #nixos-dev
flokli has quit [*.net *.split]
mpickering has quit [*.net *.split]
lassulus has quit [Ping timeout: 268 seconds]
ma27 has quit [*.net *.split]
terrorjack has quit [*.net *.split]
aristid has quit [*.net *.split]
simpson has quit [*.net *.split]
simpson has joined #nixos-dev
Drakonis has quit [Remote host closed the connection]
phreedom_ has quit [Remote host closed the connection]
phreedom has joined #nixos-dev
lassulus has joined #nixos-dev
flokli has joined #nixos-dev
__Sander__ has joined #nixos-dev
goibhniu has joined #nixos-dev
<domenkozar> aszlig: sounds good!
<domenkozar> well I'm not sending news with two items out :)
ma27 has joined #nixos-dev
__Sander__ has quit [Ping timeout: 252 seconds]
__Sander__ has joined #nixos-dev
<niksnut> ivan: added a comment
init_6 has joined #nixos-dev
pie_ has joined #nixos-dev
init_6 has quit []
<gchristensen> samueldr: I edited the first line of https://github.com/NixOS/nixpkgs/pull/33686's pr body btw
<{^_^}> #33686 (by samueldr, 33 weeks ago, open): (Installation media) Bootloader artwork refresh
<samueldr> thanks gchristensen
jtojnar has quit [Read error: Connection reset by peer]
jtojnar has joined #nixos-dev
<aanderse> is there any chance i can get someone to merge this before 18.09 freeze? https://github.com/NixOS/nixpkgs/pull/45638
<{^_^}> #45638 (by aanderse, 3 days ago, open): incron: init at 0.5.12
lassulus_ has joined #nixos-dev
lassulus has quit [Ping timeout: 252 seconds]
lassulus_ is now known as lassulus
Drakonis has joined #nixos-dev
lopsided98 has quit [Ping timeout: 264 seconds]
<aanderse> gchristensen: thank you for taking a look at my incron pull. while i agree the code i have in place isn't the best, aside from making changes upstream i think it is reasonable.
<gchristensen> probably best to keep the conversation in the PR
<aanderse> sure
orivej has quit [Ping timeout: 246 seconds]
<manveru> can someone help testing https://github.com/NixOS/nixpkgs/pull/45705 ?
<{^_^}> #45705 (by manveru, 1 day ago, open): ruby: default to version 2.5
<manveru> i kinda nuked my system last time i tried running nix-review :)
lopsided98 has joined #nixos-dev
<samueldr> oh! forgot I started my review script on that one (which doesn't start the build, only lists the attributes)
<samueldr> wondering if it's right or my comparison (same as ofborg's I think) is flawed
<manveru> that... seems a bit excessive
<samueldr> that's what I thought, I probably need to work on it still
__Sander__ has quit [Quit: Konversation terminated!]
<ivan> niksnut: thanks! I left in the whitespace preservation because every other REPL I looked at it seemed to preserve it (and it seems less surprising if a user is keystroke counting after Up), let me know if you feel strongly about it
noefk has quit [Quit: ZNC 1.6.5 - http://znc.in]
<gchristensen> samueldr: my bet is it is right
<gchristensen> samueldr: not sure I've ever seen ofborg's changed paths list actually be wrong
<samueldr> gchristensen: I *based* it on, and looked at ofborg's in the PR and it was smaller
<samueldr> so I probably made an oopsie somewhere in the list difference, or in building up the list
<gchristensen> ah
jtojnar has quit [Remote host closed the connection]
noefk has joined #nixos-dev
goibhniu has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-dev
primeos has joined #nixos-dev
primeos has quit [Quit: WeeChat 2.1]
primeos has joined #nixos-dev
primeos has quit [Quit: WeeChat 2.1]
primeos has joined #nixos-dev
primeos has quit [Client Quit]
primeos has joined #nixos-dev
Drakonis has quit [Read error: Connection reset by peer]
<gchristensen> is there a nix-2-only method for making disk images which doesn't require a linux VM?
<infinisil> samueldr: Branch off is when?
<samueldr> hmm, I kinda assumed it was always first day of the month of the release?
<samueldr> I should consult with vcunat seeing if there's anything stopping this from happening this saturday
<samueldr> chapter 40 doesn't really say more https://nixos.org/nixos/manual/#ch-releases
<gchristensen> do consult, and let's expand them docs
<infinisil> I see, because Ericson2314 was suggesting to have the RFC ready before the release (https://github.com/NixOS/nixpkgs/pull/45717#issuecomment-417051349), but that would be wayy too rushed imo
<samueldr> branch-off != release
<infinisil> Ah right, but not sure if 1 month is enough to finish the RFC and implement it with everyone agreeing, might just work though. But also, isn't the branch supposed to only get fixes?
<LnL> this saturday? :o
* samueldr is checking previous branch-off dates
<gchristensen> could go US voting style, "first tuesday after the first monday of the month"
<samueldr> I was relying mostly on vcunat though, and uh, kinda missed the fact that 29th on a 31 day month makes this close :)
<LnL> is it that close already
<samueldr> just kinda
<samueldr> almost late!
<samueldr> I'm not 100% positive about my data science here
jtojnar has joined #nixos-dev
<samueldr> that's because of the way tags are their own kind of objects
jtojnar has quit [Remote host closed the connection]
<infinisil> samueldr: That's the date of the first commit in the branches?
<LnL> not saying you are wrong I'm just surprised, time flies :)
<samueldr> infinisil: added the raw data
<infinisil> Oh, tags are date annotated objects too? I didn't know
<samueldr> in addition, aren't there two kind of tags with git?
<gchristensen> there are
<LnL> wait what!?
<gchristensen> there are tags and annotated tags
<gchristensen> a non-annotated tag is a pointer to a commit, and has no extra date info.
<LnL> oh, you mean just the ref?
<infinisil> Ahh, the -a in there makes it annotated, which all of these beta tags are
jtojnar has joined #nixos-dev
Lisanna has joined #nixos-dev
<gchristensen> yeah
jtojnar has quit [Client Quit]
<LnL> btw the git-tag manpage is crazy
<LnL> unless ... if ... if ... otherwise ...
<infinisil> LnL: Maybe they should have a command to explain what a git command does :P
<LnL> git describe could work on both commits and git commands
jtojnar has joined #nixos-dev
jtojnar has quit [Remote host closed the connection]
jtojnar has joined #nixos-dev
<gchristensen> haha
<sphalerite> LnL: but what if there's a tag with the same name as a git comamnd :o
<gchristensen> it picks a random action based on the roll of a fair dice
<samueldr> 🎲
<jtojnar> Should this go to master? https://github.com/NixOS/nixpkgs/pull/45764
<{^_^}> #45764 (by jtojnar, 5 minutes ago, open): pango: 1.42.1 → 1.42.4
<jtojnar> it is pretty ugly bug
<gchristensen> yikes
<gchristensen> how far away is staging from a merge?
<simpson> jtojnar: Hilarious. Informal +1
<jtojnar> gchristensen: looking at https://github.com/NixOS/nixpkgs/pull/45761, we are probably at the end of stabilization
<{^_^}> #45761 (by FRidh, 1 hour ago, open): Staging next
drakonis__ has joined #nixos-dev
<samueldr> just remembered this is open, and probably should be reviewed, cc niksnut https://github.com/NixOS/nixos-channel-scripts/pull/22
<{^_^}> nixos-channel-scripts#22 (by samueldr, 3 days ago, open): Fixes channel going back in time due to incomplete change.
aristid has joined #nixos-dev
xeji has joined #nixos-dev
drakonis__ has quit [Remote host closed the connection]
xeji has quit [Quit: WeeChat 2.1]