gchristensen changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | 18.03 release managers: fpletz and vcunat | https://logs.nix.samueldr.com/nixos-dev
<Enzime> > 1+1
<{^_^}> 2
<aszlig> > builtins.readFile /etc/nixos/configuration.nix
<{^_^}> access to path '/etc/nixos/configuration.nix' is forbidden in restricted mode
<clever> > builtins.exec
<{^_^}> attribute 'exec' missing, at (string):164:1
<clever> it better be! :P
kalbasit has joined #nixos-dev
orivej has quit [Ping timeout: 265 seconds]
<gchristensen> domenkozar: maybe on purpose ... :)
lassulus_ has joined #nixos-dev
drakonis has joined #nixos-dev
lassulus has quit [Ping timeout: 256 seconds]
lassulus_ is now known as lassulus
<samueldr> github search syntax can be powerful
<gchristensen> nice
<samueldr> trying to find a couple interesting ones https://nixos.wiki/wiki/Maintainers:Maintainers
sir_guy_carleton has joined #nixos-dev
<samueldr> (the one I posted earlier is stuff not updated since 2018-01-01)
phreedom has quit [Ping timeout: 250 seconds]
phreedom has joined #nixos-dev
<aszlig> > builtins.readFile "/var/lib/nixbot/state/nixpkgs/../../../../../../run/systemd/units/invocation:sshd.service"
<{^_^}> getting status of '/run/systemd/units/ca3347662ee642379f6604a8b66fff45': No such file or directory
<aszlig> niksnut: ^ is there any reason why EvalState::checkSourcePath should resolve symlinks in canonPath?
<aszlig> s/\<in\>/using/
<samueldr> (this must be the weirdest way to file the bug report)
sir_guy_carleton has quit [Quit: WeeChat 2.0]
sir_guy_carleton has joined #nixos-dev
pie_ has joined #nixos-dev
pie__ has quit [Remote host closed the connection]
<ekleog> aszlig: maybe stupid guess: to avoid that a derivation could write a symlink towards /etc/passwd in the store and then access it with IFD? not sure that's possible in restricted-eval mode, though
<aszlig> ekleog: well, that's maybe because of channel links or something
<aszlig> ekleog: i'm on my way to fixing this by canonicalizing the path first without resolving symlinks and process symlinks afterwards
<aszlig> that way you can't leak information using ../../...
<aszlig> at least in theory
* ekleog would still re-check after symlink resolution just in case
<ekleog> the threat model of restrict-eval is a malicious derivation trying to attack a user at build-time, right?
<aszlig> ekleog: i think the thread model is that a malicious nix expression is trying to access paths or urls that are not explicitly allowed
<ekleog> hmm, so, then apart from IFD I don't think there's much attack surface through symlinks… but if https://github.com/NixOS/nix/commit/d4dcffd64349bb52ad5f1b184bee5cc7c2be73b4#diff-8e6ba8c21672fc1a5f6f606e1e101c74L342 is still relevant and restrict-eval allows a derivation to access the store paths it has built, then there is an attack path if the path is not checked after symlink resolution
<aszlig> ekleog: well, it is checked after symlink resolution
<ekleog> oh, I thought you planned to check it only before, and not after :)
<aszlig> it's just that it spits out the symlink target during symlink resolve
phreedom has quit [Remote host closed the connection]
phreedom has joined #nixos-dev
drakonis has quit [Remote host closed the connection]
drakonis has joined #nixos-dev
sir_guy_carleton has quit [Quit: WeeChat 2.0]
drakonis has quit [Remote host closed the connection]
<{^_^}> nix#2326 (by aszlig, open): Fix symlink leak in restricted eval mode
pie_ has quit [Ping timeout: 248 seconds]
orivej has joined #nixos-dev
FRidh has joined #nixos-dev
garbas has joined #nixos-dev
goibhniu has joined #nixos-dev
<LnL> did something change in nix repl of nixUnstable recently?
<LnL> it resets the cursor and clears the current line while typing
__Sander__ has joined #nixos-dev
vcunat has joined #nixos-dev
{^_^} has quit [Remote host closed the connection]
<timokau[m]> Whats the status of hydra emailing maintainers? Was that just never re-activated after the spam? Or was the issue never fixed?
<vcunat> Never reactivated AFAIK.
<ekleog> oh :/
<timokau[m]> Can we just do that, or is there some work involved?
<vcunat> Here's the line
<vcunat> I don't know how Hydra's mail works on the inside. (e.g. if it will try to re-send those mails or something)
<vcunat> niksnut: ^^
<niksnut> yeah it's disabled
<vcunat> and expected not to cause trouble if simply re-enabled?
<vcunat> My guess would be that the problem was that the *first* evaluation happenned with the feature on. On subsequent evaluations I'd expect only status changes would be e-mailed, but I might easily be wrong.
<niksnut> IMHO email notification is not really worth it
<niksnut> it causes more problems than it's worth, and most users don't care for it
<gchristensen> niksnut: here are the results from the EPYC testing: https://grahamc.com/blog/an-epyc-nixos-build-farm
<aminechikhaoui> \o/
<aminechikhaoui> gchristensen: didn't you get a huge speedup on the chromium build btw ?
<gchristensen> yeah, but it was predicated on a PR which didn't merge
<aminechikhaoui> oh
<niksnut> gchristensen: great :-)
<LnL> can people without an account access the maintainers page on hydra?
<gchristensen> I found some of our tests have pathalogical cases where they'll go from ~60s to run to ~30min-1hr
<LnL> also not everything is in there
<LnL> oh, meta.maintainers is broken on hyra Maintainer(s):not given
<LnL> niksnut: ^
<vcunat> EPYC: if one's buying the HW, the 16-core ryzens seem more economical than any epycs. At least for usual Hydra-like farm.
<vcunat> s/16-core/16-thread/
<thoughtpolice> vcunat: Threadripper is pretty good too and the prices are dropping ahead of the Zen refresh. But a lot of the cost is tied up in supporting gear though, so traditional Ryzens may be a better bet, yeah.
<thoughtpolice> More economical mobo options, etc. And if the hardware is physical, power should probably also be taken into account, considering Hydra will keep that sucker loaded....
<vcunat> Well, I didn't really look at power-efficiency, but I don't expect any drastic differences in there, if you go for similar GHz.
<vcunat> The electricity price at my home is only a fraction what you (apparently) pay for hiring the machine.
<gchristensen> an interesting thing is the epyc vs. the xeon saves ~100W
<vcunat> The zens certainly made high CPU performance much more affordable, finally.
<gchristensen> yeah, I mean, Packet.net isn't the cheapest way to get hw
<gchristensen> but that 20Gbps network isn't cheap to get :P
<timokau[m]> vcunat: niksnut: I think email notifications are very much worth it. How else are maintainers supposed to notice that their packages break? I think it is a very important step in minimizing hydra failures.
<gchristensen> and getting it at an hourly rate w/ no setup is nothing to sneeze at either.... and the spot market for super cheap prices ... haha ok maybe I'm a fanboy ;)
<vcunat> timokau[m]: yes, I don't know a better way ATM.
<vcunat> Most maintainers didn't react to the e-mails apparently, but if working reasonably reliably, the feature would seem a nice to have.
<timokau[m]> Yes and it was working reliably until the spam. If that is still a concern, maybe some stupid rate limiting would reduce the risk. Or worst case we could at least make it possible to opt-in.
<vcunat> I occasionally did get some weird messages for it for builds that were months old.
<vcunat> s/for it/from it/
<aminechikhaoui> vcunat: I saw that also in our private hydra, I think it has to do with the attempted fix here but not sure https://github.com/NixOS/hydra/pull/566
<aminechikhaoui> but it basically happens every time we restart the queue runner
<vcunat> well first we need to fix filling the maintainer colon, as without that data there won't be anyone to send to
<vcunat> (except for those messages: "your commit may have broken this build")
<vcunat> Eh, not "colon", but I guess you know what I mean :-)
<timokau[m]> In my opinion a few false-positives would be better than no positives at all :)
<timokau[m]> I didn't know there was also that kind of message. Aren't that usually a lot of commits?
{^_^} has joined #nixos-dev
{^_^} has joined #nixos-dev
{^_^} has quit [Changing host]
<vcunat> It certainly happened commonly that there were many.
<vcunat> > This may be due to 640 commits by ... (long list of authors)
<{^_^}> error: syntax error, unexpected ELLIPSIS, expecting ')', at (string):164:35
<gchristensen> infinisil: it would be neat if the eval bot noticed most of the tokens were words and didn't post an error if it fails to evaluate
<gchristensen> also I'd love a pony please
<infinisil> Yeah I could probably do that
<infinisil> Not the pony thing though :)
<vcunat> 🐎
<timokau[m]> Those messages should probably be disabled. Or even better only sent if up to X commits might be responsible.
<gchristensen> thanks vcunat <3 :)
<timokau[m]> Unicode is amazing
<vcunat> my client doesn't display it though
<timokau[m]> What, you're using a terminal without emoji support? How are you even functioning?
<vcunat> It's Pidgin :-)
<vcunat> (i.e. fully graphical)
<timokau[m]> I didn't know that was still alive (or ever supported irc)
<timokau[m]> Anyways, is there an appropriate place to file an issue for the email thing? That would probably benefit from more permanent discussion.
<vcunat> parsing the new meta.maintainers would probably be https://github.com/nixos/hydra
<vcunat> but I'm not sure if some other than Eelco watches it anyway :-)
<timokau[m]> I guess I can just file an issue against that repo (nixos-org-configurations)
<timokau[m]> And the problem with maintainers is that the parsing was just never adapted to the new maintainers format?
Sonarpulse has joined #nixos-dev
xeji has joined #nixos-dev
<vcunat> It's possible. I don't know if anything was attempted.
sir_guy_carleton has joined #nixos-dev
__Sander__ has quit [Quit: Konversation terminated!]
orivej has quit [Ping timeout: 265 seconds]
drakonis has joined #nixos-dev
vcunat has quit [Ping timeout: 240 seconds]
shlevy has quit [Ping timeout: 255 seconds]
shlevy has joined #nixos-dev
phreedom_ has joined #nixos-dev
phreedom has quit [Ping timeout: 250 seconds]
primeos_ has quit [Quit: WeeChat 1.4]
orivej has joined #nixos-dev
<LnL> dtz[m]: around?
drakonis has quit [Remote host closed the connection]
<Mic92> globin: fpletz https://github.com/NixOS/systemd/pull/21 is ready for merging. I try to also get the nixpkgs pull request sorted out this weekend so we have enough time for testing before the release.
<{^_^}> systemd#21 (by Mic92, open): systemd: 238 -> 239
FRidh has quit [Quit: Konversation terminated!]
drakonis has joined #nixos-dev
xeji has quit [Ping timeout: 260 seconds]
pie_ has joined #nixos-dev
pie_ has quit [Remote host closed the connection]
pie__ has joined #nixos-dev
pie_ has joined #nixos-dev
pie__ has quit [Ping timeout: 240 seconds]
sir_guy_carleton has quit [Ping timeout: 264 seconds]
Sonarpulse has quit [Ping timeout: 248 seconds]