gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
<cole-h> gchristensen: I'm gonna hold off on PRing this until I get in touch with srk to see if they're cool with me cherry-picking their hacking section from the Cachix PR while I'm already touching the README
<gchristensen> cool :)
<gchristensen> sounds good
<cole-h> Quick sanity check: tests run on all possible machines, right? (e.g. if it's `handleTest`, will run on darwin, x64, and aarch)
<cole-h> The "Note: this will only run on x86_64-linux machines." attached to the test subcommand is what's confusing me
<gchristensen> not sure, link?
<cole-h> Last sentence
<gchristensen> they run on all the machines teh user is authorized to
<gchristensen> I think
<cole-h> Yeah, that's what I thought. Thanks.
<gchristensen> cool
* cole-h checked his doas PR, which has tests run on aarch and x64
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 256 seconds]
<cole-h> Poor L*L. 15:24 <L*L> anyway, trying it out so hopefully I won't wake up to a giant gueue again
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<LnL> -_-
cole-h has quit [Quit: Goodbye]
{`-`} has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
tilpner has quit [Quit: tilpner]
hexa- has quit [Quit: WeeChat 2.7.1]
hexa- has joined #nixos-borg
cole-h has joined #nixos-borg
hmpffff_ has quit [Read error: Connection reset by peer]
hmpffff has joined #nixos-borg
<cole-h> gchristensen: Best PR title ever incoming (inspired by something you said last month)
<{^_^}> [ofborg] @cole-h opened pull request #482 → "Not you: team." (Rework README) → https://git.io/JfZFs
<gchristensen> <3<3<3
<cole-h> And its cousin: ofborg/infrastructure#21
<{^_^}> https://github.com/ofborg/infrastructure/pull/21 (by cole-h, 20 seconds ago, open): Remove {extra-,}known-users
<gchristensen> <3<3<3<3<3<3
<cole-h> (My revelation of being able to use commas in branch names yesterday was me trying to do something like "not-you,-team")
<cole-h> (But that looks kinda ugly)
<gchristensen> haha
<cole-h> And spaces obviously don't work :(
<gchristensen> no?
<cole-h> fatal: 'not you: team' is not a valid branch name.
<cole-h> fatal: 'not you team' is not a valid branch name.
<cole-h> :(
<gchristensen> ah
<gchristensen> try a UTF-8 space: « »
<cole-h> Still non va bene :(
<cole-h> Oh
<cole-h> It was the colon
<cole-h> utf-8 space works ;d
<cole-h> Switched to a new branch 'not you team'
<cole-h> brb closing that PR and opening another one
<cole-h> :P
<gchristensen> AH
<gchristensen> cole-h: try using the UTF
<gchristensen> -8 symbol for Ratio: «∶»
<cole-h> omg
<cole-h> wtaf
<cole-h> Real slick.
<cole-h> LOL
<cole-h> Invalid character: `:`. Valid character: `∶`
<cole-h> 🤔
<gchristensen> %CD%89%CD%89%CC%ABb%CD%90%CC%9A%CC%BD%CC%8F%CC%B6%CC%A8%CD%80%CC%98%CD%88%CC%AB%CD%89%CD%8Ea%CD%A9%CD%92%CD%9C%CC%9B%CC%B6%CC%A9%CC%A5%CC%AA%CC%9C%CC%B1%CC%A4%CC%ADr%CC%8B%CC%8C%CC%8D%CD%83%CC%9F%CD%93?expand=1
<cole-h> Oh no
<cole-h> lmfao
<cole-h> Also, I never noticed you could PR somebody else's branch...
<LnL> so tonight was this again
<LnL> builder 46166 ofborg 5u IPv4 0xbe45e342ca2edd73 0t0 TCP>core-0.ewr1.nix.ci:5671 (CLOSE_WAIT)
<LnL> interestingly the "send heartbeat" just kept going
<LnL> trying out beta4, I see some connection/heartbeat related changes in the diff
<gchristensen> hum
<LnL> heartbeat received stopped at 03:49 CEST
<cole-h> hum x2
<LnL> goes on until the time I killed it :p
<cole-h> F
orivej has joined #nixos-borg
evanjs has quit [Read error: Connection reset by peer]
evanjs has joined #nixos-borg
evanjs has quit [Read error: Connection reset by peer]
evanjs has joined #nixos-borg
<cole-h> gchristensen: Also thinking about removing the `grahamc` from `grahamcofborg-eval{,-check-{maintainers,meta}}` -- thoughts?
<gchristensen> it is tricky
<gchristensen> but we could do it
<gchristensen> the tricky bit is no PR with currently failed checks will get a green check if it is magically fixed by an ew eval
<gchristensen> but that is probalb yfine
<gchristensen> do it! :)
<cole-h> Could also do it in a follow-up
<gchristensen> meh, go for it
prusnak has joined #nixos-borg
<MichaelRaskin> Could you _remove_ grahamcofborg-eval checks but not create new ones?
<MichaelRaskin> Or maybe always set them to gray-box for the first stage of migration?
<cole-h> Harrumph. I don't want to deal with that now. I'll undo that change for this PR and think about it more... *waves hands* in the future
* cole-h adds TODO item
<cole-h> gchristensen: Mind taking another look at the README changes (especially the most recent `fixup`, which slightly rewords the "Trusted Users" section) when you have a chance?
<cole-h> MichaelRaskin: You so frequently have good insight. I'd be interested to hear your thoughts too, if you have some spare time: #482
<{^_^}> https://github.com/NixOS/ofborg/pull/482 (by cole-h, 4 hours ago, open): "Not you: team." (Rework README)
<MichaelRaskin> Oh nice, now GitHub diffs are also JS-only.
<MichaelRaskin> cole-h: is draft status detected now?
<cole-h> Do you mean for the WIP stuff? No, we don't use that as a metric for WIP.
<cole-h> s/metric/whatever suitable word you prefer/
<MichaelRaskin> Also, maybe drop @GrahamcOfBorg mention from documentation even if it still works for those who remember it?
<MichaelRaskin> Maybe mention that Draft status does not matter then
<cole-h> Only reason I hesitate doing so is because `@GrahamcOfBorg` does indeed still work (and probably will for the forseeable future)
<cole-h> Will mention draft status, good point.
<MichaelRaskin> Well, this is the user documentation, you tell people how to use it, not the precise limits of what works
<MichaelRaskin> You do not mention the precise timeouts either
<cole-h> Fair enough.
<MichaelRaskin> Actually, you do not mention the timeout _existence_
<MichaelRaskin> (So building Chromium is not just rude, it is pointless!)
<cole-h> Huh, I hadn't thought about that. Totally forgot we have timeouts :D
<MichaelRaskin> All committers are trusted users, right?
<cole-h> They must be added manually via PR.
<MichaelRaskin> Still?
<MichaelRaskin> Oh
<cole-h> I don't know if there are any committers that aren't a trusted user, but for any new ones they must be added to the list in config.public.json
<MichaelRaskin> Actually, given the regular discussions about FO derivations, I am not sure how good an idea it was to build everyone's PRs, not just limited. say, to maintainers
<cole-h> (brb, just froze my entire session)
cole-h has quit [Quit: Goodbye]
<MichaelRaskin> Hmm. Does anyone without commit access to ofborg run any builders nowadays?
cole-h has joined #nixos-borg
<cole-h> OK, I am back. re builders: Not that I know of. Pretty sure that stopped a while ago (before I got involved)
<MichaelRaskin> That's also what I assume
<MichaelRaskin> I mean, maybe then mark this chapter as «if you do not know, you do not need this»
<cole-h> Meaning the "Running a builder" section, yeah? Maybe it could just go to the wiki page linked at the end of it.
<MichaelRaskin> Maybe that
<cole-h> That page is probably due for a cleanup, anyways