gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
cole-h has quit [Ping timeout: 256 seconds]
<{^_^}> [ofborg] @LnL7 opened pull request #497 → relax PullRequestAction parsing → https://git.io/JfaqG
orivej has joined #nixos-borg
orivej has quit [Read error: Connection reset by peer]
orivej_ has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej_ has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
hmpffff has joined #nixos-borg
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
tilpner_ has joined #nixos-borg
tilpner has quit [Ping timeout: 256 seconds]
tilpner_ is now known as tilpner
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
maddo has joined #nixos-borg
hmpffff has joined #nixos-borg
maddo has left #nixos-borg ["See ya"]
orivej has quit [Ping timeout: 265 seconds]
orivej_ has joined #nixos-borg
cole-h has joined #nixos-borg
<cole-h> No; I don't think we even look further than the attr in the commit title. Would be nice if they could use -> since that's what is in the contributor guide. https://github.com/NixOS/ofborg/issues/318#issuecomment-622064367
<cole-h> The reason that PR didn't get evaluated originally is because the eval filter was choking on an unknown variant at the time. This has since been fixed.
<hexa-> ok
<hexa-> thank you
<cole-h> :)
<LnL> also unicode / inconsistency is annoying for other usecases like grep
<cole-h> s/for other usecases like grep//
<LnL> why not have git log | grep '->' just work?
<cole-h> Would be nice...
<cole-h> And just think about all the Unicode right arrows... We'd have to support a lot more than just `->` if we ever implement 318
<cole-h> Some are obviously nonsense, but there are a few that are somewhat vanilla (yet different)
<hexa-> fwiw, it's the result of compose + - + >
<hexa-> →
<LnL> there's a convention to make these kind of things nice, if we don't follow it there's not really a point to having the conventions
<cole-h> Or you could cut out 3 keys and just do `->` like the rest of us plebeians without a compose key ;^)
<hexa-> I will :)
<cole-h> <2
<cole-h> <3
<LnL> at least that's how I think about it
<hexa-> makes total sense
<cole-h> LnL++
<{^_^}> LnL's karma got increased to 59
<MichaelRaskin> cole-h: As for keys, for me -> is three keys (minus; shift-dot=greater) and → is actually 2 (ISO_Level3_Shift+i)!
<cole-h> Fair enough.
<cole-h> Maybe we change it to `attr: v1 to v2` :D
<MichaelRaskin> But improving simple grep usability is indeed an argument for unification, and -> is probably best from the _maximum_ keypress point of view across layouts
<MichaelRaskin> (note to self: create a «to» package for… something)
<cole-h> lol
<LnL> weird, what happened ~1h ago?
<LnL> ah it's the aarch builder
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
orivej_ has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 265 seconds]
hmpffff has joined #nixos-borg
<cole-h> LnL: nice build name :P
<LnL> :)
<cole-h> Noiiiiiiiice
orivej_ has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<cole-h> wooooooooowwwwwwwwwwww
<LnL> ^ so eg. we can now show consumers per queue (evaluation-filter vs mass-rebuilder)
<cole-h> That's pretty neat
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
<LnL> if you review #495 we can also deploy the final lapin parts
<{^_^}> https://github.com/NixOS/ofborg/pull/495 (by LnL7, 1 day ago, open): convert log-message-collector to easylapin
<cole-h> And then we can start ripping out the amqp-rust stuff making us keep around openssl :D?
<LnL> yep indeed, then I can continue with the cargo parts for that
* cole-h scrutinizes all uses of `queue_name`
<cole-h> :P
<cole-h> Minor nit, but LGTM
<LnL> slightly related, we can also see throughput for logs now https://monitoring.nix.ci/d/ADvFNGzMk/rabbitmq?orgId=1
<cole-h> Oooh nice
<LnL> those are all calculated over 5min
<cole-h> "ofborgsrv ofborgsrvc ofborgsrvc ... builder-grahamc! ofborgsrvc build-lnl7!" lol
<cole-h> Highly descriptive names :D
<LnL> hehe, it's connections per client
<LnL> but we only have the user there to identify
<LnL> slightly confused about that 14 tho
<cole-h> aarch64
<cole-h> If you check dashboard 02, there are 14 aarch64 builders up
<LnL> that should be 14 builders with 1 connection
<cole-h> Why's that?
<LnL> oh no, it's per host
<LnL> 6 evaluators/builders + core = ofborgsvc
orivej has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @LnL7 merged pull request #493 → lapin stats → https://git.io/Jf2q3
<{^_^}> [ofborg] @LnL7 pushed 2 commits to released: https://git.io/JfagK
<{^_^}> [ofborg] @LnL7 merged pull request #495 → convert log-message-collector to easylapin → https://git.io/Jf2SK
<{^_^}> [ofborg] @LnL7 pushed 4 commits to released: https://git.io/Jfagi
<{^_^}> [ofborg] @LnL7 merged pull request #497 → relax PullRequestAction parsing → https://git.io/JfaqG
<{^_^}> [ofborg] @LnL7 pushed 2 commits to released: https://git.io/JfagP
<cole-h> It sure is fun seeing those PRs get merged
<LnL> hmm, the comment poster is sending heartbeats but there's no consumer for build-results?
<LnL> aww :/
<LnL> https://monitoring.nix.ci/explore?orgId=1&left=%5B%22now-1h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bunit%3D%5C%22ofborg-github-comment-poster.service%5C%22%7D%20%7C%3D%20%5C%22received%5C%22%22%7D,%7B%22mode%22:%22Logs%22%7D,%7B%22ui%22:%5Btrue,true,true,%22none%22%5D%7D%5D
<cole-h> :(
<LnL> so it connected after the restart but never received a heartbeat
<LnL> gchristensen: could you run an lsof -p on the comment poster?
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
<{^_^}> [ofborg] @LnL7 opened pull request #498 → lapin: 1.0.0-beta4 -> 1.0.0-rc6 → https://git.io/Jfa2X
<LnL> ^ can't really restart anything without a deploy at the moment, but maybe that also fixes some bugs
<gchristensen> sure LnL
<LnL> yeah close wait again, I'll make an issue
orivej_ has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
<cole-h> Might also explain the 2 missing aarch builders
<LnL> probably
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
<LnL> urgh build error with the update, could you also restart it?
<gchristensen> hm?
<cole-h> The travis run, I assume
<cole-h> LnL: (though pedantry still fails)
<LnL> yeah, but the nix-build too
<cole-h> Right, but if you push a commit fixing the pedantry check, it'll start a new job, including nix-build... :P
<LnL> don't follow
<LnL> no `native_tls_crate` external crate
<cole-h> I was saying you could restart the travis run yourself just by pushing another commit (e.g. fixing the cargo fmt error from the pedantry check)
<LnL> gchristensen: restarting the comment poster
<cole-h> lol sorry :D
<cole-h> I completely misunderstood
<cole-h> (and caused gchristensen to restart the travis build on the lapin bump lmao)
<LnL> oh boy
<cole-h> x)
<LnL> I certainly confused y'all didn't I :)
<cole-h> Or me, at least hahaha
<gchristensen> restarted :)
<LnL> ok great, hopefully somebody looks at the issue soon
<LnL> maybe it's something straightforward that could still be fixed before 1.0 :)
<cole-h> If we all thumbs-up the issue, it might become a high priority :P https://github.com/sozu-proxy/lapin/issues/283
<{^_^}> sozu-proxy/lapin#283 (by LnL7, 12 minutes ago, open): Closed connection doesn't always stop consuming
<cole-h> But I think it will be fixed anyways. The guy(s) in charge seem eager to clean out their issue tracker (by fixing bugs and answering questions, that is).
<LnL> yeah
<LnL> part of the reason why I liked the idea of switching to it
<cole-h> Don't forget being able to drop openssl 1.0.2u :D
orivej has quit [Quit: No Ping reply in 180 seconds.]
<LnL> last real change in rust-amqp was 2 years ago
orivej has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]