gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
orivej has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
hmpffff has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
orivej has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
orivej has quit [Ping timeout: 260 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
hmpffff has quit [Quit: nchrrrr…]
kalbasit_ has joined #nixos-borg
infinisi1 has joined #nixos-borg
thefloweringash has quit [*.net *.split]
infinisil has quit [*.net *.split]
kalbasit has quit [*.net *.split]
kalbasit_ is now known as kalbasit
thefloweringash has joined #nixos-borg
hmpffff has joined #nixos-borg
orivej has joined #nixos-borg
hmpffff has quit [Quit: Bye…]
infinisi1 is now known as infinisil
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
cole-h has joined #nixos-borg
orivej_ has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
<cole-h> gchristensen: have you written down what the "workflow issues we need to resolve" are, anywhere? (catching up on the editorconfig stuff) Or maybe you talked about them when we were discussing this and I missed it/don't remember
<gchristensen> can we snooze this question 1 week
<cole-h> Yes indeed
<cole-h> Just making sure I didn't miss anything
<gchristensen> thans
<LnL> any particular reason for that snooze?
<cole-h> He's got a talk tomorrow ;)
<cole-h> Probably a whole bunch of other stuff going on
<LnL> so, running checks like that is pretty much the same thing as the lib tests if you ask me
<LnL> something that tests nixpkgs, but but without using dependencies from that checkout
<LnL> one idea to solve that is to use the channel for these and then also make that build a constituent of the tested job
<LnL> that way there's no magic nixpkgs version involved but it's still guaranteed not to break with updates
hmpffff has joined #nixos-borg
evanjs has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
<LnL> looks like block_on is probably going to be fixed
<cole-h> Where, async-std or smol?
<LnL> both :::)
<cole-h> Oh? It sounded like it was a desired change
<LnL> yeah, but one of the smol contributers made a pr to fix it
<{^_^}> stjepang/smol#147 (by dignifiedquire, 3 hours ago, open): feat: allow recursive block_on calls
<{^_^}> async-rs/async-std#799 (by dignifiedquire, 3 hours ago, open): fix: allow for recursive block-on calls
<LnL> definitively seems like a reasonable usecase to me
<cole-h> Yay :)
<LnL> if you can't use anything synchronous that uses futures internally that would be pretty bad
<cole-h> Yeah, agreed
<LnL> which is basically what's happening for us I think
<cole-h> Yep. +1 to this dude.
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<LnL> cole-h: would be great to rework some parts of the code like the evaluator
<LnL> lot's of optionals there that get filled in as the steps progress
hmpffff has quit [Quit: nchrrrr…]
<cole-h> Like *_diff, changed_paths, and touched_packages?
<LnL> yeah
<LnL> using an enum as a statemachine is one way of doing that
<LnL> but that's literally what async await does, with all it's downsides like pinning
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
<cole-h> Sounds interesting. What do you imagine it'll buy us, just cleaner code? I'll take a look later today/tomorrow.
<LnL> I'm thinking something more event / middleware like but haven't really wrapped my head around it yet
hmpffff has joined #nixos-borg
<cole-h> I haven't done anything event-driven before (guess it's time to start learning), so let me know when you do wrap your head around what you're thinking :P
orivej_ has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
orivej has quit [Ping timeout: 265 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<cole-h> Nice, recursive block_on was merged to smol. Now to wait for the async-std PR to merge as well as bumps from both :D
<LnL> yeah
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
<LnL> what are your thoughts on the packet-exporter?
<gchristensen> I like it and would actually like to make it its own thing deployed for status.nixos.org
<LnL> I'd like to look into the metrics a bit
<gchristensen> but I don't want to put that req. on you
<LnL> heh, yeah makes sense
<LnL> "Currently just checks status.packet.com for incidents, perhaps doesn't
<LnL> now."
<LnL> really belong in ofborg but having it here makes it easier to deploy for
<LnL> how / where would you like it?
<gchristensen> ofborg is totally fine
<gchristensen> but if you want to make it its own "thing", could do it as a nixos org project, or maybe packet would like to take it
<LnL> it's a separate crate so I can easily put it in a separate repo
<LnL> and well... I'm kind of familiar with how to setup crate2nix now :D
<LnL> so question is just how you'd like to reference it in the nixos infra
<gchristensen> let's deal with that tomorrow, it'd have to be a flake and a module
<LnL> no rush
<LnL> I've been intentionally keeping away from flakes until now so I know next to nothing of it's details
<LnL> I could be a good guinea pig for something
<gchristensen> me too
<cole-h> We could all learn together :D
<LnL> wanted to be able to take a fresh look without knowing too much history, etc. but I think things have settled down enough at this point that it might be good to take a look
<gchristensen> cool
<LnL> this is probably also one of the most straightforward usecases
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @LnL7 opened pull request #510 → builder metrics → https://git.io/Jfr5h
<LnL> ^ same approach as packet
<gchristensen> nice
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
cole-h_ has joined #nixos-borg
cole-h has quit [Ping timeout: 256 seconds]
orivej has quit [Ping timeout: 265 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
cole-h_ is now known as cole-h
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg