gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej has joined #nixos-borg
tilpner_ has joined #nixos-borg
tilpner has quit [Ping timeout: 265 seconds]
tilpner_ is now known as tilpner
orivej has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
evanjs has quit [Ping timeout: 256 seconds]
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @cole-h opened pull request #503 → tasks/eval: label package updates → https://git.io/JfVsX
<cole-h> ^ despite how simple it looks, this one carries a decent amount of baggage...
<cole-h> It kinda leaves me wondering if it would even be desirable to auto-label package updates...
orivej has quit [Ping timeout: 272 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej_ has quit [Ping timeout: 240 seconds]
hmpffff has joined #nixos-borg
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej_ has quit [Ping timeout: 264 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 246 seconds]
orivej_ has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
hmpffff_ has quit [Quit: nchrrrr…]
orivej has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 256 seconds]
WilliButz has quit [Quit: bye]
WilliButz has joined #nixos-borg
hmpffff_ has quit [Quit: nchrrrr…]
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej_ has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Read error: Connection reset by peer]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
cole-h has joined #nixos-borg
orivej has joined #nixos-borg
orivej_ has quit [Ping timeout: 256 seconds]
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
<cole-h> Is there a reason ofborg uses `nix-build ./nixos/release.nix -A tests.test` rather than `nix-build . -A nixosTests.test`?
<cole-h> Using `-A nixosTests.test` would solve ofborg#504 AFAICT -- `nix-build ./nixos/release.nix -A tests.hostname` does jack, but `nix-build . -A nixosTests.hostname` runs both tests just fine.
<{^_^}> https://github.com/NixOS/ofborg/issues/504 (by vcunat, 16 minutes ago, open): support test *sets*
<LnL> nixosTests didn't exist
<LnL> and I still kind of thing it shouldn't
<cole-h> Why's that?
<LnL> nixos is already very tightly coupled to nixpkgs, but now the reverse is also true which is bad IMHO
<LnL> while it's in the same repo for convenience nothing in nixpkgs should reference nixos
<LnL> same with lib -> nixpkgs
* LnL hopes this will become better again with flakes
orivej has quit [Ping timeout: 256 seconds]
orivej_ has joined #nixos-borg
<LnL> that said, it's a thing now so we might as well use it
<MichaelRaskin> Hmm, what about tests?
<MichaelRaskin> Given we are effectively not allowed to have NixOS-independent GUI package tests…
<LnL> there are some pure nixpkgs tests, like lib or the cc-wrapper stuff
<MichaelRaskin> Some, but for Chromium one in principle wants to refer to NixOS Chromium test
<LnL> that's fine but then it's a nixos test
<MichaelRaskin> But if I ask «does Chromium still work after this change», I do want to have a reference to them
<LnL> doesn't mean chromium needs to magically point to another project
<MichaelRaskin> Are you willing to write an RFC about that?
<MichaelRaskin> I would actually be very happy with the claim that NixOS tests must not be used for Nixpkgs so Nixpkgs is allowed to have its own tests even if there is some feature intersection in the supporting code.
<LnL> what would that be in practice?
<MichaelRaskin> NixOS tests not being an unreasonable pile of overhead would be nice anyway, but there is no a chance of it happenning
<MichaelRaskin> there is now a chance
<MichaelRaskin> Well, you need to launch some X and some D-Bus to test LibreOffice
<LnL> one thing I've thought about is essentially splitting the tree up while evaluating
<LnL> eg. evaluating lib without pkgs or nixos in the tree, pkgs without nixos, etc.
<LnL> as for actual vm tests, I'm probably not really familiar enough with low level linux stuff to know how to deal with that
<MichaelRaskin> Well, Eelco Dolstra has figured out what is needed to run containers inside the Nix builds
<LnL> there's also _a lot_ you can do with just a regular build, the reason that the vm tests are easy/nice is because all of the setup/configuration logic is in the modules
<MichaelRaskin> At that level modules are not worth it, you don't need much
<MichaelRaskin> But if one can just run a NixOS container inside the build, then sure, why not just run tests there
<LnL> yeah then we're basically back at nixos vs things like vim_configurable
<cole-h> Also, tangentially related to the above issue: why are we using `restrict-eval` if the borg user isn't trusted? I think that message appears in every single log I've ever looked at...
<LnL> that warning wrong, it's an evaluation time setting so only relevant to the client
<LnL> is*
orivej has joined #nixos-borg
orivej_ has quit [Ping timeout: 264 seconds]
<cole-h> Oh, OK.
<MichaelRaskin> LnL: not sure how people not thinking that encapsulated conigurability is good relates to test
<LnL> MichaelRaskin: not sure I totally understand what you said
<MichaelRaskin> How the testing strategy relates to «nixos vs things like vim_configurable» ?
<LnL> I mean that most of the tests don't need nixos or a vm, they could easily be a simple build
<MichaelRaskin> Almost no tests actually require a VM
<MichaelRaskin> And realistically they don't require NixOS if they just need to wait until X is up and to launch a D-Bus session
<LnL> even not all that, a whole bunch of tests just start a server and test a client against it
<MichaelRaskin> Well, yes, sure. But then some of these are already included in the upstream source
<MichaelRaskin> The things that suddenly break weirdly and not for everyone are things like LibreOffice that require at least something
<LnL> right, that's more of a technical issue than the interfacing between stuff
<cole-h> LnL: What happens if you run `nix-build ./release.nix -A nixosTests.<any test that doesn't support darwin, which I think is all of them>`?
<cole-h> If the answer is "it fails with an error code", then I'll need to do more work to switch us to `nixosTests`
<LnL> yea there's a thing somewhere, sec
<cole-h> I know we have `can_run_nixos_tests`, but that is currently used on `Subset::NixOS` -- my changes makes tests be a `Subset::Nixpkgs`
<cole-h> (I assume that's what determines `nix-build ./nixos/release.nix` vs `nix-build ./default.nix`)
<LnL> yeah so currently it's assumed that ./nixos/release.nix means no darwin
<LnL> btw do we deploy the cargo update today?
<cole-h> Sure. You wanna get the openssl drop in before or after?
<LnL> I mean that
orivej_ has joined #nixos-borg
<cole-h> oh
<cole-h> lol
<LnL> I think the lapin bump is already live
<{^_^}> [ofborg] @LnL7 merged pull request #502 → remove openssl 1.0.2 → https://git.io/JfVkS
<{^_^}> [ofborg] @LnL7 pushed 6 commits to released: https://git.io/JfVFr
orivej has quit [Read error: Connection reset by peer]
<cole-h> I don't think so -- it was merged ~1 PM my time, and last buildkite was 11 AM my time
<cole-h> Yeah, last deploy was crate2nix
<LnL> oh, maybe it was a bit late yesterday
<cole-h> And we're off to the races
<LnL> heh, you beat me to it :)
<cole-h> >:)
<cole-h> Payback for last time >:P
<cole-h> Does the ofborg jobset build automagically, or does it need to be kicked off?
<LnL> you mean hydra for the aarch builder?
<cole-h> I think so, yeah
<LnL> that runs periodically, but I can start an eval
<cole-h> Buildkite deploys to aarch, right?
<LnL> yeah, forgot how frequently that runs tho
<cole-h> Oh it's not the ofborg deploy but the nix-community deploy
<cole-h> I think Graham said it runs ~weekly. Already deployed this morning.
<cole-h> I can't remember: does aarch *need* the hydra jobset to get the borg update, or does it just use that as a cache so it doesn't have to build it itself?
<LnL> it uses the last successful build
<cole-h> Right, OK. Thanks for kicking off the eval.
hmpffff has quit [Quit: nchrrrr…]
<cole-h> Alright, real deploy begins.
<cole-h> LnL: Something about the lapin bump doesn't look good.
<cole-h> thread 'main' panicked at 'cannot run an executor inside another executor', <::std::macros::panic macros>:2:4
<cole-h> Over and over again in ofborg-evaluator.service
<LnL> yeah something's not right there
<cole-h> That's a huge stack trace
<cole-h> 58 whatevers (frames? idk)
<{^_^}> [ofborg] @LnL7 opened pull request #505 → Revert "lapin: 1.0.0-beta4 -> 1.0.0-rc6" → https://git.io/JfVbG
<MichaelRaskin> LnL: I mean, the stuff where tests are most beneficial is also the stuff where we do need something that can be criticised as feature duplication with NixOS tests
orivej_ has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
<LnL> true
<cole-h> LnL: Probably want to kick off another hydra eval as soon as the revert merges, so aarch doesn't get the seemingly-busted lapin (if you hadn't thought about that already)
<LnL> hrm, very good point
<LnL> I wonder how we ended up with nested executors tho
<{^_^}> [ofborg] @cole-h merged pull request #505 → Revert "lapin: 1.0.0-beta4 -> 1.0.0-rc6" → https://git.io/JfVbG
<{^_^}> [ofborg] @cole-h pushed commit from @LnL7 to released « Revert "lapin: 1.0.0-beta4 -> 1.0.0-rc6" »: https://git.io/JfVb5
<cole-h> What
<cole-h> What?????
<cole-h> LnL: You jinxed it, it's looking like openssl needs to revert as well
<cole-h> I don't know why
<LnL> hmm really?
<LnL> just managed to setup the a config here and it seems to run atleast
<cole-h> Yep, still getting "cannot run an executor inside another executor"
<cole-h> inb4related to the hyper-native-tls bump....
<{^_^}> [ofborg] @LnL7 opened pull request #506 → revert openssl → https://git.io/JfVNl
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<cole-h> It looks like it's because of a bump to async-std
<cole-h> It now pulls in smol
<cole-h> So maybe that revert is unnecessary and we can get away with pinning to async-std 1.5.0?
<LnL> oh, let's try that
<{^_^}> async-rs/async-std#795 (by humb1t, 8 hours ago, open): "Cannot run an executor inside another executor" - in tests
<cole-h> Related it looks like
<LnL> joy
<{^_^}> [ofborg] @LnL7 opened pull request #507 → async-std: 1.6.0 -> 1.5.0 → https://git.io/JfVNP
<cole-h> ...I really need to set up my own borg stuff
<LnL> well doesn't look like I can reproduce it with the builders so that's rather tricky
<cole-h> It's only the evaluator service from what I saw, so maybe that's why?
<cole-h> jk nvm
<cole-h> I see one on the builder
<LnL> hmm, maybe only at a specific point then? it's not entirely done yet
<cole-h> It seems to happen after "consumed delivery"
<LnL> yeah that's the beginning
<LnL> oh panics at the end here
<LnL> ok let's see if async-std helps there then
<cole-h> "resolved" OK, sure, pushover :P
<LnL> cole-h++
<{^_^}> cole-h's karma got increased to 63
<LnL> thats it!
<{^_^}> [ofborg] @LnL7 merged pull request #507 → async-std: 1.6.0 -> 1.5.0 → https://git.io/JfVNP
<{^_^}> [ofborg] @LnL7 pushed 2 commits to released: https://git.io/JfVAY
<cole-h> You saw the panic, and that version downgrade fixed it?
<LnL> yeah panic on released and not with the branch
<cole-h> If this works, we'll see `Revert "Revert "lapin: 1.0.0-beta4 -> 1.0.0-rc6""` :D
<cole-h> (hopefully)
<cole-h> (Would be nice to see that the lapin bump doesn't reintroduce that somehow)
<cole-h> Not gonna lie, those SSL errors always spook me out. I was watching the evaluator logs saying "Yes! Yes! Yes! *sees SSL errors that happen every time* NO! *sees no backtraces and loads of heartbeats* YES!!!"
<cole-h> LnL++
<{^_^}> LnL's karma got increased to 64
<cole-h> Evaluators exist again!
<LnL> 😅
<{^_^}> [ofborg] @LnL7 closed pull request #506 → revert openssl → https://git.io/JfVNl
<LnL> away with that branch 🙃
<cole-h> Phew, so you didn't jinx us :D
<cole-h> We just got really unlucky :)
<cole-h> When you have some time, it might be nice to post a little something on that related issue (or open a new one). I ask you because you did all the async stuff :P I haven't dipped my toes in to that ecosystem yet.
<{^_^}> [ofborg] @LnL7 opened pull request #508 → lapin: 1.0.0-beta4 -> 1.0.0-rc6 → https://git.io/JfVAS
<LnL> still works ™️
<cole-h> inb4it gets reverted again. Knock on wood.
<LnL> ready for another round or was that enough excitement for today? :D
<cole-h> lmao, let's do it.
<LnL> thank you for the status updates btw
<cole-h> :^)
<cole-h> I gotta earn my keep somehow.
<LnL> also a rollback button would have been nice right about now
<cole-h> Hahaha
<{^_^}> [ofborg] @cole-h merged pull request #508 → lapin: 1.0.0-beta4 -> 1.0.0-rc6 → https://git.io/JfVAS
<{^_^}> [ofborg] @cole-h pushed commit from @LnL7 to released « lapin: 1.0.0-beta4 -> 1.0.0-rc6 »: https://git.io/JfVxU
<cole-h> It's only 2:30PM and I already want to crack open a cold one...
* cole-h is spam-clicking "run query" on the ofborg-evaluator.service logs
<cole-h> I SEE LOTS OF HEARTBEATS
<cole-h> I THINK WE'RE SAFE
<cole-h> <33333333 LnL++
<{^_^}> LnL's karma got increased to 65
<LnL> press live view in the top right
<cole-h> Yeah I know
<cole-h> But it isn't as suspenseful as obsessively clicking :D
<cole-h> Oh cool, I can start ofborg evaluations too
<cole-h> Hydra evaluations*
<LnL> ok now... what was I doing again?
<cole-h> Hahahahahahaha
<cole-h> https://i.imgur.com/YPssgam.png Phew, good work for the week. See y'all next Monday.
<cole-h> :P
andi- has quit [Quit: WeeChat 2.8]
andi- has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
<LnL> man, I'm really liking this git deploy stuff
<cole-h> Oh yeah, I think you posted the output of it before... Do you have the actual hook itself anywhere public? ;)
<LnL> I have some other stuff to deal with inputs like channels, but that's really hacky at the moment
<cole-h> Ah, the ofborg jobset checks every 3600 something (probably minutes) -- just gotta look at its configuration
orivej has quit [Ping timeout: 256 seconds]
<cole-h> LnL: And that's pretty cool. Forces you to commit everything, eh?
orivej_ has joined #nixos-borg
* cole-h looks at his "everything else: update" commit messages
<LnL> heh yeah, this is the commit log of my pure stuff https://gist.github.com/LnL7/8cf4984ff394842079c0d9be48794622
<cole-h> lol
<LnL> actual commit messages feel kind of pointless for this sometimes
<cole-h> That's pretty cool that you tag each commit with its corresponding generation
<cole-h> And have the hash in the commit message :P
<LnL> so each commit has the store hash instead
orivej_ has quit [Ping timeout: 264 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej has joined #nixos-borg
orivej has quit [Read error: Connection reset by peer]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg