gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 272 seconds]
LnL has quit [Ping timeout: 256 seconds]
LnL has joined #nixos-borg
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
<{^_^}> [ofborg] @cole-h opened pull request #452 → Logging cleanup → https://git.io/JvNMP
hmpffff has joined #nixos-borg
hmpffff has quit [Remote host closed the connection]
hmpffff_ has quit [Ping timeout: 272 seconds]
hmpffff has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 256 seconds]
LnL has quit [Read error: Connection reset by peer]
LnL has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff__ has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 272 seconds]
hmpffff has quit [Ping timeout: 265 seconds]
<{^_^}> [ofborg] @grahamc merged pull request #452 → Logging cleanup → https://git.io/JvNMP
<{^_^}> [ofborg] @grahamc pushed 4 commits to released: https://git.io/JvNH6
hmpffff has joined #nixos-borg
hmpffff__ has quit [Ping timeout: 272 seconds]
orivej has quit [Ping timeout: 264 seconds]
<{^_^}> [ofborg] @grahamc pushed 3 commits to handle-errs-better: https://git.io/JvN70
<{^_^}> [ofborg] @grahamc opened pull request #453 → Handle errs better → https://git.io/JvN7E
<{^_^}> [ofborg] @grahamc merged pull request #453 → Handle errs better → https://git.io/JvN7E
<{^_^}> [ofborg] @grahamc pushed 4 commits to released: https://git.io/JvN7H
<{^_^}> [ofborg] @grahamc pushed 0 commits to handle-errs-better: https://git.io/JvN7Q
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 265 seconds]
hmpffff has quit [Quit: Bye…]
<{^_^}> [ofborg] @grahamc pushed to label-log « labeling: make log messages one-line »: https://git.io/JvNpA
<{^_^}> [ofborg] @grahamc opened pull request #454 → labeling: make log messages one-line → https://git.io/JvNpx
cole-h has joined #nixos-borg
<cole-h> gchristensen: Thoughts on using a display impl rather than debug for hubcaps errors?
<gchristensen> I don't have thoughts yet :)
<cole-h> It will make those pesky multiline backtraces from error-chain that (I think) have no use disappear
<{^_^}> [ofborg] @grahamc merged pull request #454 → labeling: make log messages one-line → https://git.io/JvNpx
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/JvAfL
<gchristensen> yeah, so I wish those backtraces were actually useful :/
<gchristensen> them being empty makes very hard to figure out why they're happening when the cause is github changing their APi responses
<cole-h> At this point, I don't know whose problem it is, hubcaps or error-chain
<cole-h> ... or backtrace itself
<gchristensen> I think it has to do with release builds
<gchristensen> I don't know how to tell carnix to turn off release builds
<cole-h> I don't think that's the problem actually: https://i.imgur.com/HxFCDwS.png
<gchristensen> huh
<cole-h> Something doesn't seem right here... 🤔 https://i.imgur.com/2cTsOad.png
<gchristensen> lolll
<gchristensen> s/id/number/
<gchristensen> that whole bit of code won't be needed once slog is there, and the PR # and the repo information can be passed down in slog context
<{^_^}> [ofborg] @grahamc pushed 0 commits to label-log: https://git.io/JvAJX
gleber__ has joined #nixos-borg
gleber_ has quit [Ping timeout: 246 seconds]
gleber__ is now known as gleber_
<cole-h> gchristensen: "Bad credentials" internal error on `tasks::evaluate::update_labels`. Never seen one of those before. Transient, or indicative of a bigger problem?
<gchristensen> huh
<gchristensen> maybe the token given out by the vending machine has expired by then
<cole-h> Looks like it was caused by treewide RFC45 again lol
<gchristensen> guh, lol
<cole-h> JK maybe not
<LnL> thought about that one
<gchristensen> I wonder if we can just make the token last longer
<LnL> no idea how much work it would be, but what if we add an option to nix to disable unquoted url parsing and have ofborg use that?
<gchristensen> that sounds like a decent idea once we've gotten the transition done
<gchristensen> another option could be reporting the # of unquoted URLs identified and diffing
orivej has joined #nixos-borg
<LnL> uhoh
<LnL> nix-instantiate --eval -E https://nixos.org --option experimental-features no-url-literals
<gchristensen> :|
<LnL> isn't this good?
<cole-h> Appears to need nixUnstable (or at least, I needed to `nix-shell -p nixUnstable` for it to function). Idk what version ofborg uses
<gchristensen> ohh
<gchristensen> okay
<gchristensen> it returned a string just fine here, so it didn't do what I was expecting :)
<cole-h> lol. Yeah, I get "warning: unknown setting 'experimental-features'" on 2.3.3
<cole-h> re: backtraces, I wonder if it would be enough to set `debug = 1` for the release profile
<gchristensen> it might be!
* cole-h wonders what the difference between "line tables" and "full debug info" is
<gchristensen> not sure, and tbh not sure I care, ofborg has 1 maybe 2 hot loops :P
<cole-h> so, want a PR -> `debug = true` (full debug)? (or can do it yourself :P)
<gchristensen> yep, send it along :)
<cole-h> If performance regresses by a huge amount, it's easy to change
<gchristensen> probably nobody would notice
<cole-h> Until we start seeing purple labels because of timeouts or something
<{^_^}> [ofborg] @cole-h opened pull request #455 → Cargo.toml: enable debug symbols in release profile → https://git.io/JvALw
<gchristensen> cole-h: probably need to re-run carnix
<cole-h> Yep x)
<cole-h> Ran the script and nothing changed. Did I forget something?
<cole-h> (also looks like the failure was network-based -- curl failed)
<gchristensen> no clue, sounds fine
<cole-h> checkPhase nix1 works fine. Is it possible to restart a single travis job?
<cole-h> Thanks. Here's hoping it doesn't happen again
<gchristensen> :)
<cole-h> Also, somewhat unrelated, but why do my local runs of checkPhase with `useNix1 = false` pass all tests, yet `useNix1 = true` fails 13 tests? Have you run into this before?
<gchristensen> ehhhh I'm ... not sure ..
<cole-h> Possibly related to me not being on NixOS proper, but nix2 succeeds so idk...
<cole-h> Well, CI is happy, so I'm happy.
<{^_^}> [ofborg] @grahamc merged pull request #455 → Cargo.toml: enable debug symbols in release profile → https://git.io/JvALw
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/JvALj
hmpffff has joined #nixos-borg
<cole-h> Doesn't seem to have made a difference :(
<gchristensen> hrm\
hmpffff has quit [Quit: Bye…]