gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
cole-h has quit [Quit: Goodbye]
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Read error: Connection reset by peer]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @NickHu opened pull request #509 → config.public.json: add NickHu to trusted_users → https://git.io/Jfwg7
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
hmpffff has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 264 seconds]
orivej_ has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej_ has joined #nixos-borg
orivej has joined #nixos-borg
orivej_ has quit [Ping timeout: 272 seconds]
hmpffff has quit [Quit: nchrrrr…]
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 265 seconds]
cole-h has joined #nixos-borg
orivej_ has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Read error: Connection reset by peer]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 265 seconds]
<cole-h> gchristensen++ btw. Thanks for setting up Loki a while back -- being able to see the logs made identifying and debugging yesterday's issue 10000x easier, and slightly less stressful :D
<{^_^}> gchristensen's karma got increased to 304
<gchristensen> yay!
<gchristensen> good :)
<gchristensen> thanks to hexa- for giving me all the answers on how
<cole-h> hexa-++ As well, then :D
<{^_^}> hexa-'s karma got increased to 5
<LnL> oh boy can't imagine how this would have gone without logs
<cole-h> Not very well
<cole-h> "Oh no we need to revert the lapin bump"
<cole-h> "Wait it's still happening we need to revert the ssl drop"
<cole-h> "OK, it's good, now what changed"
<cole-h> etc etc
<LnL> probably wouldn't have attempted a cargo update in that case however
<hexa-> yay, glad to be of help
<LnL> you also use it in production somewhere?
<hexa-> not yet, no. I'm collecting logs for a bunch of APs currently.
<LnL> one thing I'm still kind of missing compared to other things are columns for labels
<hexa-> are the logs visible somewhere?
<LnL> there's a dashboard with filtered stuff but not everything
<hexa-> I'm especially interested in how well metadata is collected
<hexa-> oh ok, found it
<hexa-> oh the context thingy looks neat
hmpffff has joined #nixos-borg
<gchristensen> I want to setup loki on the foundaiton's infra too but I haven't gotten to it
<hexa-> that is pretty good
<hexa-> now alerting with loki needs to become a thing
<LnL> pr is the one we've been adding to the code
<hexa-> yep
<cole-h> I do alert based on loki :D
<cole-h> Well, only for `ofborg-internal-error`s, and only to my Discord server (since setting up something else would have been a pain)
<hexa-> cool, how hackish is it?
<hexa-> does it go via alertmanager?
<cole-h> Not at all, there's an exporter for it IIRC
<LnL> euh, what's up with 88195?
<hexa-> so … loki -> prom -> alermanager?
<cole-h> All I had to do was add a prometheus data source pointing to Loki
<LnL> well you can perform some prometheus queries on loki so for those I think you could
<LnL> but in general alerting/metrics based on logs is a bit of a smell IMHO
<cole-h> x)
<LnL> add some metrics instead :)
<cole-h> LnL: lmaooo
<hexa-> certainly not best in slot
<hexa-> but some services like to log errors and not … crash or whatever
<LnL> oh no wonder the log count blew up
orivej has joined #nixos-borg
<LnL> hexa-: not saying never do it, just shouldn't be your first choice
<hexa-> it is not, it's an addition to lots of prometheus exporters
<LnL> the aarch builders wheren't updated yet right?
<cole-h> Nope, last build was yesterday, before the fiasco
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
<LnL> btw do you have any particular opinions on the update labels?
<LnL> just wondering what it would be used for
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
<cole-h> I think etu put it well in the issue: "This makes it easier to filter pull requests on updates which would make it easier to find potential pull requests that are "easy" to test, for example patch or minor version bumps."
<cole-h> However, I'm not married to the idea
<cole-h> Really, it was just a way to get me writing Rust again, and was one of the simplest things on my todo list... :P
<LnL> ok so same idea basically
<cole-h> Although
<cole-h> I guess the "rebuild: 1" label kinda fulfills this niche...
<cole-h> Wait no
<LnL> not really, rebuild: 1 and package:new indicate very low impact
<cole-h> I had a lapse of brainpower for a moment
<LnL> that's why new makes more sense just on it's own
<cole-h> Yeah, I'm coming around...
<cole-h> Because even bumping something like glibc would get that label when it's decidedly not ever a trivial review
<LnL> sure, but that will also have a bunch of other scary labels
orivej has quit [Ping timeout: 246 seconds]
<LnL> it's fine by me as is but I think package detection would be a nice improvement, that would avoid some clearly wrong cases
orivej has joined #nixos-borg
<cole-h> So you're thinking something like `if commit has "->" and attr is in changed packages list, then add label`?
<LnL> yeah
<LnL> that way 1. it's definitively an attr 2. it's not a function, packege set, etc.
<cole-h> Got it. I think we were talking past eachother (or, equally likely, I was misunderstanding) lol
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
<cole-h> Wow, great idea, actually. I didn't even think about the generic-package-set-update case (e.g. `haskellPackages: hackage -> something else`).
<LnL> I think it won't be that hard either, if you move this down a bit everything should be available to do that
<cole-h> Yeah, I looked at it a bit yesterday. Should be easy.
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Quit: No Ping reply in 180 seconds.]
hmpffff has joined #nixos-borg
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
<cole-h> btw, this comment is accurate, right? https://github.com/NixOS/nixpkgs/issues/88867#issuecomment-633595164
<cole-h> About to send a PR to the rfc55 tool repo that filters out borg so it doesn't show up every time if that is indeed the case.
<LnL> I'm not sure it is
<cole-h> Although, that would break borg if for whatever reason an admin decided to take away the labelling perms from people (due to abuse maybe)
<cole-h> s/from people/from the maintainers team/
<LnL> could be wrong but I would assume checks go through oauth like permissions
<LnL> eg. there's no travis user, there's a travis app that you authorize with certain permissions
<cole-h> Yeah, makes sense.
<gchristensen> github 50% uses app perms and regular user perms
<gchristensen> commit statuses are user perms, checks areapp status
<cole-h> ...
<cole-h> GH pls
<LnL> hrm that's weird :p
<gchristensen> commit statuse are the old ones before apps were a thing
<cole-h> So, keep borg in the committer team for the forseeable future, then?
<LnL> ok so triage or whatever it is isn't enough then?
orivej has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
<LnL> well, if we implement one of the commit/merge feature requests it won't be an inactive account next time :)
<cole-h> :P
hmpffff has joined #nixos-borg
<cole-h> I don't see that happening any time soon, tbh. The RFC was closed for inactivity, right?
<cole-h> Oh, not even that -- it was rejected
<cole-h> Wait, rejected, but "hope somebody can pick it up"...?
orivej_ has joined #nixos-borg
orivej has quit [Ping timeout: 265 seconds]
<LnL> what do you mean?
<cole-h> "status: rejected", yet "I hope somebody can pick this up eventually"
<LnL> ah, totally forgot about that
orivej_ has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg