<gchristensen>
so this is in the evaluation filter
<gchristensen>
how did it get to the evaluator too
<LnL>
oh
<LnL>
not sure, but it's all the same pr https://monitoring.nix.ci/explore?orgId=1&left=%5B%22now-1h%22,%22now%22,%22PromLoki%22,%7B%22expr%22:%22sum(count_over_time(%7Bunit%3D~%5C%22ofborg-.*.service%5C%22,level%3D%5C%22ERROR%5C%22%7D%5B1h%5D))%20by(pr)%22%7D,%7B%22mode%22:%22Metrics%22%7D,%7B%22ui%22:%5Btrue,true,true,%22none%22%5D%7D%5D
<gchristensen>
oh!
<gchristensen>
I found a bug LnL :)
<LnL>
did I mess something up?
<gchristensen>
let's see ...
<gchristensen>
I'm not sure
<LnL>
err never mind that link, it's too early in the consumer for that to work
<gchristensen>
I'm not sure if we'll be able to do any work without further deploys, let's see
<gchristensen>
I think all the queues are blocked
<gchristensen>
oh
<gchristensen>
no, this will make a difference
<gchristensen>
for sure
<LnL>
yeah maybe the filter is probably the one that handles unexpected stuff nicely
<gchristensen>
yeah
<gchristensen>
we'll see :P
<gchristensen>
LnL: you sure you can't add converted_to_draft ?
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
<LnL>
not right now :/
<gchristensen>
okay
orivej has quit [Ping timeout: 246 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 256 seconds]
orivej has joined #nixos-borg
orivej has quit [Quit: No Ping reply in 180 seconds.]
orivej has joined #nixos-borg
cole-h has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-borg
<cole-h>
<3 gchristensen <3 LnL
<{^_^}>
LnL's karma got increased to 57
<{^_^}>
gchristensen was put on Santa's "nice" list
<gchristensen>
hehe
<cole-h>
So, what was the actual fallout of-- Oh, the queue jumping up to ~113 queued. Woof :D
<gchristensen>
every github event went right to the evaluators
<cole-h>
That eval error graph... x(
<gchristensen>
yeah :)
<gchristensen>
the evaluators don't use the same message format that github sends, so 100% of those were errors :)
<cole-h>
RIP.
<LnL>
yeah, I made a boo-boo
<gchristensen>
no worries :)
<cole-h>
Yeah, jeez LnL, just be perfect 100% of the time like the rest of us >:(
<cole-h>
(obvious /s, hopefully)
orivej has quit [Ping timeout: 240 seconds]
orivej_ has joined #nixos-borg
<LnL>
lol, developerexcuses.com just gave me this:
<LnL>
> I thought you signed off on that?
<{^_^}>
error: syntax error, unexpected ')', expecting ID or OR_KW or DOLLAR_CURLY or '"', at (string):313:1
<gchristensen>
lol
<cole-h>
Oh no
<cole-h>
Right back at me haha
<cole-h>
"It works, but it's not been tested"
<cole-h>
Oh cool, GH breaking the API again -- `thread 'main' panicked at 'Failed to add labels ["ofborg-internal-error"] to issue #88588: Error(Codec(Error("invalid type: map, expected a sequence", line: 1, column: 1))`
<gchristensen>
what.
<cole-h>
My thoughts exactly
<LnL>
ok so, is that enum still relevant?
<cole-h>
Which enum?
<LnL>
the github event
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
<{^_^}>
[ofborg] @LnL7 opened pull request #495 → convert log-message-collector to easylapin → https://git.io/Jf2SK
orivej has quit [Quit: No Ping reply in 180 seconds.]
<LnL>
only generating the config instead of the name/value would be a bit more flexible but I don't think we need that
<cole-h>
How do you mean?
<LnL>
packet-spot-eval-foo = mkEvaluator "foo"
<cole-h>
Oh, we can do that too.
<LnL>
as for range
<LnL>
> lib.range 0 3
<{^_^}>
[ <CODE> <CODE> <CODE> <CODE> ]
<cole-h>
Yeah, but then we have to get `lib` in there
<cole-h>
I just lifted the definition from `lists.nix` anyways
<LnL>
hmm, isn't this a module?
<cole-h>
LnL: Wait, what's the point of the argument to `mkEvaluator`? My function only uses the argument for the name, which would already be `packet-spot-eval-foo` because.. that's what you typed
<cole-h>
So it would really be `packet-spot-eval-foo = mkEvaluator;`
<LnL>
ah it's not used anywhere else
<cole-h>
Nope.
<cole-h>
Your call: do we `listToAttrs`, or do we `packet-spot-eval-1 = mkEvaluator; packet-spot-eval-2 = mkEvaluatur; ...`
<LnL>
range is fine, don't think we need to mess with individual machines
<cole-h>
gchristensen: We're all caught up to the queue. Time to drop the 3 new machines?
<gchristensen>
eh, let 'em go :P
<cole-h>
I only ask because I was gonna PR the generalization of the `mkEvaluator` stuff
<cole-h>
So I could change it to `numMachines 3` instead of `numMachines 6`