gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
andi- has quit [Ping timeout: 272 seconds]
andi- has joined #nixos-borg
andi- has quit [Ping timeout: 265 seconds]
andi- has joined #nixos-borg
cole-h has quit [Quit: Goodbye]
<{^_^}> #84555 (by jtojnar, 43 minutes ago, open): dia: 2017-06-22 → 2020-04-07
thefloweringash has quit [Ping timeout: 246 seconds]
thefloweringash has joined #nixos-borg
<gchristensen> thanks jtojnar
<{^_^}> [ofborg] @grahamc pushed 2 commits to retryon-bad-creds: https://git.io/JvAo0
<{^_^}> [ofborg] @grahamc opened pull request #456 → Retry on bad creds → https://git.io/JvAoE
<gchristensen> gonna do the dumb and easy thing and just retry :P
orivej has quit [Ping timeout: 256 seconds]
<{^_^}> [ofborg] @grahamc merged pull request #456 → Retry on bad creds → https://git.io/JvAoE
<{^_^}> [ofborg] @grahamc pushed 3 commits to released: https://git.io/JvAo9
<{^_^}> [ofborg] @grahamc pushed 0 commits to retryon-bad-creds: https://git.io/JvA6B
<andi-> I think one of the mac builders might habe died. I got a stuck build here: https://github.com/NixOS/nixpkgs/pull/84584/checks?check_run_id=567386729
<andi-> https://logs.nix.ci/?attempt_id=701311bb-3945-40bc-854e-5af00532b8db&key=nixos%2Fnixpkgs.84584 this seems to be the log output. It is missing the final store path line
cole-h has joined #nixos-borg
orivej has joined #nixos-borg
<gchristensen> cole-h: want an easy one? :)
<cole-h> 🎵 Hit me baby one more time 🎵
<gchristensen> WARN:ofborg::tasks::eval::nixpkgs: Failure requesting a review from drewrisinger: Error(Fault { code: UnprocessableEntity, error: ClientError { message: "Review cannot be requested from pull request author.", errors: None } }, State { next_error: None, backtrace: Some(stack backtrace:
<gchristensen> stop asking the author of the PR to review it
<cole-h> Is the `owner` field of the PullRequest struct "NixOS" in our case, or is it the owner of the PR's repo?
<gchristensen> hm
<gchristensen> not sure
<cole-h> `PullRequest` has a `get` method that returns a struct with a `user` field, which has a `login` field. Seems to be the way to go.
<gchristensen> probably so
<cole-h> Want it logged, or silently skipped?
<gchristensen> silently skipped
<gchristensen> you should probably compare by lowercasing both sides
<cole-h> Thanks for the reminder
<MichaelRaskin> Please don't tell me githubId of the user is not passed to the event
<MichaelRaskin> And yeah, release branches
<gchristensen> ofborg doesn't know about github IDs yet :x
<{^_^}> [ofborg] @cole-h opened pull request #457 → More logging → https://git.io/JvApz
<cole-h> Just to clarify my intent: I'll work with `slog` only after the basics are implemented in ofborg
<gchristensen> oh!
<gchristensen> so like, if I do some initial hooking up, you'll work from there?
<cole-h> Absolutely. Or at least I'll do some struggling from there
<cole-h> :P
<gchristensen> cool
<gchristensen> that is totally fair.
<gchristensen> slog isn't much fun to do initial set-up for
tilpner has quit [Remote host closed the connection]
<cole-h> The real reason is that: I've never used slog (or structured logging in general)
<cole-h> So I need some groundwork to see the direction I should head in, etc
tilpner has joined #nixos-borg
<gchristensen> cool
<{^_^}> [ofborg] @grahamc merged pull request #457 → More logging → https://git.io/JvApz
<{^_^}> [ofborg] @grahamc pushed 3 commits to released: https://git.io/JvAhZ
* gchristensen should probably give cole-h the ability to deploy ofborg
<cole-h> You heard it here first, folks: all you need to do is contribute a bare minimum +775,-750 LOC to ofborg and you, too, can get deploy access!
<cole-h> :P
<cole-h> In all seriousness, I wouldn't decline, but I don't see a point, considering you have to merge anyways :P
<gchristensen> fair
<MichaelRaskin> Well, if you give both deploy _and_ rollback rights…
<MichaelRaskin> I think there have been some cases where you merged quickly then said that you will deploy when you have time to watch how the deploy goes
<gchristensen> yeah
<gchristensen> after retrying on a bad creds, haven't seen any more internal error labels
<cole-h> Knock on wood
<cole-h> You shoulda just left it
<gchristensen> hehe
<cole-h> inb4 it happens again with the RFC45 PR
<gchristensen> hehe yeah