<cole-h>
(and maybe tagged security since it addresses CVEs)
<cole-h>
(while you're there)
<cole-h>
Just made a regex that searches the logs for added "ofborg-internal-error" labels (+) and disregards lines that already have it (=), for my fellow log gremlins
<cole-h>
gchristensen: While I have your attention, could I point you to https://www.youtube.com/watch?v=GdgX46KwKqo ? It describes how to add a PromQL-queryable Loki data source so I can add alerts for the above regex 👀
<gchristensen>
oh so yeah I watched that, but I already did it -- that is why loki logs are searchable in the first place
<gchristensen>
I'm not sure what is missing for the next bit. I'll make you an admin, so you can debu
<gchristensen>
you're an admin
<cole-h>
Thanks, I'll take a look
<gchristensen>
thanks
<cole-h>
Ah, it seems the missing link is that you added the actual Loki data source, not a Prometheus data source /pointing/ to Loki
<cole-h>
Added Prometheus data source -> URL set to `<loki URL>/loki` -> all good
<cole-h>
Now to figure out the alerts part
<gchristensen>
nice :D
<cole-h>
What "type" of channel should the alerts go to? Telegram, Discord, Pushover, email are a few of the options (the rest I don't think I have access to or have never heard of)
<LnL>
gchristensen: if you have time could you give me a quick rundown of the rabbitmq setup?
<LnL>
mainly thinking about ack/requeue type stuff
<gchristensen>
sure
<gchristensen>
for things I definitely want to make sure are completed, I make sure auto-ack = false, and then wait until the job is completed successfully before sending the ack
<gchristensen>
if it panicks or sends a nack, it'll retry pretty much immediately
<LnL>
where is that configured?
<gchristensen>
ah in the bin
<gchristensen>
look at like bin/builder.rs
<LnL>
oh, that's all in the client?
<gchristensen>
yeah
<gchristensen>
the clients define all the queues / bindings / exchanges
<LnL>
ah so there's nothing to configure on the rabbitmq side except for users
<gchristensen>
yep :)
<LnL>
and what about the library, I see heartbeats are not supported compared to eg. lapin
<gchristensen>
badly, lol.
<gchristensen>
LnL: want to integrate lapin?
<gchristensen>
I'm ready to adopt our async overlords I guess
<LnL>
well I'd like to rather decouple stuff a bit more instead of just hacking this in
<gchristensen>
sounds good
<LnL>
so if you where thinking of going that direction, might be a good way to try it out?
<gchristensen>
I think ofborg would benefit from async in a lot of ways
<gchristensen>
and the currenty hacked-in heartbeat support is terrible
<gchristensen>
in general, ofborg's code is not great, and moving in a fresh direction would be good
<LnL>
oh btw did we figure out what was wrong with the NIX_PATH thing?
<gchristensen>
(on the phone)
orivej has quit [Ping timeout: 265 seconds]
WilliButz has quit [Remote host closed the connection]