<cole-h>
gchristensen: A couple questions: Is there a simple way to test ofborg in order to ensure my changes didn't break anything?
<gchristensen>
cargo check, cargo test :)
<gchristensen>
that is as good as you're getting right now
<cole-h>
:P
<cole-h>
Second question: would you accept a (new) PR updating ofborg to Rust 2018 edition? #417 is a little old, and there are a few papercuts that I run into when 2018<->pre-2018
<cole-h>
Fantastic, I think that'll be my first job then (after I tweak wording on this tracking issue before filing)
<gchristensen>
I'm sad I didn't merge that one :/
<cole-h>
Life happens S:P
<cole-h>
s/S:P/:P
<cole-h>
`edition = "2018"` -> aborting due to 299 previous errors
<cole-h>
Nice
<cole-h>
LnL++ Thanks for doing the legwork on that 2018 PR -- all I really had to do was fix a couple conflicts. Working on making it more idiomatic now (e.g. removing extern crates where possible)
<gchristensen>
fwiw I really prefer the enum and impl From method of handling errors
<cole-h>
Comment on issue pls :^)
<cole-h>
I agree, but it would just make one-offs (like what I see expect used for) easier
<cole-h>
gchristensen: Am I being too opinionated if I merge imports e.g. `use std::io::BufRead; use std::io::BufReader; use std::io::...` into `use std::io::{BufRead, BufReader, ...}`? I personally think it's nicer, but...
<gchristensen>
do your thing
<cole-h>
❤️
<gchristensen>
:)
<gchristensen>
cole-h: btw I'm excited to have you doing these improvements. the reason I ask for them to be very easy to review is so I have no hesitation to smash the merge button and deploy to prod
<cole-h>
:-)
<gchristensen>
it is pretty hard for me to fit all the things in to a day, so if they're very fast reviews -- much more likely to get merged ... even though it feels bad to say that :(
<cole-h>
Happy to help. Just the past few months seeing how much you do for NixOS in general, I can understand that some things get left on the backburner
<gchristensen>
<3 thank you
<cole-h>
I will disclaim: I'm not *that* experienced with Rust, so some of the more involved changes won't be so simple to review... my recent PRs for zoxide have averaged 24 comments...
<gchristensen>
well, maybe try to avoid those to start with if you can :)
<cole-h>
:P
<cole-h>
Just working on minor formatting + rust 2018 for today. Then I'll read through and take notes on the `Result<..., String>` stuff after I'm done and actually get to work on it tomorrow-ish
<nix-build>
[ofborg] @grahamc pushed 5 commits to released: https://git.io/Jvd3r
<gchristensen>
LnL: ping? I have a question about vault
<LnL>
pong
<gchristensen>
I have this file, local.nix, which contains a bunch of passwords and tokens and IDs and stuff
<gchristensen>
I need it for deploying ofborg. would you store each of those thing separately in Vault, or as like a literal text document that is fetched all in one go?
<gchristensen>
LnL: ^
<LnL>
hrm my messages didn't get through
<gchristensen>
ah, interesting
<LnL>
dunno why, but my client seems to disconnect weirdly sometimes
<LnL>
guess that depends on what the secrets are
<LnL>
if you don't want to rotate them separately or segregate access it seems fine to keep them together
<LnL>
and those probably imply that those secrets should be retrieved at runtime instead of during the deploy
<gchristensen>
yes proably
<gchristensen>
incremental progress though :P
<gchristensen>
making them no longer checked in to my repo as a git-crypt file -> vault to any degree is probably a big improvement
<gchristensen>
let me paste the file, stripped of the tokens
<LnL>
yeah, it's a good first step
* LnL
should look into the vault client sometime
<LnL>
last time I played with it I couldn't get it to refresh changes
<LnL>
not we just need a vault agent that uses nix expressions instead of hcl
<gchristensen>
hehehe
<gchristensen>
I have been playing with a semi-declarative vault config
<gchristensen>
it is good enough to play with but not good enough to put in to nixos
orivej has joined #nixos-borg
cole-h has joined #nixos-borg
<cole-h>
gchristensen: Might want to close ofborg#417 as well (probably should have changed the wording in my PR to make GH do that automatically...) ;^)