<
gchristensen>
I keep having to patch it and then there is some undetermined amout of time until they merge
<
gchristensen>
thanks, cole-h
<
cole-h>
Thanks for the padded GH stats :P
<
cole-h>
With my current experience, I'd hazard a guess that something else is cleaning up that file before ofborg can.
<
gchristensen>
seems weird but yeah
<
gchristensen>
what if we just ignore that particular error?
<
gchristensen>
or maybe there is a more insidious problem at hand
<
cole-h>
I'd do research into a "more insidious problem", but it might not hurt to ignore -- or at least not error (maybe just `println!`/`warn!`?)
<
cole-h>
Any chance that nix itself is cleaning it up for some reason?
<
gchristensen>
not likely
<
gchristensen>
oh wait actually lol
<
gchristensen>
the file won't get created if nix errors
<
gchristensen>
so ignoring it on failure is totally reasonable
<
cole-h>
And "if nix errors" -> eval fails?
<
cole-h>
Then yeah, I'd say totally valid to ignore (I personally would still log it though, to be safe)
<
gchristensen>
yeah
<
gchristensen>
want to PR that? :)
<
cole-h>
Do you want a println log, or a macro from the log crate?
<
gchristensen>
macro please
<
gchristensen>
that'll make it easier later presumabl ywhen we switch to slog
<
gchristensen>
the println's were from ... oof. long time ago.
<
cole-h>
We all gotta start somewhere
<
gchristensen>
yup.
<
gchristensen>
I am glad you're doing these things. I feel very tired today
<
cole-h>
Happy to help. Gives me something to do other than just sit here and wait for classes to resume in a few days
<
gchristensen>
thank you
<
cole-h>
Should I keep remove_nix returning a Result, or should I just `warn!` if any `fs::remove_file` fails?
<
gchristensen>
keep returning a Result, but just ignore if the stats one fails
<
gchristensen>
the other one should definitely not fail ever
<
cole-h>
Thanks for the sanity check.
<
cole-h>
gchristensen: Do you think it's safe to tag ofborg#446 as being closed by this?
<
gchristensen>
yeah
<
gchristensen>
hope so :P
<
cole-h>
Gonna sneak in a "remove single quotes" commit as well, since the debug representation of a PathBuf already provides double quotes
<
gchristensen>
woot :)
<
cole-h>
I wonder if File does though...
<
gchristensen>
oh that one
<
gchristensen>
not useful output
<
gchristensen>
Apr 02 21:04:02 packet-spot-eval-2 jcvi5n0sgq1bjfvyzp0j7g6zs4fcggrc-unit-script-ofborg-evaluator-start[1999]: Ok(File { fd: 5, path: "/tmp/#25715897 (deleted)", re
<
gchristensen>
ad: true, write: true })
<
gchristensen>
Apr 02 21:04:02 packet-spot-eval-2 jcvi5n0sgq1bjfvyzp0j7g6zs4fcggrc-unit-script-ofborg-evaluator-start[1999]: Ok(File { fd: 5, path: "/tmp/#25715897 (deleted)", re
<
gchristensen>
ad: true, write: true })
<
cole-h>
I could drop the actual File in another commit then
<
{^_^}>
[ofborg] @cole-h opened pull request #449 → nixenv: warn when removing the stats file fails →
https://git.io/JvblY
<
cole-h>
CI looking 💵
<
{^_^}>
[ofborg] @grahamc merged pull request #449 → nixenv: warn when removing the stats file fails →
https://git.io/JvblY
<
gchristensen>
deployed!
<
gchristensen>
ofborg is usually so happy and healthy, and has had a few real sick days
<
cole-h>
Haven't we all
<
gchristensen>
oof isn't that the truth
<
cole-h>
Do you want to restart the eval on nixpkgs#84214, or can I?
<
cole-h>
(Or will it auto-restart?)
<
gchristensen>
go for it :)
<
cole-h>
That was fast
<
cole-h>
I saw the checks restart the second I posted :O
<
gchristensen>
that's the good stuff :)
<
cole-h>
Just seeing all these yellow dots on the PRs page has me anxious
<
gchristensen>
yeaaaah
<
cole-h>
Our poor single darwin machine being used and abused
<
gchristensen>
yeaaah...
<
gchristensen>
darwin :(
<
gchristensen>
woooooo!!!
<
gchristensen>
cole-h++
<
{^_^}>
cole-h's karma got increased to 13
<
gchristensen>
cole-h++
<
{^_^}>
cole-h's karma got increased to 14
<
gchristensen>
cole-h++
<
{^_^}>
cole-h's karma got increased to 15
<
cole-h>
Be careful, I might get to the point where you owe me a sticker >:)
<
gchristensen>
already do tbh
<
cole-h>
Woot, our `Option`al PRs merged
cole-h has quit [Quit: Goodbye]
orivej has quit [Ping timeout: 260 seconds]
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
<
LnL>
in the meantime the builds caught up :)
tilpner_ has joined #nixos-borg
tilpner has quit [Ping timeout: 256 seconds]
tilpner_ is now known as tilpner
hmpffff has joined #nixos-borg
<
gchristensen>
<3 thank you LnL!
hmpffff has quit [Read error: Connection reset by peer]
hmpffff has joined #nixos-borg
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
cole-h has joined #nixos-borg
<
{^_^}>
#84136 (by Izorkin, 1 day ago, open): nixos/tests: add check mariadb galera cluster
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
hmpffff__ has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 256 seconds]
hmpffff has joined #nixos-borg
hmpffff__ has quit [Ping timeout: 272 seconds]
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
infinisil has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
infinisil has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 272 seconds]
hmpffff has quit [Quit: nchrrrr…]