gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
<{^_^}> [ofborg] @cole-h opened pull request #458 → {checkout,clone}: redirect output to /dev/null → https://git.io/JvxxJ
cole-h has quit [Quit: Goodbye]
cole-h has joined #nixos-borg
<cole-h> gchristensen: in ~3 hours I'll explain each case where redirecting stderr silences git reporting "as normal but not an error" (lecture in the meantime) and we can go from there :)
<cole-h> I ran all of the commands I changed with only stdout pointing to `Stdio::null()` and recorded the results in comments below the function
<gchristensen> cool
<gchristensen> let's keep stderr output for all of them, for now
<cole-h> Roger.
<cole-h> Can I remove stderr for the `git am --abort` stuff, considering they should always fail (and print to stderr)? Or keep it as well
<cole-h> `git am --abort` and `git merge --abort`, specifically
<gchristensen> sure
<cole-h> (also, don't merge immediately; I'm going to sneak a commit that changes the `issue.id` to `issue.number` so we can actually see what PR is being operated on, instead of numbers in the 100s of millions)
<cole-h> (please)
<gchristensen> cool :D
<cole-h> I'll push after you re-review, in case I need to make more changes (save CI from itself) ;^)
<gchristensen> lgtm cole-h
<cole-h> Cool with stdout + stderr -> /dev/null on merge and am aborts?
<gchristensen> yep
<{^_^}> [ofborg] @grahamc pushed 3 commits to released: https://git.io/Jvp2O
<{^_^}> [ofborg] @grahamc merged pull request #458 → {checkout,clone}: redirect output to /dev/null → https://git.io/JvxxJ
<cole-h> Looking at the ofborg commit log is kinda funny. "Merge pull request #.... from cole-h/logging" <cole-h commits>, "Merge pull request #.... from cole-h/logging" <more cole-h commits>
<gchristensen> hehe
<gchristensen> okay issueing the deploy
<cole-h> 🎉
<gchristensen> how are the logs looking?
<cole-h> Much quieter
<gchristensen> nice
<cole-h> 🎉🎉🎉
<gchristensen> nice hehe
* cole-h makes a note to remove single quotes in next PR..... again...
<cole-h> I should probably look at debug representations before blindly single-quoting them lol
<cole-h> INFO:ofborg::checkout: Merging commit '"3e493f634dea66f41543ade2dbfbf1f350084805"'
<gchristensen> :)