gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 260 seconds]
orivej_ has joined #nixos-borg
orivej_ has quit [Ping timeout: 265 seconds]
orivej has joined #nixos-borg
orivej has quit [Read error: Connection reset by peer]
orivej has joined #nixos-borg
andi- has quit [Ping timeout: 256 seconds]
andi- has joined #nixos-borg
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 246 seconds]
cole-h has quit [Ping timeout: 256 seconds]
hmpffff_ has joined #nixos-borg
hmpffff has quit [Ping timeout: 272 seconds]
orivej has quit [Ping timeout: 240 seconds]
hmpffff has joined #nixos-borg
hmpffff_ has quit [Ping timeout: 240 seconds]
hmpffff has quit [Remote host closed the connection]
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
ekleog has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
orivej has joined #nixos-borg
cole-h has joined #nixos-borg
<{^_^}> [ofborg] @cole-h opened pull request #447 → nixenv: describe what went wrong when io fails → https://git.io/JvbtE
<cole-h> gchristensen: ^ Travis is happy. Got a sec to make sure you're happy with the diff, too?
<gchristensen> nice
<gchristensen> ah cool, minor nits
<gchristensen> commented
<cole-h> Cool, on it. I just like `match`es because the other languages I "know" don't have them :P
<cole-h> Do you squash, or should I force-push?
<gchristensen> totally up to you
<LnL> hmm, isn't ofborg supposed to be cached (ish)?
<gchristensen> should be..
<LnL> re errors, I think .map_err()? is a pretty common pattern
<cole-h> Yep, it is. But me, in my inexperience, always reach for `match` first.
<gchristensen> I also very much like matches :)
<LnL> yeah, but in this case the map allows you to use ? which is nice
<gchristensen> yep
<cole-h> yep
<cole-h> (where's that triple combo at?)
<LnL> I think I've also seen this in combination with the Into trait to move the conversion logic
<LnL> urgh #83488
<{^_^}> https://github.com/NixOS/nixpkgs/pull/83488 (by kolloch, 1 week ago, merged): buildRustCrate: Add "-r" to cp to make it work under Mac OS
<cole-h> urgh good or urgh bad?
<LnL> gchristensen: do you have a store path / commit that's recent enough?
<LnL> n/m found one
<gchristensen> great :) I was just looking at hydra
<{^_^}> [ofborg] @grahamc merged pull request #447 → nixenv: describe what went wrong when io fails → https://git.io/JvbtE
<{^_^}> [ofborg] @grahamc pushed 3 commits to released: https://git.io/Jvbql
<gchristensen> nice!
hmpffff has joined #nixos-borg
hmpffff has quit [Read error: Connection reset by peer]
hmpffff has joined #nixos-borg
cransom has quit [Quit: WeeChat 2.6]
cransom has joined #nixos-borg
hmpffff has quit [Read error: Connection reset by peer]
hmpffff has joined #nixos-borg
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
hmpffff has joined #nixos-borg
hmpffff has quit [Client Quit]
<cole-h> gchristensen: When you say extend that PR to softprops, do you mean open another PR against them, or PR against master AND your `status-target-url-null` branch?
<cole-h> The one against your fork is here: https://github.com/grahamc/hubcaps/pull/6
<{^_^}> grahamc/hubcaps#6 (by cole-h, 3 minutes ago, open): Statuses.{created,updated}_at: optional
<gchristensen> another PR
<gchristensen> merged!
<cole-h> "How did you verify your change: Had @grahamc run it in prod" ^^
<{^_^}> softprops/hubcaps#250 (by cole-h, 7 seconds ago, open): Statuses.{created,updated}_at: optional
<gchristensen> :D
<gchristensen> cole-h: ping me when you have a PR to ofborg?
<cole-h> 👍
<{^_^}> [ofborg] @cole-h opened pull request #448 → Bump hubcaps → https://git.io/JvbWU
<cole-h> I forgot how to update a single dependency lol :D Note to self: `cargo update -p hubcaps` and THEN update carnix lol
<cole-h> Ping gchristensen
<cole-h> gchristensen: CI is green.
<gchristensen> woot, was eating some dinner
<{^_^}> [ofborg] @grahamc merged pull request #448 → Bump hubcaps → https://git.io/JvbWU
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/JvbW0
<cole-h> Fingers crossed it actually does what you want
<cole-h> :P
<cole-h> Just curious: is there a reason we don't use upstream hubcaps?