<elvishjerricco>
infinisil: Right, I'm asking if such a plugin can add a subcommand
<infinisil>
..Read the section
<samueldr>
-> RegisterCommand to add new subcommands
<samueldr>
I don't know if there are better docs since, probably the best way to understand it would be to read the source :/
<elvishjerricco>
infinisil: Oh, I missed that line, sorry. So the answer is "yes," but I'm trying to figure out how :P
<elvishjerricco>
I wanted to try just copying the `build` command's source, but `command.hh` isn't exported, since it's not part of libmain or anything
<infinisil>
It's not a new command, but at least an example of another plugin
<elvishjerricco>
Yea, I did steal his CMakeLists.txt file for the most part :P
<elvishjerricco>
`grep -r RegisterCommand $(nix-build --no-out-link "<nixpkgs>" -A nix.all)`
<elvishjerricco>
No header results :/
orivej has quit [Ping timeout: 246 seconds]
<elvishjerricco>
Yea, RegisterCommand is just defined in `src/nix`, not `src/libmain`
<elvishjerricco>
So there's not actually a supported way to do this...
<infinisil>
Huh
<infinisil>
:(
<elvishjerricco>
Maybe `command.hh/cc` could be moved to `libmain`?
<elvishjerricco>
Oh C++, how do I build you? :P Simply moving command.{hh,cc} to libmain didn't quite work.
shlevy has quit [*.net *.split]
<elvishjerricco>
Ended up needing to add `libexpr` to `libmain_LIBS`. But now I get `src/libexpr/libnixexpr.so: file not recognized: File truncated`
<elvishjerricco>
So I guess `libmain_LIBS` doesn't tell make to ensure libnixmain.so is built after libnixexpr.so
jtojnar has quit [Quit: jtojnar]
jtojnar has joined #nixos-dev
jtojnar has quit [Read error: Connection reset by peer]
lassulus_ has joined #nixos-dev
lassulus has quit [Ping timeout: 240 seconds]
lassulus_ is now known as lassulus
infinisil has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
infinisil has joined #nixos-dev
garbas has quit [Quit: WeeChat 2.1]
<elvishjerricco>
Alright, after reshuffling some code in nix, you can *build* `RegisterCommand`s, but you don't actually get to use them. `plugin-files` seems to be added *after* CLI parsing is through, which isn't terribly surprising.
jtojnar has joined #nixos-dev
Enzime has quit [*.net *.split]
goibhniu has quit [Ping timeout: 240 seconds]
goibhniu has joined #nixos-dev
Sigyn has quit [*.net *.split]
Sigyn has joined #nixos-dev
jtojnar has quit [Quit: jtojnar]
jtojnar has joined #nixos-dev
jtojnar has quit [Quit: jtojnar]
orivej has joined #nixos-dev
page has joined #nixos-dev
__Sander__ has joined #nixos-dev
orivej has quit [Ping timeout: 244 seconds]
obadz has quit [Quit: WeeChat 2.1]
obadz has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.2]
ma27 has joined #nixos-dev
Enzime has joined #nixos-dev
Profpatsch has quit [Ping timeout: 252 seconds]
jtojnar has joined #nixos-dev
jtojnar has quit [Ping timeout: 252 seconds]
jtojnar has joined #nixos-dev
goibhniu has quit [Ping timeout: 272 seconds]
goibhniu has joined #nixos-dev
aminechikhaoui has quit [Ping timeout: 272 seconds]
<{^_^}>
#46670 (by domenkozar, 16 seconds ago, open): nginx, postgresql: give corresponding groups permission to read
<domenkozar>
any objections on this one? :)
jtojnar has quit [Ping timeout: 252 seconds]
<makefu>
domenkozar: i always wondered why the permissions were so strict on these services in first place, i approve this change
jtojnar has joined #nixos-dev
<LnL>
I think the strictness is good, but it gets chown'ed as postgres:postgres in this case so the group is also pretty strict
jtojnar has quit [Ping timeout: 252 seconds]
jtojnar has joined #nixos-dev
<samueldr>
in most cases I'd ask: what would upstream do? but let's not forget that nixos too has some rules and common behaviours that should work the same across similar packages :/
jtojnar has quit [Ping timeout: 245 seconds]
<makefu>
samueldr: i am pretty sure these rules primarily come from people copy-pasting other modules. afair there are no such rules or behaviors written down somewhere. I'd love to be proven wrong :)
<samueldr>
yeah, I was talking about the ad-hoc informal rules :)
<samueldr>
e.g. if all others RDBMS (and non-R DBMS) do it one way, probably better to do the same
<samueldr>
(or propose it as a more global change)