<ekleog>
Hmm… is there an estimation of how much RAM nixpkgs-review needs for eval somewhere? IIRC it already has mechanisms to limit the runtime, but I'd be interested in a rough estimate of the amount of RAM required to successfully just run nixpkgs-review
<ekleog>
oh actually looks like it went down and I can now run it on my machine, so the answer to myself is 5G
<rmcgibbo[m]>
ekleog: It depends on whether you're reviewing a PR that OfBorg has evaluated the changed attrs of or not.
<rmcgibbo[m]>
If so, then you don't need much RAM since you don't need to `nix-env -qaP`. If `nixpkgs-review` needs to run `nix-env -qaP` itself to identify the changed attrs, then yeah... >4G
<ekleog>
rmcgibbo[m]: right, here I'm considering the point of view of someone running nixpkgs-review locally before submitting a PR (writing a tool for PR submission as promised in https://github.com/NixOS/nixpkgs/pull/117537 ; so I'm thinking of making the default for “do you want to run nixpkgs-review” be the one that's most likely to work if there's <5-6G of available memory)
tomberek has quit [Quit: Ping timeout (120 seconds)]
tomberek has joined #nixos-dev
orivej has joined #nixos-dev
cole-h has quit [Ping timeout: 240 seconds]
rajivr has quit [Quit: Connection closed for inactivity]
Baughn has quit [Read error: Connection reset by peer]
<rmcgibbo[m]>
supersandro2000: i've tried to limit the RAM for `nix-env -qaP` with some BOHEMGC_* env variables, and the result is usually just that nix crashes and cannot actually list all of the packages. Does the systemd slice trick actually help it complete the list w/o using lots of ram and w/o crashing?
Baughn has joined #nixos-dev
<supersandro2000>
rmcgibbo[m]: I am actually not sure if it works correctly
<supersandro2000>
or really hard limit the memory
<supersandro2000>
but my system did not freeze due to to high memory usage since I set it up so it must work somehow, right?