<supersandro2000>
I just converted the patchPhase to postPatch and did not touch the command
<sterni>
supersandro2000: you converted from doubel quotes to indented string at the same time which then backfired because of escaping, but yeah that kind of mistake happens easily with indented strings
<sterni>
turns out '' is not that uncommon to have in a source file
<sterni>
why is /rebase restricted to commiters only? can you break anything with that?!
<siraben>
and maybe if someone has a clever enough script to automatically add gcc → cc patches
* siraben
ponders turning nixpkgs into a graph database
<samueldr>
were all of those changes tested to compile and run?
<siraben>
samueldr: yes
<siraben>
i used nixpkgs-review and ran each binary
<siraben>
in the case of libraries there was nothing to run
<samueldr>
good, then carry on :)
<siraben>
Is there some baseline quality for adding packages to Nixpkgs? Some of these range of GNU projects to single-file C (possibly hobby) projects
<siraben>
compared to AUR for instance, no idea what their policy is regarding adding new packages
<cole-h>
What's our stance on packages that don't actually include a license file, but their "project" file (e.g. a python+poetry pyproject.toml) includes a license field? Are they still technically "unfree"?
<rmcgibbo[m]>
But I confess, I don't really understand what it was doing on 116089.
<supersandro2000>
rmcgibbo[m]: you know why haskell updates have its own branch?
<rmcgibbo[m]>
Not particular? Because Peti does them all at once from stackage?
<rmcgibbo[m]>
I can turn the bot off for base=haskell-updates, n.p.
<supersandro2000>
I think because they cause many rebuilds
<rmcgibbo[m]>
Right, i get that. I'm just saying that with the filtering based on time limit and not actually rebuilding every changed attr, it doesn't necessarily matter for r-rmcgibbo.
<rmcgibbo[m]>
But if it's causing problems for anyone, of course it's very easy to turn off.
fzakaria has quit [Killed (Sigyn (Spam is off topic on freenode.))]
fzakaria has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<sterni>
rmcgibbo[m]: haskell-updates make no sense to test because every PR there changes some overrides on packages that are marked as broken usually, so rebuilding wouldn't test them
<sterni>
rmcgibbo[m]: it's not really about the rebuilds but more about: haskellPackages on master is updated once per week and most failing if not all failing builds are marked as broken when that happens
<sterni>
rmcgibbo[m]: then we accumulate fixes on haskell-updates bump the set again merge etc.
<sterni>
rmcgibbo[m]: which is why you would have to test haskell-updates PRs with NIXPKGS_ALLOW_BROKEN=1 which would risk potentially wasting machine time
<sterni>
but building as it works currently is useless for most PRs to haskell-updates in the current form, so that machine time should probably be spent on other PRs
<sterni>
not sure if allowBroken could be a good idea