worldofpeace changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 20.09 Nightingale ✨ https://discourse.nixos.org/t/nixos-20-09-release/9668 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 20.09 RMs: worldofpeace, jonringer | https://logs.nix.samueldr.com/nixos-dev
<supersandro2000> sterni: oh...
<supersandro2000> I didn't even see that
<supersandro2000> I just converted the patchPhase to postPatch and did not touch the command
<sterni> supersandro2000: you converted from doubel quotes to indented string at the same time which then backfired because of escaping, but yeah that kind of mistake happens easily with indented strings
<sterni> turns out '' is not that uncommon to have in a source file
<sterni> why is /rebase restricted to commiters only? can you break anything with that?!
pmy has quit [Ping timeout: 260 seconds]
pmy has joined #nixos-dev
<rmcgibbo[m]> i feel like this is an exercise in masochism, but has anyone taken a stab at updating rustc to 1.50? (https://github.com/rust-lang/rust/releases/tag/1.50.0)...
rj has quit [Ping timeout: 268 seconds]
<supersandro2000> sterni: IIRC the action run gets permission from the runner
<supersandro2000> *commenter
<sterni> supersandro2000: it could bypass that it just checks using scherermichael-oss/action-has-permission
rj has joined #nixos-dev
<supersandro2000> 🤔
<supersandro2000> well if the action closes the PR and you do not have permission to reopen it, it would be a bit unfortunate
<supersandro2000> Also if anyone could use it it could be easily abused to close a PR
bennofs__ has joined #nixos-dev
pmy has quit [Ping timeout: 246 seconds]
pmy has joined #nixos-dev
bennofs_ has quit [Ping timeout: 264 seconds]
<sterni> well you can always reopen your own PR…
<supersandro2000> yeah but if someone spammed it on someone elses PR?
<supersandro2000> Only guessing
rj has quit [Ping timeout: 268 seconds]
<sterni> you can also spam @ofborg eval to prevent the check from ever completing
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-dev
rajivr has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 268 seconds]
ScottHDev5 has quit [Ping timeout: 246 seconds]
<gchristensen> that would be annoying
ivan_ is now known as ivan
<hexa-> firefox 86.0 went into staging due to nss 16 days ago
<hexa-> it is now stuck in staging-next dependency failure hell
* hexa- sad
<hexa-> meanwhile 86.0.1 is out
ScottHDev5 has joined #nixos-dev
supersandro2000 has quit [Remote host closed the connection]
orivej has joined #nixos-dev
evils has quit [Ping timeout: 264 seconds]
pmy has quit [Ping timeout: 260 seconds]
pmy has joined #nixos-dev
<siraben> I reckon we'll be able to unbreak a lot of packages on darwin by just simply changing the meta.platforms: https://github.com/NixOS/nixpkgs/pull/115974/files
<siraben> and maybe if someone has a clever enough script to automatically add gcc → cc patches
* siraben ponders turning nixpkgs into a graph database
<samueldr> were all of those changes tested to compile and run?
<siraben> samueldr: yes
<siraben> i used nixpkgs-review and ran each binary
<siraben> in the case of libraries there was nothing to run
<samueldr> good, then carry on :)
<siraben> Is there some baseline quality for adding packages to Nixpkgs? Some of these range of GNU projects to single-file C (possibly hobby) projects
<siraben> compared to AUR for instance, no idea what their policy is regarding adding new packages
<cole-h> What's our stance on packages that don't actually include a license file, but their "project" file (e.g. a python+poetry pyproject.toml) includes a license field? Are they still technically "unfree"?
<cole-h> Implied tool is https://github.com/dmerejkowsky/dfmt/ -- no LICENSE file, but has a license declared in its pyproject.toml: https://github.com/dmerejkowsky/dfmt/blob/008cee7d4a0a2fca46b2a44ac176167792ae606b/pyproject.toml#L7
AlwaysLivid has joined #nixos-dev
supersandro2000 has joined #nixos-dev
jonringer has quit [Remote host closed the connection]
evanjs has quit [Read error: Connection reset by peer]
evanjs has joined #nixos-dev
cole-h has quit [Ping timeout: 245 seconds]
pmy has quit [Quit: WeeChat 3.1]
endocrimes has quit [Quit: running from the computers]
maxine has quit [Quit: Goodbye]
maxine has joined #nixos-dev
endocrimes has joined #nixos-dev
mmlb has quit [Ping timeout: 256 seconds]
mmlb has joined #nixos-dev
evils has joined #nixos-dev
orivej has quit [Ping timeout: 260 seconds]
mkaito has joined #nixos-dev
mkaito has joined #nixos-dev
jonringer has joined #nixos-dev
rj has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<supersandro2000> siraben: I did a thing for nixpkgs-review https://github.com/Mic92/nixpkgs-review/pull/183
<{^_^}> Mic92/nixpkgs-review#183 (by SuperSandro2000, 15 minutes ago, open): Allow to cross compile
<siraben> supersandro2000: nice!
<supersandro2000> I also fixed up https://github.com/Mic92/nixpkgs-review/pull/164
<{^_^}> Mic92/nixpkgs-review#164 (by B4dM4n, 6 weeks ago, open): Add --system argument
<supersandro2000> so it should now be possible to compile from and target to any target on a single machine
<supersandro2000> *any target
<supersandro2000> this would also allow me to use darwin remote builders easily from one machine and not requiring to switch tabs in tmux
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<siraben> coq-modules is very confusing
lopsided98 has quit [Quit: Disconnected]
lopsided98 has joined #nixos-dev
<siraben> I'm trying to package the four color theorem, let's see how it goes
<sterni> they have the coolest nix library in nixpkgs it seems
<siraben> sterni: which library?
<siraben> fancy
<siraben> yeah I figured, I couldn't find lib.switch anywhere
<siraben> Funny thing is buildPhase is literally proving Four Color theorem right now heh
cole-h has joined #nixos-dev
rajivr has quit [Quit: Connection closed for inactivity]
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
pbb has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
pbb has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
orivej has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
orivej has quit [Ping timeout: 276 seconds]
<sterni> rmcgibbo[m]: hmm this was built despite targeting haskell-updates? https://github.com/NixOS/nixpkgs/pull/116089#issuecomment-797711374
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<ryantm> cole-h: my impression is referencing the license somewhere is good enough
clever has quit [Ping timeout: 260 seconds]
clever has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
yegortimoshenko has joined #nixos-dev
<Ericson2314> does autopatchelf not find the more obscure things that come with gcc like libgomp?
zhaofeng has quit [Changing host]
zhaofeng has joined #nixos-dev
supersandro2000 has quit [Ping timeout: 245 seconds]
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
rj has quit [Remote host closed the connection]
rj has joined #nixos-dev
supersandro2000 has joined #nixos-dev
mkaito has quit [Quit: WeeChat 3.0.1]
mkaito has joined #nixos-dev
mkaito has joined #nixos-dev
mkaito has quit [Changing host]
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
cole-h has quit [Ping timeout: 245 seconds]
justan0theruser is now known as justanotheruser
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<rmcgibbo[m]> sterni: Yeah -- I rolled out a new feature where it's able to skip rebuilding all changed attrs, so now it can do non-master branches.
<rmcgibbo[m]> But I confess, I don't really understand what it was doing on 116089.
<supersandro2000> rmcgibbo[m]: you know why haskell updates have its own branch?
<rmcgibbo[m]> Not particular? Because Peti does them all at once from stackage?
<rmcgibbo[m]> I can turn the bot off for base=haskell-updates, n.p.
<supersandro2000> I think because they cause many rebuilds
<rmcgibbo[m]> Right, i get that. I'm just saying that with the filtering based on time limit and not actually rebuilding every changed attr, it doesn't necessarily matter for r-rmcgibbo.
<rmcgibbo[m]> But if it's causing problems for anyone, of course it's very easy to turn off.
fzakaria has quit [Killed (Sigyn (Spam is off topic on freenode.))]
fzakaria has joined #nixos-dev
rj has quit [Ping timeout: 268 seconds]
rj has joined #nixos-dev
<sterni> rmcgibbo[m]: haskell-updates make no sense to test because every PR there changes some overrides on packages that are marked as broken usually, so rebuilding wouldn't test them
<sterni> rmcgibbo[m]: it's not really about the rebuilds but more about: haskellPackages on master is updated once per week and most failing if not all failing builds are marked as broken when that happens
<sterni> rmcgibbo[m]: then we accumulate fixes on haskell-updates bump the set again merge etc.
<sterni> rmcgibbo[m]: which is why you would have to test haskell-updates PRs with NIXPKGS_ALLOW_BROKEN=1 which would risk potentially wasting machine time
<sterni> but building as it works currently is useless for most PRs to haskell-updates in the current form, so that machine time should probably be spent on other PRs
<sterni> not sure if allowBroken could be a good idea