<sterni>
gchristensen: are the hydra reviewers running out? :)
<gchristensen>
we've never had good review coverage of hydra since I've been around
<ajs124>
I've heard Mic92 knows some perl
NinjaTrappeur has quit [Quit: WeeChat 3.0.1]
NinjaTrappeur has joined #nixos-dev
<gchristensen>
I'm not sure if anyone else uses this feature, but I hope not b/c this breaks them
<gchristensen>
it is also a pretty strange feature
<ajs124>
I'm not sure I even understand which feature that is
<ajs124>
Or if I've ever heard of it
<ajs124>
Somebody should really write down what hydra can do, because it seems like nobody remembers all the features.
<gchristensen>
so many organic features and misfeatures
<gchristensen>
yeah, so it returns a channel of binary-only faked derivations where each build output is from the last evaluation atwhich it built
<ajs124>
is that what that channels tab is for?
<ajs124>
I never figured out how to use that
<gchristensen>
I think so?
<gchristensen>
it is kind of cool because it gives a bit of a firewall between usable software you need and the day to day breakages
<gchristensen>
it is kind of weird because it is incredibly impure and not reproducible
<adisbladis>
cc stigo
<adisbladis>
re perl :)
<ajs124>
gchristensen: yeah. also, why not just have an aggregate jobset which only has the software you need as the constituents? I think. I'm not sure I ever figured out that feature, either.
<stigo>
adisbladis: yo
<ajs124>
and then runCommand? or something? seems potentially redundant
<stigo>
gchristensen: any perl issue?
<gchristensen>
stigo: want to review a PR? :) mount -o remount,noexec,nosuid,nodev /tmp
<{^_^}>
hydra#893 (by grahamc, 1 hour ago, open): Test the fake derivations channel, asserting nested packages are properly represented.
<stigo>
sure
<gchristensen>
cool!
<gchristensen>
starting by writing tests has been a game changer for perl. getting all the list/scalar context problems out of the way in tests makes it so much easier
<Mic92>
gchristensen: I guess you can ping people that have touched perl-packages in nix.
<Mic92>
*perl-packages.nix
<gchristensen>
yeah true
<gchristensen>
I actually got a second perl person to take a look, and got a thumbsup over IRC
<pie_>
could we tag update PRs with something? or is there some other way I can filter these "->" PRs on github?
<sterni>
theoretically we have 8. has package (update) I think
<sterni>
but ofborg doesn't always tag them correctly
<sterni>
at least ime
devhell has quit [Quit: leaving]
<stigo>
gchristensen: diff looks good, just nitpicking at this point
<stigo>
TIL that Test2's is() can compare datastructures out of the box, nice.
<gchristensen>
yeah, pretty nicte
<gchristensen>
thanks for such a close review!
<stigo>
:)
<adisbladis>
stigo++
<{^_^}>
stigo's karma got increased to 8
arianvp has quit [Quit: WeeChat 2.9]
arianvp has joined #nixos-dev
<sterni>
if hydraPlatforms = [] for a package, hydra will also cease building the reverse dependencies of said package, right?
<andi->
maralorn: not sure if that is a statement you can use as such. It depends on the users environment. For things that aren't custom to my system (unlike systemd units) there is likely no point in not just downloading it from the binary cache.
<maralorn>
So does preferLocalBuild prevent using substitution?
<andi->
also "just building locally" means you need the dependencies for that.
<maralorn>
Or does it prevent hydra from building the derivation?
rajivr has quit [Quit: Connection closed for inactivity]
<andi->
maralorn: none of that matter for the sake of my argument in that PR. If he doesn't have a valid reason to put it there then we shouldn't. The question of it's impact has been discussed here: https://discourse.nixos.org/t/meaning-of-preferlocalbuild/6047
<maralorn>
andi-: I asked specifically because I am uncertain about the arguments in question and would like to understand. I asked what would count as a good reason to use preferLocalBuild so I can compare if the reason in this case is strong enough.
<maralorn>
andi-: The reason in this case would be a potential speed-up. It might not be a strong reason but it is one.
<andi->
Speedup for whom?
<andi->
The average user or the 1%?
<maralorn>
andi-: The average user wont be affected. The average user will just get the result substituted from hydra.
<andi->
maralorn: the issue I always have with preferLocalBuild is that there is no opt-out for that feature on the CLI
<{^_^}>
nix#4442 (by domenkozar, 9 weeks ago, open): allowSubstitutes/preferLocalBuild are an anti-feature
<gchristensen>
I think -j0 works now andi-
<domenkozar[m]>
-j0 has been fixed, but newcomers are still getting stuck
<maralorn>
andi-: The concerns in that thread all primarily complain about allowSubstitutes, but that’s a mostly orthogonal feature (which would be a really bad choice in that situation).
<maralorn>
That’s also about allowSubstitutes, right?
<maralorn>
preferLocalBuild = true does not imply allowSubstitutes = false, right?
<maralorn>
Don‘t get me wrong, I am not a strong proponent for preferLocalbuild, but I really don‘t understand the problem.
<andi->
gchristensen: on 2.3.10?
ris has joined #nixos-dev
<samueldr>
preferLocalBuild could have been named "this is specific only for the local machine" AFAIUI
<domenkozar[m]>
maralorn: I don't know :)
Ox4A6F has quit [Quit: authenticating]
Ox4A6F has joined #nixos-dev
<maralorn>
samueldr: That definition (which is fine for me) does not fit the minecraft example in the discord that andi- linked to.
<maralorn>
Actually the manual sounds a bit like it preferLocalBuild implies allowSubstitutes = false. Because it says "... appropriate for ... cost of doing a download OR ... would exceed the cost of building locally."
<samueldr>
I'm not sure that the minecraft example was linked to as a good example, but I'm not sure
<samueldr>
ugh, I meant to start with "I don't think"
<maralorn>
Well my take away is, no one really knows what this feature exactly does and there is no community consensus on how it should be used.
<domenkozar[m]>
that's correct :)
appservicebot11 has joined #nixos-dev
piegames[m] has joined #nixos-dev
<samueldr>
I need a Nix/Nixpkgs/NixOS historian
<gchristensen>
if *you're* asking I'm not sure I can help
<jackgerrits>
Hi all, I apologize if this is the wrong way to go about this (please let me know to do it right in future) but I have a nixpkgs new package PR that has been approved and was wondering if someone can help with merging? https://github.com/NixOS/nixpkgs/pull/116645
<{^_^}>
#116645 (by jackgerrits, 1 day ago, open): vowpal-wabbit: init at 8.9.2