callahad has quit [Quit: Ping timeout (120 seconds)]
callahad has joined #nixos-dev
timokau[m] has joined #nixos-dev
psyanticy has quit [Quit: Connection closed for inactivity]
<globin>
niksnut: I'm playing around with __structuredAttrs and I think we might want to do a declare -x for all variables in .attrs.sh otherwise a lot has to be changed, that assumes, the variables are in the ENV
<globin>
also Ericson2314 ^
<Ericson2314>
globin: makes sense. OTOH making arrays arrays also changes things a lot
<globin>
Ericson2314: yes, but that's rather easy to fix, but the "not exporting" change breaks stuff like substituteAll that uses awk's ENVIRON or gcc not passing on NIX_DEBUG and not recognising CPATH etc.
<globin>
Ericson2314: most of the problems I'm having come from the export "change" which might have happened inadvertently
<Ericson2314>
globin: well keep in mind you can't really export an array
<Ericson2314>
it will just do the first entry or something
<globin>
ah yeah declare -ax doesn't export it at all
<globin>
but I guess that would be fine if we only declare -x for none array/assoc array
Synthetica has quit [Quit: Connection closed for inactivity]
noonien has quit [Quit: Connection closed for inactivity]
<niksnut>
globin: I don't know, it seems better not to pollute the environment too much
orivej has joined #nixos-dev
<Ericson2314>
globin: did it put `set -u` on that list?
<Ericson2314>
if we make sure to create variables for all things in the standard interface, we can remove a lot of `${foo+"${foo[@]}"}` type nonsense
<Ericson2314>
`set -u` everywhere would really tighten things up
Synthetica has joined #nixos-dev
delroth has joined #nixos-dev
jtojnar has quit [Remote host closed the connection]
jtojnar has joined #nixos-dev
matthewbauer has joined #nixos-dev
jtojnar has quit [Quit: jtojnar]
orivej has quit [Ping timeout: 252 seconds]
page has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-dev
justanotheruser has quit [Ping timeout: 245 seconds]