<ekleog>
Profpatsch: your link appears orthogonal to passthru.tests, do I read correctly? it's a way to force running tests, while passthru.tests is a way fora package to declare relevant tests
<Profpatsch>
ekleog: In that case I’d just add add the test as dependency, so bazel doesn’t build when the test derivation fails.
<Profpatsch>
That way you don’t need a separate “leaf” attribute that you need to call manually.
<ekleog>
ideally the file you linked would “default” to taking the tests from `drv.passthru.tests` (likely with another function name unless you want to play with __functor to make default arguments)
<Profpatsch>
gchristensen: What’s your take on teaching ofborg to build passthru.test (after sanity-checking the types)?
<gchristensen>
seems it should
<gchristensen>
but it is a bit complicated, because no smarts happen until it reaches a builder -- and then a builder can only do one build
<gchristensen>
it'd be good to change how ofborg's building is distributed for something like that (I've wanted to do this for some time now, anyway)
orivej has quit [Ping timeout: 268 seconds]
<ekleog>
wouldn't it work to just change nix-build'ing `foobar` into nix-build'ing `[ foobar ] ++ if foobar.passthru.tests or false then attrValues foobar.passthru.tests else []` ?
* ekleog
hasn't dived into ofborg's code for way too long, though, so…
<gchristensen>
maybe yeah
orivej has joined #nixos-dev
<Profpatsch>
It’s not foobar.passthru.tests, but foobar.tests.
<Profpatsch>
passthru is folded into the derivation attributes.
<{^_^}>
nixops#908 (by mickours, 43 weeks ago, open): Virtualbox deploy failed because of VirtualBox Guest Services failure
<yl[m]>
are we still using NixOS 16 for the base image for Virtualbox?
orivej has joined #nixos-dev
<timokau[m]>
Profpatsch: is there already a PR for withTests?
<timokau[m]>
I'd leave out `drvSeq` (or replace it with `drvSeqL`), seems redundant to me
MP2E has joined #nixos-dev
<MP2E>
Hey there, so Discord for Linux just had a new update, which means the old version we have packages in release-18.09 no longer works. Given that this is a simple version bump, should I backport to the release-18.09 branch or make a PR for it first?
<MP2E>
(just fixed it in master)
<gchristensen>
safest to PR it
<MP2E>
will do!
<andi->
Running the installer tests with the `driver` attribute is not supported? Fails to find nixpkgs it seems :/
<Profpatsch>
timokau[m]: lolnope.
<Profpatsch>
Maybe tomorrow.
<Profpatsch>
I’d not leave it out.
<Profpatsch>
Because it’s the true basic combinator. drvSeqL is just an optimization.
<timokau[m]>
Profpatsch: but its the other way around, `drvSeq` is implemented in terms of `drvSeqL`
<timokau[m]>
I don't see any issue in just adding braces around single items
<timokau[m]>
(I'm having the same pet-peeve with `lib.optional` vs `lib.optionals`)
<timokau[m]>
Profpatsch: please CC me if you do end up making a PR
<Profpatsch>
timokau[m]: It’s only the other way around because it’s more efficient.
<timokau[m]>
Profpatsch: Well its a nitpick. But what is the actual use-case to have the single-test version?
<Profpatsch>
I think we are talking in circles. :)
ma27 has quit [Quit: WeeChat 2.2]
ma27 has joined #nixos-dev
<timokau[m]>
That may be true :)
eadwu has joined #nixos-dev
<domenkozar>
error: syntax error, unexpected $end, at /nix/store/vhj9jx4hdd27arrcm4wz9zmysarl84cn-env-manifest.nix:1:1