#nixos-dev on 2019-01-04

2018-08-16 20:49 gchristensen changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | 18.09 release managers: vcunat and samueldr | https://logs.nix.samueldr.com/nixos-dev

00:05 drakonis has joined #nixos-dev

00:33 <gchristensen> I want to write this thing in Rust but carnix's expressions are so big, it would be like 50 lines of Rust and 5 billion lines of carnix.

00:37 orivej has quit [Ping timeout: 258 seconds]

00:52 eadwu has joined #nixos-dev

01:00 <delroth> hey, I just noticed that most changes to pkgs/os-specific/linux/kernel/* don't seem to go through pull requests like the rest, what gives?

01:00 <gchristensen> like version bumps?

01:00 <delroth> well, yes and no

01:00 <delroth> https://github.com/NixOS/nixpkgs/commit/92369900575c581ce9e9d70f23d39cf08943ad2f that's technically a version bump

01:00 <delroth> but it also disabled tons of security feature in hardened-config.nix

01:00 <delroth> with no context and no explanation

01:01 <gchristensen> gotcha

01:02 <samueldr> oof, I thought only the bumps were goint through like that

01:02 <delroth> I'm trying to re-enable them now (mostly GCC plugins support in the kernel), but it would have been nice to know why they were disabled in the first place...

01:02 <samueldr> delroth: which one were you looking at?

01:02 <gchristensen> NeQuissimus has long contributed kernel patches like this

01:03 <gchristensen> there didn't use to be much reason to send PRs (nothing was really tested)

01:03 <delroth> samueldr: well initially I wanted to enable CONFIG_GCC_PLUGIN_STACKLEAK (new in 4.20+)

01:03 <gchristensen> I'd suggest leaving a comment on that commit asking what is up. also, might ask if he'd be amenable to sending them as PRs instead

01:03 <delroth> since it's one of the highlights in https://outflux.net/blog/archives/2018/12/24/security-things-in-linux-v4-20/

01:04 <samueldr> hmm

01:04 <samueldr> the options that are now disabled are all not present anymore in the kernel

01:04 <delroth> they are

01:04 <gchristensen> that is what I expected to be at issue

01:04 <samueldr> at least, couple I looked at e.g. https://cateee.net/lkddb/web-lkddb/CC_STACKPROTECTOR_REGULAR.html

01:04 <delroth> GCC_PLUGINS is definitely there

01:04 <samueldr> https://cateee.net/lkddb/web-lkddb/GCC_PLUGINS.html

01:05 <samueldr> says 4.18 :/

01:05 <samueldr> delroth: I may be basing myself on wrong information though

01:06 <samueldr> oh, I think I see, off-by-one maybe?

01:09 <delroth> samueldr: https://github.com/NixOS/nixpkgs/compare/master...delroth:kernel-hardening seems to be building a 4.20 kernel fine.

01:10 <delroth> but maybe there's something I'm missing that warranted disabling...

01:12 <gchristensen> leave a coment on the commit asking what happened

01:12 <samueldr> delroth: I have had good luck pinging that maintainer in an issue to get questions like those answered

01:12 <samueldr> ^ or this

01:12 <delroth> yep, will do that

01:12 <gchristensen> either way, he's pretty responsive

01:14 <samueldr> I wonder why cateee.net doesn't see CONFIG_GCC_PLUGINS anymore; though for 4.18 it moved to a new location, it's still there in 4.20

01:19 pie__ has quit [Remote host closed the connection]

01:20 pie__ has joined #nixos-dev

01:23 eadwu has quit [Ping timeout: 258 seconds]

01:27 eadwu has joined #nixos-dev

01:31 Cale has quit [Remote host closed the connection]

01:34 orivej has joined #nixos-dev

01:46 orivej has quit [Ping timeout: 245 seconds]

01:52 drakonis has quit [Read error: Connection reset by peer]

01:53 drakonis has joined #nixos-dev

02:57 init_6 has joined #nixos-dev

03:14 jtojnar has quit [Quit: jtojnar]

03:27 hedning has joined #nixos-dev

03:29 drakonis_ has joined #nixos-dev

03:32 drakonis has quit [Ping timeout: 250 seconds]

03:40 pie__ has quit [Remote host closed the connection]

03:41 pie__ has joined #nixos-dev

03:51 coconnor has quit [Ping timeout: 272 seconds]

04:00 lassulus_ has joined #nixos-dev

04:02 lassulus has quit [Ping timeout: 240 seconds]

04:02 lassulus_ is now known as lassulus

04:03 hl has quit [Ping timeout: 246 seconds]

04:04 eadwu has quit [Ping timeout: 258 seconds]

05:25 drakonis has joined #nixos-dev

05:27 drakonis_ has quit [Ping timeout: 252 seconds]

05:45 pie__ has quit [Remote host closed the connection]

05:46 pie__ has joined #nixos-dev

06:22 init_6 has quit [Ping timeout: 246 seconds]

06:24 init_6 has joined #nixos-dev

07:10 orivej has joined #nixos-dev

07:33 orivej has quit [Ping timeout: 258 seconds]

08:52 init_6 has quit [Ping timeout: 258 seconds]

08:54 init_6 has joined #nixos-dev

09:15 orivej has joined #nixos-dev

09:36 FRidh has joined #nixos-dev

09:59 orivej has quit [Ping timeout: 268 seconds]

10:55 init_6 has quit [Ping timeout: 246 seconds]

10:57 init_6 has joined #nixos-dev

11:02 drakonis has quit [Ping timeout: 268 seconds]

11:28 init_6 has quit [Ping timeout: 246 seconds]

11:30 init_6 has joined #nixos-dev

11:33 jtojnar has joined #nixos-dev

11:40 phreedom_ has joined #nixos-dev

11:44 phreedom has quit [Ping timeout: 256 seconds]

11:45 init_6 has quit [Ping timeout: 240 seconds]

11:58 drakonis has joined #nixos-dev

12:13 globin has quit [Remote host closed the connection]

12:30 drakonis has quit [Read error: Connection reset by peer]

12:38 drakonis has joined #nixos-dev

12:44 globin has joined #nixos-dev

13:41 <gchristensen> it is sort of funny that maintainer-list.nix doesn't contain a single list

13:42 __Sander__ has joined #nixos-dev

13:42 <domenkozar> :D

13:53 Sigyn has quit [Quit: Maybe the only significant difference between a really smart simulation and a human being was the noise they made when you punched them]

13:55 Sigyn has joined #nixos-dev

14:35 <timokau[m]> gchristensen: Are you sure adding maintainers to some team without premissions will actually solve the issue? The API doc says:

14:35 <timokau[m]> "Pull request authors and repository owners and collaborators can request

14:35 <timokau[m]> a pull request review from anyone with write access to the repository"

14:36 <timokau[m]> Specifically "write access"

15:02 orivej has joined #nixos-dev

15:11 orivej has quit [Ping timeout: 250 seconds]

15:19 Synthetica has joined #nixos-dev

15:23 <FRidh> Repository owners and collaborators can request a pull request review from anyone with read access to the repository. Organization members can also request a pull request review from teams with read access to the repository.

15:23 <FRidh> https://help.github.com/articles/requesting-a-pull-request-review/

15:24 <gchristensen> yeah, so I did try it with a different org and a different repo when two members were given read-only access and they I was able to request a review by them

15:24 <FRidh> good

15:26 <gchristensen> wait ... on a different test reop, it doesn't seem to work.

15:26 <gchristensen> :|

15:28 <FRidh> gchristensen: not accepted role as collaborator yet?

15:32 drakonis has quit [Ping timeout: 245 seconds]

15:45 <timokau[m]> FRidh: interesting that the user documentation states the exact opposite from the api doc. My quote was from https://developer.github.com/v3/pulls/review_requests/

15:46 <timokau[m]> But "anyone with read access" clearly isn't true either since I can't request reviews from anyone that is not a member

15:49 <FRidh> timokau[m]: "read access" and being able to clone are two different things in github. With read access, they mean members with read access

15:50 <FRidh> it's confusing

16:06 <timokau[m]> Can someone restart https://hydra.nixos.org/build/86625496? There is a race condition in the test suite, I've created an upstream ticket for it.

16:18 orivej has joined #nixos-dev

16:30 __Sander__ has quit [Quit: Konversation terminated!]

16:30 pie__ has quit [Remote host closed the connection]

16:31 pie__ has joined #nixos-dev

16:32 orivej has quit [Ping timeout: 250 seconds]

16:34 <srhb> timokau[m]: Yep

16:39 drakonis has joined #nixos-dev

16:40 <timokau[m]> srhb: Thanks!

17:05 <gchristensen> FRidh: want to experiment?

17:06 <FRidh> gchristensen: sure

17:06 jtojnar has quit [Ping timeout: 245 seconds]

17:07 jtojnar has joined #nixos-dev

17:08 <gchristensen> ok I just invited you

17:10 <FRidh> gchristensen: ok am now a member

17:11 <gchristensen> hmm so I added th team to the repo https://github.com/eb6cb83a-cf75-4e88-a11a-ce117467d8ae/4ec54bd9-c707-4238-bc46-48596d6d7659/pull/2

17:11 <{^_^}> eb6cb83a-cf75-4e88-a11a-ce117467d8ae/4ec54bd9-c707-4238-bc46-48596d6d7659#2 (by grahamc, 1 hour ago, open): Create oeu

17:11 <gchristensen> and was able to add you as a reviewer

17:11 <gchristensen> can you explore and see if you have any special privileges beyond what you could normally do without being a member?

17:12 <FRidh> gchristensen: yep. I can't merge, so that's good

17:13 <FRidh> can't ask for reviewers or set labels either

17:15 <gchristensen> nice

17:16 <FRidh> can't hide comments either

17:16 <FRidh> other than mine own

17:16 <FRidh> my*

17:17 <gchristensen> oh nice thing to check

17:17 <FRidh> going through the list https://help.github.com/articles/permission-levels-for-an-organization/

17:18 <FRidh> can post to a team

17:22 <gchristensen> to the "Secrets" tem?

17:26 <FRidh> yes

17:26 <gchristensen> that is probably fine

17:26 <FRidh> can thus also see the teams

17:27 <FRidh> think that's fine as well

17:28 <gchristensen> yea

17:28 <gchristensen> https://github.com/softprops/hubcaps/pull/191 merged so I think this can be implemented now

17:28 <{^_^}> softprops/hubcaps#191 (by grahamc, 14 hours ago, merged): Teams: create/update/edit teams + members

17:51 orivej has joined #nixos-dev

19:08 phreedom_ is now known as phreedom

20:13 sir_guy_carleton has joined #nixos-dev

20:27 MichaelRaskin has joined #nixos-dev

20:34 jtojnar has quit [Quit: jtojnar]

20:34 jtojnar has joined #nixos-dev

21:22 orivej has quit [Read error: Connection reset by peer]

21:23 orivej has joined #nixos-dev

21:39 worldofpeace has joined #nixos-dev

22:05 eadwu has joined #nixos-dev

22:07 orivej has quit [Ping timeout: 246 seconds]

22:07 orivej_ has joined #nixos-dev

22:34 jtojnar has quit [Remote host closed the connection]

22:35 jtojnar has joined #nixos-dev

23:15 eadwu has quit [Ping timeout: 246 seconds]

23:25 FRidh has quit [Quit: Konversation terminated!]

23:31 pie__ has quit [Remote host closed the connection]

23:40 orivej_ has quit [Ping timeout: 246 seconds]

23:52 pie_ has joined #nixos-dev

23:57 orivej has joined #nixos-dev