gchristensen changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | 18.09 release managers: vcunat and samueldr | https://logs.nix.samueldr.com/nixos-dev
drakonis has joined #nixos-dev
eadwu has joined #nixos-dev
<gchristensen> building the man page for configuration.nix is so slow now :|
Lingjian has joined #nixos-dev
eadwu has quit [Ping timeout: 252 seconds]
eadwu has joined #nixos-dev
Lingjian has quit [Ping timeout: 252 seconds]
LnL has quit [Quit: exit 1]
drakonis has quit [Read error: Connection reset by peer]
lassulus_ has joined #nixos-dev
lassulus has quit [Ping timeout: 246 seconds]
lassulus_ is now known as lassulus
eadwu has quit [Ping timeout: 252 seconds]
pie__ has joined #nixos-dev
pie_ has quit [Ping timeout: 240 seconds]
jtojnar has quit [Ping timeout: 268 seconds]
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-dev
<moredread[m]> I'm updating mediathekview. There currently also is zdfmediathk, which isn't working anymore and has been superseeded by mediathekview. What is the correct way to remove the package? As it hasn't been working for over 2 years now I guess there aren't any users left.
q6AA4FD has joined #nixos-dev
MichaelRaskin has quit [Quit: MichaelRaskin]
orivej has quit [Ping timeout: 268 seconds]
orivej has joined #nixos-dev
<arianvp> Have we ever considered applying NixOS for gsoc?
<andi-> moredread[m]: remove from master, leave it in stable IMO, it will then disappear next release
<Profpatsch> gchristensen: Which part of it is slow? It might help splitting up the generation to one per module.
__Sander__ has joined #nixos-dev
<Profpatsch> gchristensen: huh, why does ofborg give this build failure a “neutral” status? https://github.com/NixOS/nixpkgs/pull/53840/checks?check_run_id=49604939
eadwu has joined #nixos-dev
jtojnar has joined #nixos-dev
eadwu has quit [Ping timeout: 252 seconds]
__Sander__ has quit [Quit: Konversation terminated!]
symphorien has quit [Quit: WeeChat 2.2]
<gchristensen> failures aren't guaranteed to be a bad thing
<gchristensen> and a red X in the build statuses should guarantee a bad thing
<gchristensen> ( where "Bad thing" == merge blocking)
averell has quit [Remote host closed the connection]
averell has joined #nixos-dev
Guest83973 has joined #nixos-dev
Guest83973 is now known as LnL
orivej has quit [Ping timeout: 244 seconds]
orivej has joined #nixos-dev
<tilpner> Anyone wants to hit the merge button on #53147 before GH stops considering it recent and I forget about it?
<{^_^}> https://github.com/NixOS/nixpkgs/pull/53147 (by tilpner, 1 week ago, open): abduco: 0.6 -> 2018-05-16
<tilpner> gchristensen++
<{^_^}> gchristensen's karma got increased to 62
<Profpatsch> gchristensen: Huh, I don’t understand. When I say `@ofborg build <attribute>`, I’d expect it to give me a big red NONO if some build fails.
<gchristensen> it isn't necessarily merge blocking, though
<moredread[m]> andi-: So there is no deprecation notice for users?
<Profpatsch> e.g. on https://github.com/NixOS/nixpkgs/pull/53840 *every single* build has failed.
<{^_^}> #53840 (by uri-canva, 2 days ago, open): bazel-remote: init at 2019-01-12
<Profpatsch> And the status thing shows a giant green arrow.
<gchristensen> check-mark?
<Profpatsch> yeah
<gchristensen> yeah
<gchristensen> but it isn't necessarily merge blocking.
<Profpatsch> Sure is.
<gchristensen> no
<gchristensen> maybe it failed because a mass rebuild hit master
<gchristensen> maybe it failed because it wasn't supposed to pass
<gchristensen> like trying to compile it on a different arch than it was intended for
<Profpatsch> And red means no maintainer can override it?
<Profpatsch> Because I’d rather a maintainer merge a red status than a maintainer merges because it looks like everything built.
<gchristensen> maintainers can override it.
<gchristensen> that is a problem, and is why I'm so adamant about the signal being perfectly clear
<gchristensen> right now, red means DO NOT MERGE. if we add any bit of red which can possibly mean anything other than DO NOT MERGE, people will merge even if it should be a blocker
<Profpatsch> Right now I have a grey square and a light-grey “build results” without any information whether the build suceeded.
<gchristensen> "Build Results" could change to "Build «status»"?
<{^_^}> #53840 (by uri-canva, 2 days ago, open): bazel-remote: init at 2019-01-12
<Profpatsch> Ah, you mean could.
<gchristensen> «could» :)
<Profpatsch> Yeah, that’s a good idea.
<Profpatsch> And “Completed in -1m” should probably change to “Unsupported arch”
<gchristensen> that is a different thing, heh
<gchristensen> I'm not willing to make buildfailures become red X's until the standard eval checks actually block merges
<Profpatsch> At least there is no obvious way to filter out unsupported architectures.
<Profpatsch> But I see what you mean about “red should never be merged”
<gchristensen> cool :)
<gchristensen> where would you like to filter out unsupported architectures?
<gchristensen> tbh I think other than the comment spam, the ofborg comments provided a better UX :|
<Profpatsch> gchristensen: Nonetheless, right now github shows build failures as mostly green.
<gchristensen> concretely, would changing "Build Results" to "Build <status>" improve the situation?
<Profpatsch> gchristensen: Hm, unsupported architectures are valuable to have as neutral I think. Even better would be if the build could be tried on the unsupported arch as well to see whether it would succeed, and I it doesn’t it should not throw an erro.
<Profpatsch> error
<Profpatsch> And yes, build <status> would help.
<gchristensen> packages can fail to evaluate on supported architectures due to other packages growing dependencies which don't support the architecture, causing that non-error to be potentially a misnomer
<gchristensen> Profpatsch: are you interested in sending a PR to improve it? https://github.com/NixOS/ofborg/blob/released/ofborg/src/tasks/githubcommentposter.rs#L145
orivej has quit [Ping timeout: 240 seconds]
<Profpatsch> gchristensen: I have tried to play with ofborg two weeks ago, but found it a bit hard to get a working Rabbit-setup going.
<gchristensen> this requires no rabbit setup
<gchristensen> just a code change and `cargo test`
<Profpatsch> Are the tests completely self-sufficient?
<gchristensen> for this case, yes
<gchristensen> or rather, yes, the tests don't talk to rabbit at all -- in no cases
primeos has quit [Quit: WeeChat 2.3]
primeos has joined #nixos-dev
ekleog has quit [Quit: WeeChat 2.2]
ekleog has joined #nixos-dev
orivej has joined #nixos-dev
ixxie has joined #nixos-dev
JosW has joined #nixos-dev
<timokau[m]> "tbh I think other than the comment spam, the ofborg comments provided a better UX :|" I kinda miss the comments too, especially since github will not notify me when checks are finished
ixxie has quit [Remote host closed the connection]
JosW has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
<gchristensen> should NixOS set SourcePath on systemd jobs? " A path to a configuration file this unit has been generated from. This is primarily useful for implementation of generator tools that convert configuration from an external configuration file format into native unit files. This functionality should not be used in normal units."
orivej has quit [Ping timeout: 245 seconds]
Haskellfant has joined #nixos-dev
cbarrett_ has joined #nixos-dev
lopsided98_ has joined #nixos-dev
yegortimoshenko has quit [Ping timeout: 268 seconds]
bennofs[m] has quit [Ping timeout: 268 seconds]
fadenb has quit [Ping timeout: 268 seconds]
cbarrett has quit [Ping timeout: 268 seconds]
flokli has quit [Ping timeout: 268 seconds]
lopsided98 has quit [Ping timeout: 268 seconds]
cocreature has quit [Ping timeout: 268 seconds]
florianjacob has quit [Ping timeout: 268 seconds]
cbarrett_ is now known as cbarrett
Haskellfant is now known as cocreature
yegortimoshenko has joined #nixos-dev
fadenb has joined #nixos-dev
flokli has joined #nixos-dev
bennofs[m] has joined #nixos-dev
jtojnar has quit [Read error: Connection reset by peer]
jtojnar has joined #nixos-dev
drakonis has joined #nixos-dev
<zimbatm> SourcePath is expecting a single file, I don't think it maps to a bunch of nixos modules very well
eadwu has joined #nixos-dev
drakonis has quit [Ping timeout: 252 seconds]
tilpner has quit [Ping timeout: 244 seconds]
Synthetica has joined #nixos-dev
<gchristensen> yeah, true
<ekleog> timokau[m]: hopefully the next step will be build-and-merge-or-post-comment (hopefully abbreviated :p)
<timokau[m]> What do you men abbreviated? Ofborg needs some respect, we should be required to write polite essays requesting it's assistance
<timokau[m]> (but yeah that'd be incredible)
<ekleog> @ofborg, oh ye all-powerful, might thou grant us yer wisdom and build this miserable pull wish
<Synthetica> @ofborg take the wheel
<gchristensen> Synthetica++
<{^_^}> Synthetica's karma got increased to 2
eadwu has quit [Ping timeout: 268 seconds]
<flokli> @ofborg you have the bridge