<worldofpeace>
mkg20001: looking, sorry about that
<worldofpeace>
"Don't forget to report any bugs you'll find, there might be a lot since it's new." I feel like this downplays the whole highlight
<mkg20001>
remove? replace?
<mkg20001>
There's stuff broken that I didn't catch so I want to have people feel encouraged to report it someway or another
<worldofpeace>
Remember that, with any new features it's possible you could run into issues, so please send all support requests to github.com/NixOS/nixpkgs to notify the maintainers of cinnamon. I feel like that could soften a subtext that sounds like "this is buggy"
<mkg20001>
I would go with "to notify the maintainers" and not explicitly say which because some is upstream, some isn't
<mkg20001>
Other than that perfect
<worldofpeace>
okay, sounds about right
<worldofpeace>
though u can never avoid the worst thing, which are users that try something and notice and issue but NEVER make a bug report. and usually it's something stupid for an otherwise okay experience
<worldofpeace>
"this distro suks I'm using Fedora again"
<mkg20001>
yeah but I'm trying to reduce the propability by mentioning it
<mkg20001>
especially since with DEs there's a lot more places a bug could be than with a simple app
<worldofpeace>
exactly
<mkg20001>
f-pushed, LGTM?
<worldofpeace>
mkg20001: features -> feature didn't get pushed?
<mkg20001>
fixed
<worldofpeace>
it seems u pushed this branch to master, btw
<worldofpeace>
can't remember which setting will prevent that
<mkg20001>
how?
<mkg20001>
I pushed to a branch on origin
<mkg20001>
But I don't know I mean that's not wrong?
<mkg20001>
It's not master so uh
<worldofpeace>
Yeah, there's no real "issue" with pushing a branch to the upstream. I've just noticed other contributors advising to keep your branches in your fork unless hydra (for example) depends on them or you have nixpkgs collaborators
<mkg20001>
ah ok
<worldofpeace>
backport also needed, btw
<mkg20001>
Intersting to learn the unwritten rules of nixpkgs
<worldofpeace>
that's basically the entire induction process as a committer. just learning that there's about 100+ unwritten rules that u need to convey to people to be a good maintainer 🤣