00:10
<
samueldr >
using (( )) is the only way to make sense of numbers in bash
00:11
<
samueldr >
[[ 1 < 2 ]] # works on the strings being ordered lexicographically
00:20
orivej has quit [Ping timeout: 256 seconds]
00:37
<
abathur >
wrt to [ and [[ in bash, I agree generally, but I've been trying (and roughly succeeding) to avoid them in create-darwin-volume.sh for now because the PR also converts shebang to /usr/bin/env from /bin/sh
00:38
<
abathur >
I did change one for now, because lilyball caught a bug in a string-match I was trying to shoehorn into [ idioms
00:39
<
abathur >
but otherwise I want to avoid making a bunch of work converting them all back if someone shows up at the wedding with a reason it must be sh
00:40
<
abathur >
similar with performance
00:42
<
supersandro2000 >
samueldr: just using (()) without anything else does not really
00:42
<
samueldr >
I don't know what you
00:42
<
samueldr >
what you're looking at
00:42
<
abathur >
I made some changes here with an eye toward clawing back a little performance, but usually just because I was already touching it or shellcheck griped; generally prefer a later pass for those
00:43
<
samueldr >
and yeah, abathur, totally agree if you use /bin/sh preferring `test` is probably better
00:43
<
samueldr >
though when I do I write `test` instead of `[
00:43
<
samueldr >
supersandro2000: that's the only way to do maths
00:43
<
supersandro2000 >
a=1 is not math
00:44
<
samueldr >
it telegraphs it's going to be used as a number
00:44
<
samueldr >
which we see later
00:44
<
samueldr >
((_remind_num++))
00:44
<
supersandro2000 >
hmmm
00:45
<
abathur >
I prefer test myself (though I guess it's more likely to get broken if some comedian writes a test() function :)
00:45
<
supersandro2000 >
but who wants to use sh with [? It does really weird things
00:45
<
samueldr >
abathur: remove all comedy :)
00:45
<
supersandro2000 >
[[ is just nicer to use with less " and no = comparison
00:46
<
samueldr >
posixly speaking, [[ doesn't exist IIRC
00:46
<
samueldr >
using /bin/sh with non-posix constructs is... not great
00:46
<
samueldr >
though I don't know about (()) and POSIX
00:47
<
abathur >
it hopefully won't be /bin/sh beyond this PR
00:47
<
samueldr >
it does seem to imply (()) exists
00:47
<
supersandro2000 >
yeah
00:47
<
supersandro2000 >
so [[ can be used
00:50
<
supersandro2000 >
I don't know why you want to use sh over bash
00:51
<
abathur >
I'm not sure why /bin/sh was used initially, maybe just inertia since it was originally run from the main install script, which is also /bin/sh
00:54
<
abathur >
I'm mostly changing it because of a chain of other things; I'm changing it because I'm shifting its primary use case from being invoked from the main install script to being sourced from the multi-user installer (which is /usr/bin/env bash)
00:55
<
abathur >
I'm shifting its primary use case because people agree the macOS install is getting too complex to call single-user
00:56
<
abathur >
and if it doesn't have to support single-user installs, a quick way to improve its quality is to take advantage of the existing UX idioms in install-multi-user.sh
01:01
<
abathur >
oh, I guess sandro's talking about install-multi-user.sh anyways; I'm being a bit thick since I've been focused on that and asked about it earlier
01:09
rajivr has joined #nixos-dev
01:12
ris has quit [Ping timeout: 240 seconds]
01:22
<
abathur >
tangentially, if it doesn't exist, there might be a neat tool opportunity (particularly tractable w/ nix) for something that evaluates statements in multiple shells for comparison
01:36
tilpner_ has joined #nixos-dev
01:39
tilpner has quit [Ping timeout: 240 seconds]
01:39
tilpner_ is now known as tilpner
01:39
<
supersandro2000 >
you can change the shell in the beginning and shellcheck should complain about some common errors in that shell
01:42
m1cr0man has quit [Ping timeout: 272 seconds]
01:46
cole-h has joined #nixos-dev
01:49
m1cr0man has joined #nixos-dev
01:52
supersandro2000 has joined #nixos-dev
01:58
kalbasit has joined #nixos-dev
02:39
teto has quit [Ping timeout: 272 seconds]
02:41
alp has quit [Ping timeout: 272 seconds]
03:27
zarel_ has quit [Ping timeout: 256 seconds]
03:27
kalbasit has quit [Ping timeout: 272 seconds]
03:28
m1cr0man has quit [Ping timeout: 240 seconds]
03:47
zarel has joined #nixos-dev
05:24
srk has quit [Remote host closed the connection]
05:25
srk has joined #nixos-dev
06:21
kalbasit has joined #nixos-dev
06:27
LnL has quit [Ping timeout: 256 seconds]
06:28
LnL has joined #nixos-dev
06:31
cole-h has quit [Ping timeout: 256 seconds]
06:46
kalbasit has quit [Ping timeout: 272 seconds]
06:54
clever_ has joined #nixos-dev
06:57
clever has quit [Ping timeout: 256 seconds]
08:52
orivej has joined #nixos-dev
10:26
teto has joined #nixos-dev
10:31
alp has joined #nixos-dev
10:49
alp has quit [Quit: Leaving]
10:50
alp has joined #nixos-dev
10:52
alp has quit [Client Quit]
10:52
alp- has joined #nixos-dev
10:52
alp- is now known as alp
11:00
alp has quit [Read error: Connection reset by peer]
11:00
alp has joined #nixos-dev
11:11
maralorn has quit [Ping timeout: 240 seconds]
11:11
Irenes[m] has quit [Ping timeout: 246 seconds]
11:11
treed[m] has quit [Ping timeout: 246 seconds]
11:11
jdnixx-M1 has quit [Ping timeout: 244 seconds]
11:11
zowoq[m] has quit [Ping timeout: 240 seconds]
11:11
bbigras has quit [Ping timeout: 240 seconds]
11:11
bennofs[m] has quit [Ping timeout: 240 seconds]
11:11
kraem has quit [Ping timeout: 240 seconds]
11:11
michaelpj has quit [Ping timeout: 246 seconds]
11:11
aanderse has quit [Ping timeout: 246 seconds]
11:11
ryantm has quit [Ping timeout: 246 seconds]
11:11
arcnmx has quit [Ping timeout: 246 seconds]
11:11
rycee has quit [Ping timeout: 260 seconds]
11:11
thefloweringash has quit [Ping timeout: 260 seconds]
11:12
ma27[m] has quit [Ping timeout: 268 seconds]
11:12
bk1603[m] has quit [Ping timeout: 240 seconds]
11:12
siraben has quit [Ping timeout: 240 seconds]
11:12
timokau[m] has quit [Ping timeout: 244 seconds]
11:12
jtojnar has quit [Ping timeout: 244 seconds]
11:12
colemickens has quit [Ping timeout: 244 seconds]
11:12
Ox4A6F has quit [Ping timeout: 244 seconds]
11:12
puzzlewolf has quit [Ping timeout: 244 seconds]
11:12
emily has quit [Ping timeout: 244 seconds]
11:12
Valodim[m] has quit [Ping timeout: 246 seconds]
11:12
jonge[m] has quit [Ping timeout: 246 seconds]
11:12
domenkozar[m] has quit [Ping timeout: 246 seconds]
11:12
matthewkenigsber has quit [Ping timeout: 246 seconds]
11:12
aterius has quit [Ping timeout: 268 seconds]
11:12
roberth has quit [Ping timeout: 268 seconds]
11:12
worldofpeace has quit [Ping timeout: 246 seconds]
11:12
nh2[m] has quit [Ping timeout: 244 seconds]
11:12
danielrf[m] has quit [Ping timeout: 244 seconds]
11:12
Dandellion has quit [Ping timeout: 240 seconds]
11:13
ky0ko1 has quit [Ping timeout: 246 seconds]
11:13
symphorien[m] has quit [Ping timeout: 260 seconds]
11:13
rnhmjoj has quit [Ping timeout: 268 seconds]
11:13
regnat has quit [Ping timeout: 244 seconds]
11:13
Ericson2314 has quit [Ping timeout: 246 seconds]
11:13
DamienCassou has quit [Ping timeout: 244 seconds]
11:13
philipp[m] has quit [Ping timeout: 244 seconds]
11:16
evils has quit [Quit: Lost terminal]
11:17
evils has joined #nixos-dev
11:17
mkaito has joined #nixos-dev
11:17
mkaito has joined #nixos-dev
11:17
mkaito has quit [Changing host]
11:26
treed[m] has joined #nixos-dev
11:26
Irenes[m] has joined #nixos-dev
11:29
michaelpj has joined #nixos-dev
11:29
aanderse has joined #nixos-dev
11:29
maralorn has joined #nixos-dev
11:29
Dandellion has joined #nixos-dev
11:29
zowoq[m] has joined #nixos-dev
11:29
bbigras has joined #nixos-dev
11:29
ryantm has joined #nixos-dev
11:30
jdnixx-M1 has joined #nixos-dev
11:30
Ericson2314 has joined #nixos-dev
11:30
nh2[m] has joined #nixos-dev
11:31
ky0ko1 has joined #nixos-dev
11:31
bennofs[m] has joined #nixos-dev
11:32
domenkozar[m] has joined #nixos-dev
11:33
<
ehmry >
we should probably patch shell check to complain if the shell isn't /usr/bin/env :p
11:33
matthewkenigsber has joined #nixos-dev
11:33
kraem has joined #nixos-dev
11:35
arcnmx has joined #nixos-dev
11:36
jonge[m] has joined #nixos-dev
11:37
jtojnar has joined #nixos-dev
11:37
worldofpeace has joined #nixos-dev
11:37
siraben has joined #nixos-dev
11:40
Valodim[m] has joined #nixos-dev
11:41
rnhmjoj has joined #nixos-dev
11:41
emily has joined #nixos-dev
11:41
Ox4A6F has joined #nixos-dev
11:41
timokau[m] has joined #nixos-dev
11:41
bk1603[m] has joined #nixos-dev
11:41
ma27[m] has joined #nixos-dev
11:42
colemickens has joined #nixos-dev
11:42
aterius has joined #nixos-dev
11:42
puzzlewolf has joined #nixos-dev
11:43
thefloweringash has joined #nixos-dev
11:43
jpo has quit [Ping timeout: 256 seconds]
11:43
roberth has joined #nixos-dev
11:45
symphorien[m] has joined #nixos-dev
11:45
DamienCassou has joined #nixos-dev
11:45
regnat has joined #nixos-dev
11:46
rycee has joined #nixos-dev
11:47 __monty__ has joined #nixos-dev
11:49
philipp[m] has joined #nixos-dev
11:50
danielrf[m] has joined #nixos-dev
11:57
clever_ has quit [Changing host]
11:57
clever_ has joined #nixos-dev
11:57
clever_ is now known as clever
12:03
ris has joined #nixos-dev
12:36
orivej has quit [Ping timeout: 264 seconds]
13:27
jpo has joined #nixos-dev
14:06
m1cr0man has joined #nixos-dev
14:26
m1cr0man has quit [Ping timeout: 240 seconds]
14:44
srk has quit [Remote host closed the connection]
14:44
srk has joined #nixos-dev
14:46
m1cr0man has joined #nixos-dev
14:50
orivej has joined #nixos-dev
14:54
m1cr0man has quit [Ping timeout: 264 seconds]
15:47
tilpner has quit [Quit: tilpner]
15:53
tilpner has joined #nixos-dev
15:57
m1cr0man has joined #nixos-dev
16:07
m1cr0man has quit [Ping timeout: 246 seconds]
16:13
<
Ericson2314 >
ehmry: :) I think they could take a patch for that
16:13
<
Ericson2314 >
if it was a flag
16:14
m1cr0man has joined #nixos-dev
16:26
m1cr0man has quit [Ping timeout: 272 seconds]
16:29
m1cr0man has joined #nixos-dev
16:37
m1cr0man has quit [Read error: Connection reset by peer]
16:38
m1cr0man has joined #nixos-dev
16:51
m1cr0man has quit [Quit: G'luck]
16:52
m1cr0man has joined #nixos-dev
17:16
m1cr0m4n has joined #nixos-dev
17:17
m1cr0man has quit [Ping timeout: 272 seconds]
18:16
kalbasit has joined #nixos-dev
18:30
m1cr0m4n has quit [Ping timeout: 240 seconds]
18:38
m1cr0man has joined #nixos-dev
18:44
m1cr0man has quit [Read error: Connection reset by peer]
18:45
m1cr0man has joined #nixos-dev
18:57
rajivr has quit [Quit: Connection closed for inactivity]
19:22
evanjs has joined #nixos-dev
19:51
m1cr0m4n has joined #nixos-dev
19:52
m1cr0man has quit [Ping timeout: 256 seconds]
20:34
Cale has quit [Remote host closed the connection]
21:38
kalbasit has quit [Ping timeout: 240 seconds]
22:12
bgamari has joined #nixos-dev
22:14
bgamari_ has quit [Ping timeout: 264 seconds]
22:19
lejonet has quit [Ping timeout: 256 seconds]
23:05
tilpner has quit [Remote host closed the connection]
23:05
tilpner has joined #nixos-dev
23:34
MichaelRaskin has quit [Quit: MichaelRaskin]
23:41 __monty__ has quit [Quit: leaving]
23:46
supersandro2000 has quit [Ping timeout: 246 seconds]
23:50
supersandro2000 has joined #nixos-dev