worldofpeace changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 20.09 Nightingale ✨ https://discourse.nixos.org/t/nixos-20-09-release/9668 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 20.09 RMs: worldofpeace, jonringer | https://logs.nix.samueldr.com/nixos-dev
<abathur> <3 gchristensen andi-
<{^_^}> gchristensen's karma got increased to 0b110000111
<abathur> erg <3 andi-
<{^_^}> andi-'s karma got increased to 48
<abathur> <3 {^_^} always doing what I say and not what I mean
<{^_^}> {^_^}'s karma got increased to 225
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-dev
cole-h has joined #nixos-dev
supersandro2000 has quit [Quit: The Lounge - https://thelounge.chat]
supersandro2000 has joined #nixos-dev
<andi-> nice, are they still trying to catch up?
<gchristensen> yea
<gchristensen> 81 remaining
<andi-> each of them does multiple or just one at a time? It feels a bit wasteful having a full multi-core machine eval a single PR :D
<gchristensen> just one I think
<gchristensen> could maybe do 4 per
<andi-> what device type are these?
<gchristensen> m1.xlarge
<andi-> wow, I think they can definitly do more than just one :D
<andi-> or are they also building stuff?
<gchristensen> each runs a builder too
<andi-> ah okay, the name was missleading then
<gchristensen> yeah
<gchristensen> that screenshot was a list of consumers on the evaluation queue
LnL has quit [Ping timeout: 265 seconds]
LnL has joined #nixos-dev
LnL has quit [Changing host]
LnL has joined #nixos-dev
<gchristensen> the real story though is I provisioned 15 machines, 0-14, and look at how many holes there are from failed provisions
<andi-> holes? Which picture am I missing?
<samueldr> evaluator-#-x86_64 in the tag, andi-
<andi-> ah, 5,7,9.10... you probably typoed :P
<gchristensen> lol
<gchristensen> hard to typo one "how many do you want?" number
<andi-> must be a nix bug then ;)
<gchristensen> none of those find their disk on bootup
<andi-> ouch
<andi-> is it that NVME but where all the physical "partitions" have been deleted?
<gchristensen> hahaha
<gchristensen> no
<andi-> s/but/bug/
<andi-> the future is diskless..
<gchristensen> m1.* series is being phased out just like the t1.* series, so they're a bit unloved and it is a gamble if /dev/sda (where the installer says to write the bootlooader) is one the bios looks at during boot up
<gchristensen> this would be fixed if they added a description of the boot disk to their API like I asked them to, but they only did that for the newer classes afaik
kalbasit has joined #nixos-dev
garbas[m] has joined #nixos-dev
jpo has quit [Ping timeout: 246 seconds]
justanotheruser has quit [Ping timeout: 272 seconds]
LnL has quit [Quit: exit 1]
LnL has joined #nixos-dev
jpo has joined #nixos-dev
justanotheruser has joined #nixos-dev
jpo has quit [Ping timeout: 260 seconds]
justan0theruser has joined #nixos-dev
justanotheruser has quit [Ping timeout: 272 seconds]
jpo has joined #nixos-dev
kalbasit has quit [Remote host closed the connection]
jpo has quit [Ping timeout: 240 seconds]
LnL has quit [Quit: exit 1]
LnL has joined #nixos-dev
Jackneill has quit [Ping timeout: 240 seconds]
Jackneill has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 272 seconds]
AlwaysLivid has joined #nixos-dev
LnL has quit [Quit: exit 1]
LnL has joined #nixos-dev
LnL has quit [Changing host]
LnL has joined #nixos-dev
cole-h has quit [Ping timeout: 264 seconds]
AlwaysLivid has quit [Ping timeout: 272 seconds]
AlwaysLivid has joined #nixos-dev
jpo has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 272 seconds]
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 260 seconds]
jonringer has quit [Ping timeout: 264 seconds]
xwvvvvwx- has joined #nixos-dev
xwvvvvwx- is now known as xwvvvvwx
FRidh has joined #nixos-dev
FRidh has quit [Read error: Connection reset by peer]
FRidh has joined #nixos-dev
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-dev
<sphalerite> gchristensen: hmmm will they be selling them? :p
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 264 seconds]
AlwaysLivid has joined #nixos-dev
tilpner_ has joined #nixos-dev
tilpner has quit [Ping timeout: 256 seconds]
tilpner_ is now known as tilpner
__monty__ has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
<gchristensen> hehe no idea
<gchristensen> now that ofborg is caught up, I'm going to scale it back from 15 evaluators to, I dunno, 5
<eyJhb> gchristensen: does ofborg run on AWS?
<gchristensen> no, mostly Packet
<eyJhb> Oh that's right. Sorry!
<gchristensen> thank goodness :)
<eyJhb> Packet > AWS? :p
AlwaysLivid has quit [Ping timeout: 272 seconds]
<gchristensen> Packet sponsors NixOS
<gchristensen> making this free instead of 10's of dollars per hour of equipment
<eyJhb> Oh yeah, that makes it a lot better :p Guessing they use NixOS themselves?
AlwaysLivid has joined #nixos-dev
<gchristensen> not sure actually
dstzd has quit [Quit: ZNC - https://znc.in]
dstzd has joined #nixos-dev
dstzd has quit [Client Quit]
dstzd has joined #nixos-dev
dstzd has quit [Client Quit]
dstzd has joined #nixos-dev
dstzd has quit [Client Quit]
dstzd has joined #nixos-dev
dstzd has quit [Client Quit]
dstzd has joined #nixos-dev
dstzd has quit [Client Quit]
dstzd has joined #nixos-dev
<infinisil> The amount of PR's requesting reviews from all codeowners is too damn high!
<FRidh> infinisil: now that master is merged every 6 hours into staging(-next) automatically, I expect this issue to be occuring less often. I mean, its only happening when someone changes branch, right?
<infinisil> FRidh: #107249 and #107176 were the most recent instances for me
<{^_^}> https://github.com/NixOS/nixpkgs/pull/107249 (by damhiya, 3 hours ago, closed): notsodeep: init at 2019.5.29
<{^_^}> https://github.com/NixOS/nixpkgs/pull/107176 (by vq, 1 day ago, closed): Add/lxi tools
<FRidh> Yes, that's annoying. No way we can fix this.
<pie_> FRidh: @ composemanyextension, finally! (not that I have immediate need for it)
<sphalerite> FRidh: not using CODEOWNERS would be a fix :p
<siraben> supersandro2000: I have some KnightOS PRs that are ready for review, #99272 and #107261
<{^_^}> https://github.com/NixOS/nixpkgs/pull/99272 (by siraben, 11 weeks ago, open): knightos-scas: 0.4.6 -> 0.5.3, knightos-z80e: 0.5.0 -> 0.5.2
<{^_^}> https://github.com/NixOS/nixpkgs/pull/107261 (by siraben, 6 minutes ago, open): knightos-kimg: 0.3.0 -> 0.4.0
<infinisil> sphalerite: Yeah, I've been thinking about implementing a bot that does something like codeowners, but a bit more smarter
<infinisil> Though I'm not sure how the smarts would be best implemented
<infinisil> Maybe "Assume that the base branch is the one that adds the least amount of commits"
AlwaysLivid has quit [Read error: Connection reset by peer]
AlwaysLivid has joined #nixos-dev
<siraben> supersandro2000: and #106967 as well
<{^_^}> https://github.com/NixOS/nixpkgs/pull/106967 (by siraben, 5 days ago, open): knightos-kcc: 4.0.0 -> 4.0.4
<lukegb> infinisil: "you added 20 commits in one go, that seems excessive"
<infinisil> There are cases where one might add 20 commits though
AlwaysLivid has quit [Read error: Connection reset by peer]
AlwaysLivid has joined #nixos-dev
<siraben> at the rate we have PRs and issues, how long until we hit 200K?
<lukegb> infinisil: Sure, but even in that case you probably don't want to ping every code owner at once. Or an explicit "are you sure" check is fine.
<lukegb> Also... honestly there aren't that many good reasons for having 20 commits in a single PR when they're being merged rather than squashed in
<infinisil> You do want to ping codeowners for legitimate commits though, and I'm thinking of 20 commits like updating a bunch of related packages all at once, which would only ping a couple codeowners
<lukegb> Maybe a <5 commit or <2 "groups" of codeowners cap then, with an explicit "yeah just ping everyone" lever?
<symphorien[m]> How about adding a check to the PR template "this PR only contains my commits" or something lime that?
<symphorien[m]> It's not automated but easy to do
<lukegb> It doesn't really have to be perfect, just handle the main case imo :P
<abathur> siraben: if the time from 90->100 stayed fairly stable, somewhere out around 2.3-2.5y I guess
<andi-> nobody cares about the PR checkboxes..
<siraben> abathur: I see.
<andi-> If we do not enforce it nothing will change
<siraben> Hopefully we can get people to use nixpkgs-review
<siraben> I love that
<andi-> that stil isn't a review. That is just *building* packages.
<siraben> Right.
AlwaysLivid has quit [Read error: Connection reset by peer]
AlwaysLivid has joined #nixos-dev
<lukegb> nixpkgs-review mostly facilitates reviews, and sometimes it just drops you into a shell where nothing works because it's installed several mutually-exclusive packages
<abathur> siraben: if the time dropped by 10% per 10k, more like 1.5? :)
<infinisil> gchristensen: Not sure how you managed to make that bnixos.org :P
<gchristensen> lol babyhands
jonringer has joined #nixos-dev
<abathur> gchristensen: icymi, the resholve PR (#85827) is ~available for review, bikeshedding, etc.
<{^_^}> https://github.com/NixOS/nixpkgs/pull/85827 (by abathur, 34 weeks ago, open): resholve: init at 0.1.1
<gchristensen> > 34 weeks ago
<{^_^}> attempt to call something which is not a function but an integer, at (string):452:1
<gchristensen> wooo!
<abathur> the latest commit is ~tentative, but if the approach there is confirmed I think it's ready
<ryantm> I've definitely needed resholve before. Looks cool.
<gchristensen> it is really great, ryantm, I use it a lot
<abathur> gchristensen: btw, a little under-inspired with how I modeled it in Nix (i.e., `"<abspath>" = true;` in the fix set), but one of the directives --fix supports is an abspath that it should treat as a bare invocation to resolve
<gchristensen> oooh
<ryantm> abathur do you have a suggested commit of nixpkgs to use when running "nix-shell" with your project? My machine's nixpkgs has issues.
<abathur> not off the top of my head, though it's been running against nixos-unstable in CI
<abathur> it's also, eh, if you want the command-line program itself like `nix-shell -p resholve.resholve` :[
<abathur> fwiw my nix-info says `channels(abathur): "darwin, nixpkgs-21.03pre243895.72b9660dc18"`; that may be somewhat dated--I don't recall when I last ran it
<sphalerite> I always imagine "resholve" as Sean Connery pronouncing resolve.
<abathur> yes
<abathur> it is the way :)
<sphalerite> perfect
rajivr has quit [Quit: Connection closed for inactivity]
FRidh has quit [Quit: Konversation terminated!]
AlwaysLivid has quit [Remote host closed the connection]
mkaito has joined #nixos-dev
mkaito has joined #nixos-dev
<supersandro2000> siraben: I try to take a look at them in the next days
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev