sphalerite changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 19.03 released! https://discourse.nixos.org/t/nixos-19-03-release/2652 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html https://r13y.com | 19.03 RMs: samueldr,sphalerite | https://logs.nix.samueldr.com/nixos-dev
drakonis has quit [Quit: WeeChat 2.4]
evanjs- has quit [Ping timeout: 258 seconds]
drakonis has joined #nixos-dev
_ris has quit [Ping timeout: 258 seconds]
<infinisil> Oh god, I don't know if I have the motivation to do another review for #53416
<{^_^}> https://github.com/NixOS/nixpkgs/pull/53416 (by mmai, 35 weeks ago, open): funkwhale: init at 0.19.1
<infinisil> This was the second huge review I've done now, and while it was in a better state now, it's still pretty bad
obadz has quit [Ping timeout: 246 seconds]
obadz has joined #nixos-dev
<disasm> zimbatm: it will be first thing EST time tomorrow
<disasm> I'm checking up on the staging-next status now
<disasm> does anyone here have permission to kill hydra jobs?
Taneb has quit [Quit: I seem to have stopped.]
<disasm> FRidh: I'm really hoping we can merge that tomorrow morning first thing.
drakonis has quit [Quit: WeeChat 2.4]
v is now known as alyx
justanotheruser has quit [Ping timeout: 268 seconds]
phreedom_ has joined #nixos-dev
phreedom has quit [Ping timeout: 260 seconds]
justanotheruser has joined #nixos-dev
Guest71254 has quit [Ping timeout: 245 seconds]
orivej has quit [Ping timeout: 246 seconds]
aszlig has quit [Quit: Kerneling down for reboot NOW.]
aszlig has joined #nixos-dev
johanot has joined #nixos-dev
pie_ has joined #nixos-dev
<domenkozar[m]> hmm, ofborg is not responding to my comments
<domenkozar[m]> disasm: any objections merging https://github.com/NixOS/nixpkgs/pull/58715
<{^_^}> #58715 (by booxter, 22 weeks ago, open): Bump patchelf and patchelfUnstable to 0.10
<FRidh> domenkozar[m]: are there specific fixes we need?
<domenkozar[m]> patchelf is currently lagging behind and there are a bunch of fixes for nixpkgs in that release
<domenkozar[m]> I don't know the exact details, but it should be in the changelog
<FRidh> disasm: https://github.com/NixOS/nixpkgs/pull/68339 could go in. THere is a bit of a building queue but not that bad
<{^_^}> #68339 (by FRidh, 1 hour ago, open): Staging next with systemd 243
orivej has joined #nixos-dev
orivej has quit [Ping timeout: 258 seconds]
Taneb has joined #nixos-dev
__monty__ has joined #nixos-dev
orivej has joined #nixos-dev
psyanticy has joined #nixos-dev
NinjaTrappeur has quit [Quit: WeeChat 2.5]
NinjaTrappeur has joined #nixos-dev
<worldofpeace> infinisil: I did a review on that PR after reading that 😄
<worldofpeace> no idea what was going on with the indentation there though :D
<FRidh> infinisil: worldofpeace: it's improving and a lot of effort has gone in it already. To me this seems like a good example of a service that could be outside of nixpkgs though. Just look at the python deps it has.
<FRidh> especially the overrides
<worldofpeace> Yeah I do understand that. In no means undercrediting the author, they seem to be very responsive to changes which is a good thing.
<worldofpeace> Problem with directing people how to make a service outside of nixpkgs is there's no really clear way to do that. So most people attempt to make a submission to nixpkgs
<worldofpeace> (though I wonder what the ❄️ will make that look like)
<FRidh> yep
orivej has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-dev
evanjs- has joined #nixos-dev
aanderse has quit [Quit: ZNC 1.7.3 - https://znc.in]
aanderse has joined #nixos-dev
<aminechikhaoui> Hey all, should we look at https://github.com/NixOS/nixpkgs/pull/61974 again since the release is getting close, I'd like to see that merged to drive more improvements to vulnix :)
<{^_^}> #61974 (by AmineChikhaoui, 15 weeks ago, open): RFC: introduce a patches file in <pkg>/nix-support/
<niksnut> aminechikhaoui: IMHO you should use nix-store -qd instead
<niksnut> replicating (part of) the dependency graph in the output in an ad hoc way is not the way to go IMHO
<aminechikhaoui> niksnut the issue is that derivations aren't always available especially when store paths are substituted from a binary cache
<niksnut> well, that's your problem right there :-)
justanotheruser has quit [Ping timeout: 244 seconds]
<aminechikhaoui> is it ? :) I don't think derivations should be assumed to be present in a server
<niksnut> well, if you want to inspect the build-time dependency graph, you have to make sure it doesn't get GC'ed
<infinisil> worldofpeace: NUR does support nixos modules
<niksnut> damn, this shit scares me: https://github.com/NixOS/nixpkgs/pull/57123
<{^_^}> #57123 (by oxij, 26 weeks ago, open): Typed `nixpkgs.config` married to NixOS
<niksnut> I have no idea whatsoever what this is supposed to do
<niksnut> though I did learn from it that Nixpkgs now has a "mkMassRebuild" function, whatever the hell that means
<niksnut> we should have an embargo on changes to the module system
<niksnut> or nixpkgs/lib in general
<worldofpeace> infinisil: NUR != nix ?
<infinisil> worldofpeace: I mean that people can use NUR to make a service outside of nixpkgs, while still publishing it for others
<infinisil> (not sure what you're asking with NUR != nix)
<worldofpeace> niksnut: Don't you think it's unreasonable to prohibit changes? How about redirection to what's being worked on internally, so as to avoid conflicts with that work?
<infinisil> niksnut: Ah regarding that PR
<infinisil> The basic idea is really what the title says, but oxij has included some more weird parts
<infinisil> And part of the changes were committed directly to master from a previous PR.. like the mkMassRebuild thing
<infinisil> Which I'm not a fan of at all (the fact that it was committed to master)
<worldofpeace> infinisil: Yeah NUR is an option and is already useful. I was meaning that, user wise, the path to do this shouldn't just be nixpkgs, and NUR functionality isn't within nix
<niksnut> urgh
<niksnut> making nixpkgs use the module system should really be done via an RFC
FRidh has quit [Ping timeout: 258 seconds]
<worldofpeace> 👍️ to that
<infinisil> Maybe yeah. But I do like this change and I don't think it would be very controversial, it makes a lot of sense to do
<infinisil> And the RFC process takes a really long time, so I'd be fine with this going through a well-reviewed (and not pushed to master!) PR
FRidh has joined #nixos-dev
<niksnut> it is controversial because we don't know what an ideal module-system-based Nixpkgs would look like
<niksnut> and introducing such changes now means we're stuck with them forever
<infinisil> Well it's only the config of nixpkgs (all of nixpkgs might be using the module system for package definitions as well)
<niksnut> also names like 'mkMassRebuild' are super-ugly
<niksnut> or the use of 'removeAttrs' to pass function arguments
<infinisil> Those are only used locally as helpers at least
FRidh has quit [Ping timeout: 258 seconds]
asymmetric has quit [Quit: Peace.]
FRidh has joined #nixos-dev
drakonis has joined #nixos-dev
justanotheruser has joined #nixos-dev
johanot has quit [Quit: WeeChat 2.4]
evanjs| has joined #nixos-dev
asymmetric has joined #nixos-dev
evanjs^ has joined #nixos-dev
evanjs^ has quit [Read error: Connection reset by peer]
evanjs^ has joined #nixos-dev
evanjs| has quit [Ping timeout: 268 seconds]
__monty__ has quit [Quit: leaving]
johnny101 has quit [Quit: Konversation terminated!]
<disasm> 19.09 release PR for nixos-org to get channel: https://github.com/NixOS/nixos-org-configurations/pull/88
<{^_^}> nixos-org-configurations#88 (by disassembler, 36 seconds ago, open): 19.09 channel addition
__monty__ has joined #nixos-dev
__monty__ has quit [Client Quit]
__monty__ has joined #nixos-dev
asymmetric has quit [Ping timeout: 245 seconds]
evanjs has quit [Quit: ZNC 1.7.4 - https://znc.in]
evanjs has joined #nixos-dev
evanjs- has quit [Quit: ZNC 1.7.4 - https://znc.in]
evanjs- has joined #nixos-dev
__monty__ has quit [Quit: Restarting irssi for sasl-ification]
justanotheruser has quit [Ping timeout: 252 seconds]
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-dev
evanjs^ has quit [Ping timeout: 244 seconds]
evanjs| has joined #nixos-dev
aanderse has quit [Quit: ZNC 1.7.3 - https://znc.in]
justanotheruser has joined #nixos-dev
aanderse has joined #nixos-dev
<disasm> anyone around that has permission to create hydra jobsets?
<disasm> niksnut: ^^
evanjs has quit [Ping timeout: 244 seconds]
evanjs- has quit [Quit: ZNC 1.7.4 - https://znc.in]
<aminechikhaoui> disasm I guess you need a clone of release-19.03 -> release-19.09 with stableBranch = false ?
<{^_^}> #68358 (by ivan, 19 minutes ago, open): pythonPackages.lmdb: fix build
<globin> disasm: o/
evanjs has joined #nixos-dev
<worldofpeace> ivan: ZHF before the ZHF is opened :P
<ivan> what's ZHF
<ivan> oh Zero Hydra Failures
evanjs has quit [Client Quit]
<ivan> thanks
evanjs has joined #nixos-dev
<globin> disasm, sphalerite: feel free to ping me of you need a staging-19.09
<sphalerite> yes please!
<sphalerite> disasm is just pushing the branch now
<globin> really? I'd try to avoid mass rebuilds as long as possible ;)
<sphalerite> good to have for when we need it though
<disasm> staging-19.09 branch created
<globin> hm okay
<ivan> is release-19.09 going to get any more merges from master?
<sphalerite> no
<disasm> I think we've narrowed down the name to mandrill, macaw and mammoth :)
<globin> ah macaw is nice!
<disasm> and markhor :)
<samueldr> no mouse?
<Taneb> I think any of those would be nice! :D
<disasm> markhor is the winner I think
<samueldr> (joking btw, it's up to you)
<sphalerite> mouse is too normal :p
<samueldr> imagine a user searching for mouse issues in NixOS
<disasm> haha :)
<globin> using the Urdu spelling? مارخور :D
<Taneb> How about "macaque"? (because you can never have too many options)
<worldofpeace> ivan: backports are possible when appropriate
<globin> (subject to disasm's and sphalerite's judgement) ^
<sphalerite> disasm's, I already got to name Loris ;)
<globin> first eval of 19.09-small: https://hydra.nixos.org/eval/1541507
<globin> sphalerite: I meant the backporting
<sphalerite> aah right
johnny101 has joined #nixos-dev
<ivan> worldofpeace: I am confused, is there something wrong with https://github.com/NixOS/nixpkgs/pull/68359 that would be fixed by me cherry-picking
<{^_^}> #68359 (by ivan, 9 minutes ago, open): [19.09] pythonPackages.lmdb: fix build
<worldofpeace> ivan: the guidelines on backports say to always use git cherry-pick -xe
<ivan> my commit or your merge?
<worldofpeace> you should just git reset @~1 --hard and cherry-pick again. force push
justanotheruser has quit [Ping timeout: 264 seconds]
<ivan> ah it's just the (cherry picked from ...) message I guess, thanks
<worldofpeace> will keep the link handy since the following months... will be linking it a lot :D
evanjs- has joined #nixos-dev
justanotheruser has joined #nixos-dev
<{^_^}> #68361 (by disassembler, 16 seconds ago, open): Zero Hydra Failures: 19.09 edition
<ivan> disasm: you linked to release-19.03
justanotheruser has quit [Ping timeout: 264 seconds]
<disasm> ivan: thanks :)
evanjs- has quit [Ping timeout: 245 seconds]
orivej has quit [Ping timeout: 268 seconds]
<worldofpeace> Maybe it's a good idea to make a "call" to commiters who are available to help out with ZHF
justanotheruser has joined #nixos-dev
<qyliss> A post on the Discourse could be good. (I haven't seen one, at least)
evanjs| has quit [Quit: ZNC 1.7.4 - https://znc.in]
<qyliss> The one linked above is not one I would read, going by the subject, but one about looking for people to help with ZHF would be
<ddima> disasm: whats usually the time it takes for hydra to do a full build? right now all of the tasks in the linked jobset are just queued, so just want to know when its worth checking back.
evanjs- has joined #nixos-dev
<disasm> ddima: probably a dayish?
<qyliss> does that mean it's too early to be able to easily find packages to fix?
<samueldr> qyliss: in theory the last unstable eval applies
<ddima> disasm: thanks
<qyliss> ah, course
<samueldr> oh, I just remembered I have that script to make reports for ZHF
<samueldr> ddima: yes
<ddima> thanks. I've not navigated around the nixos/nixpkgs hydra that much yet.
evanjs- has quit [Client Quit]
<srhb> ddima: I just ran samueldrs report-generator on the latest complete trunk-combined fwiw: https://gist.github.com/srhb/02354d85fa4f94b2ad821514f23b016f :)
<samueldr> a tip that may be helpful, trunk is basically the name of master under SVN
<samueldr> so when you see trunk, it basically means master
<samueldr> so yeah, it then means unstable :)
<samueldr> 33 aarch64 issues?
<samueldr> did the script break?
<srhb> Yeah, seems weird..
<srhb> Looking at it now..
<samueldr> there are only tests in that list
drakonis has quit [Ping timeout: 250 seconds]
<ddima> srhb: thanks. might be worth doing this again for the issue disam posted once the builds have run - to help others more easily navigate :)
<samueldr> OH, right, it won't have a full aarch64 coverage since it's only limited support
<samueldr> srhb: ^
<srhb> ddima: I promised to do as much for this round of ZHF, yeah :)
<srhb> Just waiting for the second release-19.09 run before doing that.
evanjs- has joined #nixos-dev
<globin> disasm, sphalerite: that is the script for ZHF we used to use: maintainers/scripts/hydra-eval-failures.py
<samueldr> heh, looks like I implemented mostly the same idea in mine
evanjs- has quit [Ping timeout: 246 seconds]
__monty__ has joined #nixos-dev
__monty__ has joined #nixos-dev
__monty__ has quit [Changing host]
__monty__ has quit [Quit: leaving]
__monty__ has joined #nixos-dev
__monty__ has quit [Client Quit]
__monty__ has joined #nixos-dev
__monty__ has quit [Client Quit]
__monty__ has joined #nixos-dev
orivej has joined #nixos-dev
justanotheruser has quit [Ping timeout: 252 seconds]
justanotheruser has joined #nixos-dev
ixxie has joined #nixos-dev
<ekleog> Profpatsch: (fup from #nixos) sounds good to me, will do the backport then :)
<Profpatsch> nice
drakonis has joined #nixos-dev
orivej has quit [Ping timeout: 244 seconds]
FRidh2 has joined #nixos-dev
FRidh2 has quit [Quit: Konversation terminated!]
FRidh2 has joined #nixos-dev
orivej has joined #nixos-dev
evanjs- has joined #nixos-dev
evanjs- has quit [Quit: ZNC 1.7.4 - https://znc.in]
evanjs- has joined #nixos-dev
evanjs- has quit [Client Quit]
evanjs- has joined #nixos-dev
evanjs has quit [Killed (barjavel.freenode.net (Nickname regained by services))]
evanjs- is now known as evanjs
evanjs- has joined #nixos-dev
justanotheruser has quit [Ping timeout: 250 seconds]
<worldofpeace> sphalerite disasm, I'd be interested in managing 20.03
<aminechikhaoui> globin man that's too close to the arabic word ماخور
<aminechikhaoui> :D
<samueldr> hmm, #68363 that's not a good use if stateVersion AFAIUI
<{^_^}> https://github.com/NixOS/nixpkgs/pull/68363 (by worldofpeace, 1 hour ago, merged): nixos/xterm: stateVersion disable by default
<samueldr> AFAIUI the same configuration, for two stateVersion, should stay compatible
<worldofpeace> ahh wait
<worldofpeace> it's not for xserver.enable since it returns true
<samueldr> here if I bringup a new machine with stateVersion 19.09, using the config I use on my 19.03 machine, things will not exactly be compatible
<worldofpeace> on just that condition
<drakonis> 19.09 released?
<samueldr> no
_ris has joined #nixos-dev
<worldofpeace> samueldr: was a quick hack. wasn't looking for merge so quickly
<worldofpeace> samueldr: My thing was, what do you do when you change a default that people rely on, and get them to migrate to explicitly using xterm.enable
<samueldr> yeah, worldofpeace, not trying to slap you :) looking in discussing this, I was hopeful others would hcime in
<samueldr> since, exactly, I'm not sure what's the best way to transition
<srhb> The easiest way would probably be a deprecation cycle with a rename of the xterm option.
<worldofpeace> so currently people expect xserver.enable to do the same as xterm.enable
<samueldr> could it be a trace on having only the xterm de/wm enabled urging the user to migrate to enabling something?
<srhb> Yes, though we need the (explicit, non-default) xsession alternative first. :)
<adisbladis> worldofpeace: Can I PM you?
<worldofpeace> adisbladis: always welcome :)
<samueldr> that something would likely be the xsession-based alternative lightly theorized
<srhb> Sounds good to me.
justanotheruser has joined #nixos-dev
aristid has joined #nixos-dev
<adisbladis> Oh this was just what I wanted to PM worldofpeace about :)
<adisbladis> I was suggesting we create an `xsession` that does pretty much what `xterm` does now
<adisbladis> Except by default it will show you a message saying that you need to create ~/.xsession
<samueldr> :)
<samueldr> so I guess that means we're pretty much in agreement with the way to go forward
<adisbladis> samueldr: :)
<adisbladis> Then I'll go ahead
<worldofpeace> ✨
<worldofpeace> I'm not sure about the option name, but I think the implementation sounds correct
<samueldr> xsession.enable instead of xterm.enable would likely describe the session type appropriately
<worldofpeace> My only question; what's to be done for 19.09?
<adisbladis> Let me push a PR, I'll only be a few minutes, then we'll discuss from there.
<adisbladis> worldofpeace: samueldr: https://github.com/NixOS/nixpkgs/pull/68371
<{^_^}> #68371 (by adisbladis, 11 seconds ago, open): nixos/xterm: Replace by xsession
<worldofpeace> srhb: ^
lopsided98 has quit [Quit: Disconnected]
* samueldr checks
lopsided98 has joined #nixos-dev
lopsided98 has quit [Client Quit]
lopsided98 has joined #nixos-dev
<FRidh2> we currently still depend on python2 when building some core packages. We should get rid of that dependency and I have a PR for that, though it doesn't cover darwin. It's a bit late, but I do not expect any regressions because of it https://github.com/NixOS/nixpkgs/pull/63174
<{^_^}> #63174 (by FRidh, 12 weeks ago, open): libxml2 and libxslt: build against python3 by default
orivej has quit [Ping timeout: 244 seconds]
andi- has quit [Quit: WeeChat 2.6]
andi- has joined #nixos-dev
<disasm> under 1K more builds to go! https://hydra.nixos.org/jobset/nixos/release-19.09
<disasm> worldofpeace: awesome :) will you be at nixcon?
<disasm> globin: guess my first task is to debug why that script doesn't work? :) error: syntax error, unexpected $undefined, at (string):1:94
<disasm> ah, change to maintainer-list format I think
<worldofpeace> disasm: No unfortunately, my travel schedule got filled before I knew nixcon's date
andi- has quit [Remote host closed the connection]
<worldofpeace> but going forward, at least for the position, I should be pretty flexible time wise
andi- has joined #nixos-dev
orivej has joined #nixos-dev
<globin> disasm: spunds likely, haven't used it in ~2 years
psyanticy has quit [Quit: Connection closed for inactivity]
<disasm> globin: k, I'll hack on that in the coming few days
<disasm> traveling tomorrow so maybe can hack on it on the plane :)
FRidh2 has quit [Quit: Konversation terminated!]
<worldofpeace> I think samueldr has a script that should still work :)
<samueldr> it does
<samueldr> srhb ran it earlier!
<samueldr> [12:09:28] <srhb> ddima: I just ran samueldrs report-generator on the latest complete trunk-combined fwiw: https://gist.github.com/srhb/02354d85fa4f94b2ad821514f23b016f :)
<samueldr> though I don't know what features the other script has this one doesn't (and the other way around too)
orivej has quit [Read error: Connection reset by peer]
orivej has joined #nixos-dev
<drakonis> the fresher images are on hydra, right?
<drakonis> i'd like to fetch a 19.09 image from unstable
<drakonis> as i need a newer kernel out of the box
<samueldr> 19.09 won't help you outright, you'll need a different image still, though yeah on hydra
<samueldr> though I don't think 19.09 has had a complete successful build yet
<drakonis> gotta get my new lappy to work where others have failed
<drakonis> the image is downloading so slowly its causing me physical pain
aristid has quit [Quit: WeeChat 2.5]
aristid has joined #nixos-dev
<drakonis> okay, that was not a good idea.
<drakonis> its going to take anhour to finish
ixxie has quit [Ping timeout: 244 seconds]
<samueldr> you could also nix-build it locally
<samueldr> it should be quicker
<samueldr> or uh
<samueldr> even better
<samueldr> nix-store --realise it
<samueldr> the reason it's slow AFAIUI is that when you download through hydra it goes through the one hydra server instance rather than give you a cdn download location
drakonis has quit [Ping timeout: 245 seconds]
evanjs has quit [Quit: ZNC 1.7.4 - https://znc.in]
evanjs has joined #nixos-dev
<globin> disasm, samueldr: would nonetheless be nice to have a working script in maintainers/scripts
<disasm> samueldr: primarily, the biggest benefit I think to globin script in the repo is it pings the maintainers for broken packages.
<samueldr> right, that's what I gathered from the quick overview
<disasm> globin: yeah, I'll get it fixed and maybe get it added to CI :)
<samueldr> worldofpeace: do you know if my assumption is right: the session a user selects in lightdm (and other DMs?) is saved under .dmrc to be re-used
<samueldr> if so, would the spurious issues with accidentally getting in the xterm session come from .dmrc having a session not being currently active?
<worldofpeace> samueldr: Not since I've added that patch to lightdm that ended that impurity :P But a similar thing happens with accountsservice just with dbus
<samueldr> what does your patch does?
<samueldr> (a correct answer could be linking to the PR/commit/file)
<samueldr> I'm curious if it breaks the two users using different sessions use case
<samueldr> (only speculating at very high level, I have no reason to think it would)
<worldofpeace> Though I expect any lightdm greeter to discard sessions that don't exist anymore
<worldofpeace> including ones that were previously used
<samueldr> if I understand right, there's still one mechanism to save the user's session statefully, right?
<samueldr> yeah, I expect it, too, to discard sessions, but which one would it fallback to? that's my thinking
<worldofpeace> The issue I mentioned with the new upstream sessions is that session.default has no value, so maybe because xterm is/was default it gets selected
<worldofpeace> samueldr: I'm not sure if I've seen any other distro have a feature like this, it's interesting
<samueldr> we are in an interesting position though
drakonis has joined #nixos-dev
<jtojnar> worldofpeace: did we want to do any changes to the GNOME docs before merging it?
jtojnar has quit [Quit: jtojnar]
jtojnar has joined #nixos-dev
drakonis has quit [Ping timeout: 246 seconds]
<worldofpeace> jtojnar: Think we had some other todos. Personally I think time for docs might run a bit thin soon so we should probably just merge and backport it
<jtojnar> 👍️
<jtojnar> how did I miss this https://github.com/NixOS/nixpkgs/pull/68020
<{^_^}> #68020 (by grahamc, 6 days ago, open): Vacation PR: multi-paged, styled, searchable docs with wrapper tooling and epubs for NixOS and Nixpkgs
<worldofpeace> that pr evokes a sense of bliss :D I'd be happy to link that manual to someone
<jtojnar> it fixed https://github.com/NixOS/nixpkgs/issues/68199 even before I opened it
<{^_^}> #68199 (by jtojnar, 3 days ago, open): Harmonize docbook build experience
__monty__ has quit [Quit: leaving]