worldofpeace changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 20.09 Nightingale ✨ https://discourse.nixos.org/t/nixos-20-09-release/9668 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 20.09 RMs: worldofpeace, jonringer | https://logs.nix.samueldr.com/nixos-dev
bennofs__ has joined #nixos-dev
bennofs_ has quit [Ping timeout: 268 seconds]
cole-h has quit [Ping timeout: 265 seconds]
<qyliss> Ericson2314++ for rfcs#92
<{^_^}> Ericson2314's karma got increased to 16, it's a crit!
<{^_^}> https://github.com/NixOS/rfcs/pull/92 (by Ericson2314, 2 weeks ago, open): [RFC 0092] Computed derivations and hydra-safe IFD
<Ericson2314> :)
<drakonis> it is beautiful.
abathur has joined #nixos-dev
<drakonis> how long would it take to be available on nixpkgs?
<infinisil> hexa-: noted
<drakonis> its a very excellent rfc
<hexa-> no hurry was meant seriously, we have like 9 more days :)
<hexa-> heck, we could backport it
rajivr has joined #nixos-dev
copumpkin has quit [Quit: Hmmm]
tomberek has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-dev
puck has quit [Ping timeout: 246 seconds]
puck has joined #nixos-dev
justan0theruser has joined #nixos-dev
justanotheruser has quit [Ping timeout: 250 seconds]
pmy has quit [Read error: Connection reset by peer]
pmy has joined #nixos-dev
Jackneill has quit [Remote host closed the connection]
justanotheruser has joined #nixos-dev
justan0theruser has quit [Ping timeout: 250 seconds]
jonringer has quit [Remote host closed the connection]
jonringer has joined #nixos-dev
<siraben> Who is working on ZHF for darwin?
<siraben> Oh mjlbach re: #118014, I could close the PR for you to properly package pyre
<{^_^}> https://github.com/NixOS/nixpkgs/pull/118014 (by siraben, 6 weeks ago, open): Revert "pyre: remove"
<mjlbach> I probably won’t get around to it for another month or so so no rush
<siraben> Ok.
copumpkin has joined #nixos-dev
<siraben> How could I tell if my PR to staging #117451 is going to break things?
<{^_^}> https://github.com/NixOS/nixpkgs/pull/117451 (by siraben, 6 weeks ago, open): treewide: use stdenvNoCC when not building
<siraben> there's way too many rebuilds
<siraben> I'm working under the assumption that `dontBuild = true` and no references to `stdenv.cc.cc` imply that it's OK to rewrite to `stdenvNoCC.mkDerivation`
<hexa-> python39 doesn't build on darwin on staging-next
<hexa-> affects ~3.5k jobs
justanotheruser has quit [Ping timeout: 260 seconds]
cole-h has joined #nixos-dev
Jackneill has joined #nixos-dev
cole-h has quit [Ping timeout: 260 seconds]
orivej has quit [Ping timeout: 252 seconds]
Reventlov has joined #nixos-dev
jonringer has quit [Ping timeout: 245 seconds]
tomberek has joined #nixos-dev
evanjs has quit [Read error: Connection reset by peer]
evanjs has joined #nixos-dev
sphalerite has quit [Quit: WeeChat 2.9]
sphalerite has joined #nixos-dev
philipp has quit [Remote host closed the connection]
philipp has joined #nixos-dev
<qyliss> anyone want to review #122390?
<{^_^}> https://github.com/NixOS/nixpkgs/pull/122390 (by alyssais, 2 days ago, open): treewide: remove explicit enableParallelBuilding = true in Meson builds
Synthetica has joined #nixos-dev
copumpkin has quit [Quit: Hmmm]
__monty__ has joined #nixos-dev
bpye has joined #nixos-dev
devhell has joined #nixos-dev
<gchristensen> I've (programmatically) looked at that field before as a hint, I guess in the future looking to see if it has meson would be needed to be complete
<qyliss> gchristensen: well that's already the case
<gchristensen> yeah of course
<gchristensen> lgtm :)
<qyliss> rad
<Mic92> I am pleasantly surprised that the number of not-building packages in unstable seems to decrease with every release.
orivej has joined #nixos-dev
<gchristensen> enableParallelBuilding should really be a trinary though
<MichaelRaskin> It's ternary.
<MichaelRaskin> (The should part, the «is» part is sadly binary)
<jtojnar> qyliss++
<{^_^}> qyliss's karma got increased to 145
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #nixos-dev
jonringer has joined #nixos-dev
orivej has quit [Ping timeout: 265 seconds]
mkaito has joined #nixos-dev
mkaito has joined #nixos-dev
mkaito has quit [Changing host]
<siraben> qyliss: this was done manually right?
<qyliss> siraben: automatically with grep + sed
<siraben> qyliss: ah, what of the commits?
<qyliss> oh those were manual, because I wanted to check each one
<siraben> oh I see
<qyliss> and also had to correct cases where there were blank lines around enableParallelBuilding
<qyliss> which I didn't account for in sed
<siraben> it's been an annoyance in some treewides that bisection is hard so I'd like to find a way split changes into multiple commits automatically
<siraben> by the way, do you know if it's possible to automate fetchurl + github.com → fetchFromGitHub?
<qyliss> that's probably regular enough for regular expressions
<qyliss> at least for most cases
<siraben> the issue would be getting the new hash
<siraben> and version out, there's surprising ways in which people use fetchurl and github together
<siraben> sometimes it's for entire tarballs, sometimes it's for individual files from a specific branch
<qyliss> siraben: hash should be identical in the simple cases
<qyliss> and a regex probably wouldn't match the complex ones
MichaelRaskin has quit [Read error: No route to host]
rj has joined #nixos-dev
mkaito has quit [Quit: WeeChat 3.1]
copumpkin has joined #nixos-dev
rj has quit [Remote host closed the connection]
rj has joined #nixos-dev
<sterni> qyliss: no, not at all since it means fetchurl -> fetchzip
<sterni> fetchzip -> fetchFromGitHub is easy as long as you make sure not to touch anything with fetchSubmodules = true, leaveDotGit = true or deepClone = true
MichaelRaskin has joined #nixos-dev
<qyliss> oh, my mistake
Jackneill has quit [Remote host closed the connection]
rj has quit [Ping timeout: 240 seconds]
AlwaysLivid has joined #nixos-dev
rj has joined #nixos-dev
jefferai has quit [Ping timeout: 246 seconds]
jefferai has joined #nixos-dev
justanotheruser has joined #nixos-dev
rj has quit [Ping timeout: 240 seconds]
rj has joined #nixos-dev
cole-h has joined #nixos-dev
orivej has joined #nixos-dev
malbx has joined #nixos-dev
rj has quit [Ping timeout: 240 seconds]
pmy has quit [Read error: Connection reset by peer]
pmy has joined #nixos-dev
rj has joined #nixos-dev
vikanezrimaya has quit [Quit: Connection closed]
<maralorn> Why did the r-rmcgibbo bot test this PR https://github.com/NixOS/nixpkgs/pull/122719 but not all our previous haskell-updates PRs? Also what can we do to not have that happen?
<{^_^}> #122719 (by cdepillabout, 4 hours ago, open): haskell: update package set
devhell has quit [Quit: zzz]
<rmcgibbo[m]> maralorn: I don't know. It's supposed to be skipped. The code is here: https://github.com/rmcgibbo/r-rmcgibbo/blob/master/nixbot-frontend/src/nixbot_frontend/nixpkgs.py#L178-L187
<rmcgibbo[m]> Can you file an issue on rmcgibbo/r-rmcgibbo
<maralorn> Uh, funny. We have an extra rule.^^
<maralorn> rmcgibbo: Maybe because it was first a draft and then ready for review?
<rmcgibbo[m]> ah, that rule is actually not right for what you want. it's checking for PRs into haskell-updates, but it's not skipping PRs from haskell-updates.
<rmcgibbo[m]> So your previous question: why did it not previously skip PR from haskell-updates targeting master? I have absolutely no idea.
<rmcgibbo[m]> I think the best thing would be to file a ticket for me on the bot's repo and let me know exactly what policy you prefer. I can have it skip PRs from haskell-updates, or to haskell-updates, or both, or use some other criterion.
qyliss has quit [Quit: bye]
<V> the real question is why is this not integrated into ofborg or opt-in
<rmcgibbo[m]> (1) it's not integrated into ofborg because that's a lot of work, i have a day job, and nobody else has stepped up to do it.
<rmcgibbo[m]> (2) it's not opt-in because nobody has ever suggested that to me before and that has never been discussed.
<V> Here's your suggestion
<rmcgibbo[m]> (3) it is opt out in the sense that you can add your github user name to https://github.com/rmcgibbo/r-rmcgibbo/blob/master/nixbot-backend/src/nixbot_backend/block_github_comment.py#L15-L28
qyliss has joined #nixos-dev
rj has quit [Ping timeout: 240 seconds]
<rmcgibbo[m]> my impression from the feedback i've received from others (https://discourse.nixos.org/t/update-on-r-rmcgibbo-bot-automatic-nixpkgs-review/12145 and elsewhere) is that it's better if it's on by default rather than opt-in, but i hear you. it might make sense to open a wider discussion on discourse or elsewhere if you want to pursue that. but if you find it particularly annoying on specifically your PRs, it's
<rmcgibbo[m]> straightforward to add a line to that "GH_USER_BLOCKLIST" above, just let me know (or file a PR).
rajivr has quit [Quit: Connection closed for inactivity]
rj has joined #nixos-dev
tomberek has quit [Quit: Connection closed]
rj has quit [Ping timeout: 240 seconds]
rj has joined #nixos-dev
rj has quit [Ping timeout: 240 seconds]
rj has joined #nixos-dev
Jackneill has joined #nixos-dev
rj has quit [Ping timeout: 240 seconds]
NinjaTrappeur has quit [Ping timeout: 276 seconds]
tokudan has quit [Remote host closed the connection]
tokudan has joined #nixos-dev
rj has joined #nixos-dev
NinjaTrappeur has joined #nixos-dev
NinjaTrappeur has quit [Ping timeout: 260 seconds]
rj has quit [Ping timeout: 240 seconds]
rj has joined #nixos-dev
NinjaTrappeur has joined #nixos-dev
abathur has quit [Quit: abathur]
philipp has quit [Ping timeout: 252 seconds]
philipp has joined #nixos-dev
cptchaos83 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
cptchaos83 has joined #nixos-dev
<drakonis> https://guix.gnu.org/en/blog/2020/grafts-continued/ regarding the ifd rfc, this seems like a valid next step for nix
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
supersandro2000 is now known as Guest24418
Guest24418 has quit [Killed (hitchcock.freenode.net (Nickname regained by services))]
supersandro2000 has joined #nixos-dev
__monty__ has quit [Quit: leaving]
tomberek has joined #nixos-dev
rj has quit [Quit: rj]