00:12
abathur has joined #nixos-dev
00:25
drakonis has quit [Quit: WeeChat 2.7.1]
00:28
evanjs has joined #nixos-dev
01:22
teto has quit [Quit: WeeChat 2.7.1]
01:27
drakonis has joined #nixos-dev
01:32
bhipple has quit [Ping timeout: 240 seconds]
01:34
bhipple has joined #nixos-dev
01:37
ixxie has quit [Ping timeout: 258 seconds]
01:39
<
{^_^} >
#67855 (by flokli, 26 weeks ago, merged): linux/kernel: enable QoS and/or fair queueing
01:42
<
genesis >
sorry flokli , not competant and no power.
01:43
<
flokli >
We might just default to it, like there
01:46
<
genesis >
i'd agree since a believe we have to put maximum option in the kernel by default
01:46
<
genesis >
but i'm of no help.
01:48
<
flokli >
I'll comment on the PR later, when back on a computer
02:03
drakonis has quit [Quit: WeeChat 2.7.1]
02:07
lovesegfault has joined #nixos-dev
02:09
lovesegfault has quit [Client Quit]
02:11
<
samueldr >
you're right, flokli, ah, right, I linked because I somehow thought it wasn't linked previously lol
02:12
lovesegfault has joined #nixos-dev
02:12
* samueldr
is now confused
02:12
<
flokli >
samueldr: anyhow, I think we should do that unconditionally, there's plenty of reasons to have this on armv7l as well
02:12
<
flokli >
Like done in that PR of mine for another kernel option
02:12
<
lovesegfault >
neovim is still borked
02:12
<
samueldr >
yes, that's what I meant
02:12
<
samueldr >
I somehow thought that NinjaTrappeur's PR wasn't linked, so I linked it to you
02:12
<
lovesegfault >
But I'll be honest I quite like running out of my nixpkgs fork :D
02:13
<
samueldr >
and yes, you're right, unconditionally enable, I was writing the comment already :)
02:16
<
samueldr >
gchristensen: I figure since you didn't involve me nothing is broken, except github being all weird?
02:34
<
cole-h >
Nothing in that image seems weird to me. Could be lack of experience, though.
02:36
<
samueldr >
the automatic push from a github action is showing up as if graham did it
02:40
<
gchristensen >
awesome
02:40
<
samueldr >
free contribution squares on your daily contribution grid!
02:40
<
cole-h >
That's the real reason I contribute to nixpkgs -- 1-2 line changes = free squares
04:07
justanotheruser has joined #nixos-dev
05:00
bhipple has quit [Remote host closed the connection]
05:02
lovesegfault has quit [Ping timeout: 256 seconds]
05:04
justanotheruser has quit [Quit: WeeChat 2.7.1]
05:25
justanotheruser has joined #nixos-dev
06:01
lovesegfault has joined #nixos-dev
06:02
<
lovesegfault >
Mic92: Hey hey, are you around?
06:08
abathur has quit [Ping timeout: 258 seconds]
06:11
<
lovesegfault >
Or: Can anyone explain me how nixpkgs-review's feature of automatically pruning the git worktree when I exit the shell work?
06:11
<
lovesegfault >
cc. gchristensen who knows all things
06:16
orivej has joined #nixos-dev
07:06
lovesegfault has quit [Quit: WeeChat 2.7.1]
07:28
cole-h has quit [Ping timeout: 256 seconds]
08:19
nvd is now known as Taneb
08:26
ixxie has joined #nixos-dev
08:55
<
NinjaTrappeur >
flokli samueldr: +1
10:26
__monty__ has joined #nixos-dev
10:29
__monty__ has quit [Client Quit]
10:33
__monty__ has joined #nixos-dev
11:10
ixxie has quit [Ping timeout: 255 seconds]
11:28
ixxie has joined #nixos-dev
11:48
__monty__ has quit [Quit: leaving]
11:49
__monty__ has joined #nixos-dev
14:04
abathur has joined #nixos-dev
14:39
myskran has joined #nixos-dev
14:40
abathur has quit [Ping timeout: 240 seconds]
14:53
<
genesis >
can please merge #75392
15:03
greizgh has quit [Quit: greizgh]
15:04
greizgh has joined #nixos-dev
15:21
bhipple has joined #nixos-dev
15:21
ixxie has quit [Ping timeout: 255 seconds]
15:22
<
{^_^} >
#81266 (by Frostman, 2 days ago, open): [20.03] go_1_14: init at 1.14 and switch to it (backport)
15:25
<
adisbladis >
worldofpeace: LGTM (provided everything builds).
15:25
<
adisbladis >
We should also drop Go 1.12 as only the two latest Go releases are supported.
15:33
<
worldofpeace >
genesis: But I don't understand, shouldn't you then PR that seperately and use the build infra we have in nixpkgs already?
15:33
<
genesis >
i just need to finish the magic detection part to merge the 2 extractType1
15:33
<
genesis >
no the build infra is based on a wrong idea, provides a FHS
15:34
myskran has quit [Ping timeout: 256 seconds]
15:34
<
genesis >
instead of manually provides the right dependancies.
15:37
abathur has joined #nixos-dev
15:38
<
worldofpeace >
genesis: ahh wait, do you mean you weren't using the build infra in nixpkgs for the expression pkgs/applications/networking/p2p/soulseekqt/default.nix ?
15:39
<
genesis >
i mean i don't use the /build-support/appimage/default.nix because it doesn't provide what we needs and make people use things we wouldn't like a complete FHS
15:40
<
genesis >
what people need is the desktop rewriting part and icon management, and of course the cold unsquashfs without patching and launching the appimage packer possibly broken.
15:44
<
genesis >
thanks for review.
15:49
<
genesis >
worldofpeace : do we want to downcase binary name when we have such SoulseekQt ?
15:50
<
genesis >
some did, other not, i've no opinion.
15:56
<
emily >
i'm a little confused, isn't soulseekqt already packaged?
15:59
<
genesis >
emily : it is, but i made change to provide a good example how to package appimage and as a step to improve the builtin
15:59
* emily
just uses nicotine-plus now to avoid the non-free software, personally, but is glad that someone is improving the soulseekqt packaging!
16:00
<
genesis >
i don't use soulseekqt, it just a random toy to work on appimage
16:00
<
genesis >
since i abandon appimage when i discover all our issues was solve by nix
16:00
<
genesis >
then i move on nix.
16:01
<
genesis >
and btw, this rebuild on the new qt will have good effect, i see less size bug in the UI.
16:02
<
genesis >
we have a good dependancies update effect on this.
16:19
cole-h has joined #nixos-dev
16:20
bennofs has quit [Quit: No Ping reply in 180 seconds.]
16:21
bennofs has joined #nixos-dev
16:31
phreedom has quit [Ping timeout: 240 seconds]
16:32
phreedom has joined #nixos-dev
16:33
drakonis has joined #nixos-dev
17:12
Jackneill has quit [Ping timeout: 255 seconds]
17:16
Jackneill has joined #nixos-dev
17:36
drakonis has quit [Quit: WeeChat 2.7.1]
18:31
<
genesis >
and avoid licence issue.
18:32
<
emily >
interesting
18:32
<
genesis >
( i'd mailed and asked without answer to solve soulseekqt case)
18:34
<
genesis >
because the main point packaging undistributable is that we force user to build it, so it increase the need of quality packaging.
18:37
<
genesis >
since i made soulseekqt as a reference, i like it stand quickly in nixpkgs.
18:39
<
genesis >
but i misreading the licence
18:39
<
genesis >
it allows to modify it.
18:40
<
genesis >
there is a linux exception.
18:40
<
genesis >
good point for them.
18:42
bhipple has quit [Ping timeout: 240 seconds]
18:44
justanotheruser has quit [Ping timeout: 256 seconds]
18:52
justanotheruser has joined #nixos-dev
19:03
abathur has quit [Read error: Connection reset by peer]
19:04
lovesegfault has joined #nixos-dev
19:09
lovesegfault has quit [Client Quit]
19:11
ChanServ has quit [shutting down]
19:18
ChanServ has joined #nixos-dev
22:05
<
LnL >
urgh I'm kind of stuck with a scoping issue in the stdenv
22:07
<
LnL >
any ideas on how to fix something like this without adding details from foo to generic?
22:33
drakonis has joined #nixos-dev
22:52
__monty__ has quit [Quit: leaving]
23:34
bhipple has joined #nixos-dev
23:41
drakonis has quit [Ping timeout: 240 seconds]
23:44
drakonis has joined #nixos-dev
23:52
bhipple has quit [Ping timeout: 258 seconds]
23:54
bhipple has joined #nixos-dev