worldofpeace_ changed the topic of #nixos-dev to: #nixos-dev NixOS Development (#nixos for questions) | NixOS 20.03 BETA Announced https://discourse.nixos.org/t/nixos-20-03-beta/5935 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 19.09 RMs: disasm, sphalerite; 20.03: worldofpeace, disasm | https://logs.nix.samueldr.com/nixos-dev
abathur has joined #nixos-dev
drakonis has quit [Quit: WeeChat 2.7.1]
evanjs has quit [Quit: ZNC 1.7.5 - https://znc.in]
evanjs has joined #nixos-dev
teto has quit [Quit: WeeChat 2.7.1]
drakonis has joined #nixos-dev
bhipple has quit [Ping timeout: 240 seconds]
bhipple has joined #nixos-dev
ixxie has quit [Ping timeout: 258 seconds]
<flokli> NinjaTrappeur: samueldr: genesis: people run into these things ;-) https://github.com/NixOS/nixpkgs/pull/67855
<{^_^}> #67855 (by flokli, 26 weeks ago, merged): linux/kernel: enable QoS and/or fair queueing
<genesis> sorry flokli , not competant and no power.
<flokli> We might just default to it, like there
<genesis> i'd agree since a believe we have to put maximum option in the kernel by default
<genesis> but i'm of no help.
<flokli> I'll comment on the PR later, when back on a computer
drakonis has quit [Quit: WeeChat 2.7.1]
lovesegfault has joined #nixos-dev
lovesegfault has quit [Client Quit]
<samueldr> #81415
<{^_^}> https://github.com/NixOS/nixpkgs/pull/81415 (by NinjaTrappeur, 3 hours ago, open): linux: add policy routing config flag for aarch64
<samueldr> you're right, flokli, ah, right, I linked because I somehow thought it wasn't linked previously lol
<flokli> Wat
lovesegfault has joined #nixos-dev
* samueldr is now confused
<flokli> samueldr: anyhow, I think we should do that unconditionally, there's plenty of reasons to have this on armv7l as well
<samueldr> yes
<flokli> Like done in that PR of mine for another kernel option
<lovesegfault> neovim is still borked
<samueldr> yes, that's what I meant
<samueldr> I somehow thought that NinjaTrappeur's PR wasn't linked, so I linked it to you
<lovesegfault> But I'll be honest I quite like running out of my nixpkgs fork :D
<samueldr> and yes, you're right, unconditionally enable, I was writing the comment already :)
<flokli> Good good
<samueldr> uh, I wonder if github actions are weird or if something was up with the branch https://stuff.samueldr.com/screenshots/2020/02/20200229211449_zljhmdmufksom2i1ve.png
<samueldr> gchristensen: I figure since you didn't involve me nothing is broken, except github being all weird?
<cole-h> Nothing in that image seems weird to me. Could be lack of experience, though.
<samueldr> the automatic push from a github action is showing up as if graham did it
<cole-h> Ah
<gchristensen> lol
<gchristensen> awesome
<samueldr> free contribution squares on your daily contribution grid!
<cole-h> That's the real reason I contribute to nixpkgs -- 1-2 line changes = free squares
justanotheruser has joined #nixos-dev
bhipple has quit [Remote host closed the connection]
lovesegfault has quit [Ping timeout: 256 seconds]
justanotheruser has quit [Quit: WeeChat 2.7.1]
justanotheruser has joined #nixos-dev
lovesegfault has joined #nixos-dev
<lovesegfault> Mic92: Hey hey, are you around?
abathur has quit [Ping timeout: 258 seconds]
<lovesegfault> Or: Can anyone explain me how nixpkgs-review's feature of automatically pruning the git worktree when I exit the shell work?
<lovesegfault> cc. gchristensen who knows all things
orivej has joined #nixos-dev
lovesegfault has quit [Quit: WeeChat 2.7.1]
cole-h has quit [Ping timeout: 256 seconds]
nvd is now known as Taneb
ixxie has joined #nixos-dev
<NinjaTrappeur> flokli samueldr: +1
__monty__ has joined #nixos-dev
__monty__ has quit [Client Quit]
__monty__ has joined #nixos-dev
ixxie has quit [Ping timeout: 255 seconds]
ixxie has joined #nixos-dev
__monty__ has quit [Quit: leaving]
__monty__ has joined #nixos-dev
<Mic92> lovesegfault: I am using python's contextlib for that: https://github.com/Mic92/nixpkgs-review/blob/master/nixpkgs_review/builddir.py#L73
abathur has joined #nixos-dev
myskran has joined #nixos-dev
abathur has quit [Ping timeout: 240 seconds]
<genesis> can please merge #75392
<{^_^}> https://github.com/NixOS/nixpkgs/pull/75392 (by bignaux, 11 weeks ago, open): soulseekqt: fix icons, change unpack method, update homepage, more generic appimage handling
greizgh has quit [Quit: greizgh]
greizgh has joined #nixos-dev
bhipple has joined #nixos-dev
ixxie has quit [Ping timeout: 255 seconds]
<worldofpeace> Any golang people here believe this is a good choice https://github.com/NixOS/nixpkgs/pull/81266 "There are Go releases every half a year and we had 1.13 in 19.09, so, it’ll be great to have 1.14 in 20.03"
<{^_^}> #81266 (by Frostman, 2 days ago, open): [20.03] go_1_14: init at 1.14 and switch to it (backport)
<adisbladis> worldofpeace: LGTM (provided everything builds).
<adisbladis> We should also drop Go 1.12 as only the two latest Go releases are supported.
<worldofpeace> adisbladis: these comments and the below describe this https://github.com/NixOS/nixpkgs/pull/81071#pullrequestreview-365410404
<worldofpeace> genesis: But I don't understand, shouldn't you then PR that seperately and use the build infra we have in nixpkgs already?
<genesis> i just need to finish the magic detection part to merge the 2 extractType1
<genesis> no the build infra is based on a wrong idea, provides a FHS
myskran has quit [Ping timeout: 256 seconds]
<genesis> instead of manually provides the right dependancies.
abathur has joined #nixos-dev
<worldofpeace> genesis: ahh wait, do you mean you weren't using the build infra in nixpkgs for the expression pkgs/applications/networking/p2p/soulseekqt/default.nix ?
<genesis> i mean i don't use the /build-support/appimage/default.nix because it doesn't provide what we needs and make people use things we wouldn't like a complete FHS
<genesis> what people need is the desktop rewriting part and icon management, and of course the cold unsquashfs without patching and launching the appimage packer possibly broken.
<genesis> oh anyway i know this staff btw, https://github.com/AppImage/AppImageKit/graphs/contributors i'm still #3
<genesis> thanks for review.
<genesis> worldofpeace : do we want to downcase binary name when we have such SoulseekQt ?
<genesis> some did, other not, i've no opinion.
<emily> i'm a little confused, isn't soulseekqt already packaged?
<genesis> emily : it is, but i made change to provide a good example how to package appimage and as a step to improve the builtin
<emily> ah ok ^^
* emily just uses nicotine-plus now to avoid the non-free software, personally, but is glad that someone is improving the soulseekqt packaging!
<genesis> i don't use soulseekqt, it just a random toy to work on appimage
<genesis> since i abandon appimage when i discover all our issues was solve by nix
<genesis> then i move on nix.
<genesis> and btw, this rebuild on the new qt will have good effect, i see less size bug in the UI.
<genesis> we have a good dependancies update effect on this.
cole-h has joined #nixos-dev
bennofs has quit [Quit: No Ping reply in 180 seconds.]
bennofs has joined #nixos-dev
phreedom has quit [Ping timeout: 240 seconds]
phreedom has joined #nixos-dev
drakonis has joined #nixos-dev
Jackneill has quit [Ping timeout: 255 seconds]
Jackneill has joined #nixos-dev
drakonis has quit [Quit: WeeChat 2.7.1]
<genesis> and avoid licence issue.
<emily> interesting
<genesis> ( i'd mailed and asked without answer to solve soulseekqt case)
<genesis> because the main point packaging undistributable is that we force user to build it, so it increase the need of quality packaging.
<genesis> since i made soulseekqt as a reference, i like it stand quickly in nixpkgs.
<genesis> but i misreading the licence
<genesis> it allows to modify it.
<genesis> there is a linux exception.
<genesis> good point for them.
bhipple has quit [Ping timeout: 240 seconds]
justanotheruser has quit [Ping timeout: 256 seconds]
justanotheruser has joined #nixos-dev
abathur has quit [Read error: Connection reset by peer]
lovesegfault has joined #nixos-dev
lovesegfault has quit [Client Quit]
ChanServ has quit [shutting down]
ChanServ has joined #nixos-dev
<LnL> urgh I'm kind of stuck with a scoping issue in the stdenv
<LnL> any ideas on how to fix something like this without adding details from foo to generic?
drakonis has joined #nixos-dev
__monty__ has quit [Quit: leaving]
bhipple has joined #nixos-dev
drakonis has quit [Ping timeout: 240 seconds]
drakonis has joined #nixos-dev
bhipple has quit [Ping timeout: 258 seconds]
bhipple has joined #nixos-dev