gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
MichaelRaskin has joined #nixos-borg
orivej has joined #nixos-borg
<andi-> I am a bit confused why the tests failed here: https://github.com/NixOS/nixpkgs/pull/53896/checks?check_run_id=49450423
<andi-> the tests tests not the compile tests
<samueldr> `test` was broken in a change of behaviour, though I haven't followed the status of the fixes :/
<samueldr> I believe #50342 is the PR intended to fix this
<{^_^}> https://github.com/NixOS/nixpkgs/pull/50342 (by Ekleog, 8 weeks ago, open): Fix test evaluation in restrict-eval
<andi-> ahh I see, should follow things more closely again
<samueldr> there's a workaround where you can build the tests using the (newly introduced?) attribute for it
<gchristensen> andi-: better than you having to follow it would be it working :P
<LnL> yeah, I fixed the wrong thing
<gchristensen> eh?
<LnL> and I'm not a fan of the proposed workarounds
<andi-> gchristensen: well, I think both are good ;-)
<gchristensen> me either... I wish it worked like it used to
<gchristensen> but it isn't helpful for me to just be grumpy about it
<samueldr> oh, building with `build` here I say is just that, a workaround, and something better should be done, but I'm not in position to look into it :)
<LnL> I forgot what the specific problem is, but a change basically means you can't run the tests anymore in restricted mode unless you use a magical incantation
<gchristensen> seems weird, since isn't ofborg's call method the same as hydras?
<MichaelRaskin> Hydra passes the real git revision ID, I think, but should be close enough…
<LnL> hydra evaluations result in a similar workaround because of how inputs work
<ekleog> gchristensen: it's #50342, ofborg isn't passing the `nixpkgs` argument
<{^_^}> https://github.com/NixOS/nixpkgs/pull/50342 (by Ekleog, 8 weeks ago, open): Fix test evaluation in restrict-eval
<ekleog> since `cleanSource` has been added to the default `nixpkgs` argument (by roberth iirc) it can't be evaluated in restrict-eval
<ekleog> the aim was to have nixpkgs enter the store less often
<LnL> it does, but the tests go through some kind of edgecase
<ekleog> 209f8b1acd4c855d223d93f02caf3ccf6cec7e32
<{^_^}> #34489 (by roberth, 49 weeks ago, merged): nixos/release*.nix: Clean nixpkgs sources by default
<LnL> yeah that's the one