00:07
<
{^_^} >
[ofborg] @grahamc pushed to experiment/maintainer-ping « Remove 'pkgs.' prefix from each packge »:
https://git.io/fhtjH
00:18
<
tilpner >
Make sure to run cargo clippy some time
00:18
<
gchristensen >
oh man, thank you a lot for the review
00:18
<
gchristensen >
append-to-bottom indeed :')
00:20
<
tilpner >
I just checked for style things, and then I realised clippy would do that a lot better than me, so I stopped
00:20
<
gchristensen >
thanks
00:20
<
gchristensen >
I'll give that a run
00:21
<
gchristensen >
I wrote a lot of ofborg as pretty much my first real project... and not a lot of other rusty people have taken a look at it, so ... here we are (: I'll run clippy and fix them up tonight
00:26
<
gchristensen >
ah, I never ran it because it wasn't part of cargo until recently, and ofborg isn't updated to 2018 yet, so no built-in clippy.
00:26
<
gchristensen >
I'll do that this evening too.
00:37
<
gchristensen >
hrm. no. I thought clippy became part of cargo but maybe not.
00:52
tilpner has quit [Ping timeout: 244 seconds]
01:04
orivej has quit [Ping timeout: 250 seconds]
02:35
orivej has joined #nixos-borg
09:28
tilpner has joined #nixos-borg
09:37
tilpner has quit [Ping timeout: 245 seconds]
09:48
tilpner has joined #nixos-borg
10:14
tilpner has quit [Ping timeout: 246 seconds]
10:16
tilpner has joined #nixos-borg
11:32
tilpner has quit [Ping timeout: 246 seconds]
11:35
<
LnL >
gchristensen: nice work! I'll try to take a look at it tonight :)
13:17
<
gchristensen >
thanks!
15:19
<
LnL >
you've been productive, I feel like I haven't done anything the last 2 weeks
15:19
<
gchristensen >
I feel like I haven't done anything in the last two months :|
15:23
<
LnL >
oh, that's no fun :/
15:24
<
gchristensen >
no, I feel like I've been unable to finish anything
15:25
<
gchristensen >
so trying to push through it :)
16:24
tilpner has joined #nixos-borg
16:26
orivej has quit [Ping timeout: 268 seconds]
16:49
tilpner has quit [Quit: WeeChat 2.3]
17:10
orivej has joined #nixos-borg
17:15
tilpner has joined #nixos-borg
17:23
tilpner has quit [Quit: WeeChat 2.3]
17:27
tilpner has joined #nixos-borg
18:03
orivej has quit [Ping timeout: 250 seconds]
18:52
orivej has joined #nixos-borg
19:35
orivej has quit [Ping timeout: 245 seconds]
21:51
orivej has joined #nixos-borg
21:59
orivej has quit [Ping timeout: 246 seconds]
22:17
<
tilpner >
"I must not write unidiomatic code"
22:18
<
{^_^} >
rust-lang-nursery/rustfix#130 (by kornelski, 24 weeks ago, open): Clippy integration is undocumented
22:39
<
gchristensen >
tbh I prefer doing it the terrible, grueling way
22:44
<
tilpner >
You wouldn't learn anything from a cargo fix, yes
22:44
<
tilpner >
But after a while... it'd be fine. cargo fix, git diff and check if it looks okay, then commit
22:45
<
gchristensen >
I ran cargo fix and it didn't fix
22:52
<
LnL >
how large are the json blobs for the maintainer diff?
22:53
<
gchristensen >
big enough they can't be passed as args
22:57
<
LnL >
hmm, because messing around with tempfiles that get loaded into memory entirely anyway feels a bit awkward to me
23:12
orivej has joined #nixos-borg
23:14
<
gchristensen >
I agree :|
23:19
<
LnL >
I only took a quick look, ended up fixing some darwin stuff
23:29
<
gchristensen >
nice
23:31
<
gchristensen >
oooh like the path to the tmpfile?
23:44
<
LnL >
was referring to nix-darwin
23:44
<
gchristensen >
ahhh gotcha
23:44
<
LnL >
might also be useful for the hydra builders, you can disable the NIX_PATH checks now for example
23:45
<
gchristensen >
oh cool