gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
<{^_^}> [ofborg] @grahamc pushed to experiment/maintainer-ping « Remove 'pkgs.' prefix from each packge »: https://git.io/fhtjH
<tilpner> gchristensen: Commented some things, not thorough or even checked everything: https://github.com/NixOS/ofborg/pull/293#pullrequestreview-188572043
<tilpner> Make sure to run cargo clippy some time
<gchristensen> oh man, thank you a lot for the review
<gchristensen> append-to-bottom indeed :')
<tilpner> I just checked for style things, and then I realised clippy would do that a lot better than me, so I stopped
<gchristensen> thanks
<gchristensen> I'll give that a run
<gchristensen> I wrote a lot of ofborg as pretty much my first real project... and not a lot of other rusty people have taken a look at it, so ... here we are (: I'll run clippy and fix them up tonight
<gchristensen> ah, I never ran it because it wasn't part of cargo until recently, and ofborg isn't updated to 2018 yet, so no built-in clippy.
<gchristensen> I'll do that this evening too.
<{^_^}> [ofborg] @grahamc pushed to update-nixpkgs « Update nixpkgs »: https://git.io/fhqe2
<gchristensen> hrm. no. I thought clippy became part of cargo but maybe not.
tilpner has quit [Ping timeout: 244 seconds]
orivej has quit [Ping timeout: 250 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @puffnfresh opened pull request #294 → Add puffnfresh to trusted users → https://git.io/fhqk7
tilpner has joined #nixos-borg
tilpner has quit [Ping timeout: 245 seconds]
tilpner has joined #nixos-borg
tilpner has quit [Ping timeout: 246 seconds]
tilpner has joined #nixos-borg
tilpner has quit [Ping timeout: 246 seconds]
<LnL> gchristensen: nice work! I'll try to take a look at it tonight :)
<gchristensen> thanks!
<LnL> you've been productive, I feel like I haven't done anything the last 2 weeks
<gchristensen> I feel like I haven't done anything in the last two months :|
<LnL> oh, that's no fun :/
<gchristensen> no, I feel like I've been unable to finish anything
<gchristensen> so trying to push through it :)
tilpner has joined #nixos-borg
orivej has quit [Ping timeout: 268 seconds]
tilpner has quit [Quit: WeeChat 2.3]
orivej has joined #nixos-borg
tilpner has joined #nixos-borg
tilpner has quit [Quit: WeeChat 2.3]
tilpner has joined #nixos-borg
orivej has quit [Ping timeout: 250 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
<tilpner> "I must not write unidiomatic code"
<{^_^}> rust-lang-nursery/rustfix#130 (by kornelski, 24 weeks ago, open): Clippy integration is undocumented
<gchristensen> tbh I prefer doing it the terrible, grueling way
<tilpner> You wouldn't learn anything from a cargo fix, yes
<tilpner> But after a while... it'd be fine. cargo fix, git diff and check if it looks okay, then commit
<gchristensen> I ran cargo fix and it didn't fix
<LnL> how large are the json blobs for the maintainer diff?
<gchristensen> big enough they can't be passed as args
<LnL> hmm, because messing around with tempfiles that get loaded into memory entirely anyway feels a bit awkward to me
orivej has joined #nixos-borg
<gchristensen> I agree :|
<LnL> I only took a quick look, ended up fixing some darwin stuff
<gchristensen> nice
<gchristensen> oooh like the path to the tmpfile?
<LnL> was referring to nix-darwin
<gchristensen> ahhh gotcha
<LnL> might also be useful for the hydra builders, you can disable the NIX_PATH checks now for example
<gchristensen> oh cool