gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
tilpner has quit [Ping timeout: 272 seconds]
<{^_^}> [ofborg] @grahamc pushed 24 commits to clippy: https://git.io/fhm31
<{^_^}> [ofborg] @grahamc pushed 22 commits to clippy: https://git.io/fhmsp
<{^_^}> [ofborg] @grahamc pushed to clippy « cargo fmt »: https://git.io/fhmGq
<{^_^}> [ofborg] @grahamc pushed 2 commits to clippy: https://git.io/fhmGd
<{^_^}> [ofborg] @grahamc opened pull request #295 → Clippy and cargo fmt → https://git.io/fhmGb
<{^_^}> [ofborg] @grahamc pushed 6 commits to clippy: https://git.io/fhmna
<{^_^}> [ofborg] @grahamc pushed to clippy « fixup formatting »: https://git.io/fhmno
<{^_^}> [ofborg] @grahamc pushed to clippy « fixup: box the buildresult in finish »: https://git.io/fhmnQ
<{^_^}> [ofborg] @grahamc pushed to clippy « move pedantry up, set -x »: https://git.io/fhmc8
<{^_^}> [ofborg] @grahamc pushed to clippy « move pedantry up, set -x »: https://git.io/fhmc4
<{^_^}> [ofborg] @grahamc merged pull request #295 → Clippy and cargo fmt → https://git.io/fhmGb
<{^_^}> [ofborg] @grahamc pushed 37 commits to released: https://git.io/fhmC3
<{^_^}> [ofborg] @grahamc pushed 0 commits to clippy: https://git.io/fhmCs
<{^_^}> [ofborg] @grahamc merged pull request #294 → Add puffnfresh to trusted users → https://git.io/fhqk7
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fhmCG
<{^_^}> [ofborg] @grahamc merged pull request #292 → Move @worldofpeace to trusted users → https://git.io/fhJ4x
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fhmCZ
<{^_^}> [ofborg] @grahamc merged pull request #290 → Move @hedning to trusted users → https://git.io/fpFWo
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fhmCc
<{^_^}> [ofborg] @grahamc pushed 12 commits to experiment/maintainer-ping: https://git.io/fhmWs
<{^_^}> [ofborg] @grahamc pushed to experiment/maintainer-ping « Fixup formatting »: https://git.io/fhmWE
<gchristensen> LnL: https://github.com/NixOS/ofborg/pull/293#issuecomment-451049787 when you're available :)
orivej has quit [Ping timeout: 244 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 268 seconds]
<LnL> sounds good
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @grahamc merged pull request #293 → Experiment/maintainer ping → https://git.io/fhtj4
<{^_^}> [ofborg] @grahamc pushed 14 commits to released: https://git.io/fhm5N
<{^_^}> [ofborg] @grahamc pushed 0 commits to experiment/maintainer-ping: https://git.io/fhm5A
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 240 seconds]
<gchristensen> LnL: it finally happened
<gchristensen> error: the function has a cyclomatic complexity of 26
<gchristensen> --> src/tasks/massrebuilder.rs:116:5
<gchristensen> |
<gchristensen> 116 | / fn consumer(&mut self, job: &massrebuildjob::MassRebuildJob) -> worker::Actions {
<gchristensen> it took this long!
<gchristensen> I honestly didn't expect there to be one, this function is so complex already
<LnL> hmm?
<gchristensen> I made the massrebuilder function too complex :)
<gchristensen> it doesn't build anymore because of it
<LnL> it wasn't already?
<gchristensen> it wasn't
<LnL> can't remember exactly, guess it's long but relatively simple
<gchristensen> yeah
<gchristensen> https://github.com/NixOS/nixpkgs/pull/53323 you're going to get a requested review here in a second
<{^_^}> #53323 (by r-ryantm, 32 minutes ago, open): grpc: 1.17.0 -> 1.17.2
<LnL> oh, you changed it to ping people now?
<gchristensen> yae
<gchristensen> about to PR it
<LnL> nice :)
<gchristensen> evals are so slow
<LnL> hold on, did you add something to handle staging merges? not sure we want to ping everybody with larger changes
<gchristensen> heh
<LnL> didn't think about that yesterday
<gchristensen> I only request reviews if there are <10
<LnL> ah, perfect
<{^_^}> [ofborg] @grahamc pushed 2 commits to request-maintainers: https://git.io/fhYYr
<{^_^}> [ofborg] @grahamc opened pull request #296 → Request maintainers → https://git.io/fhYYK
<LnL> well look at that :D
<{^_^}> [ofborg] @grahamc merged pull request #296 → Request maintainers → https://git.io/fhYYK
<{^_^}> [ofborg] @grahamc pushed 3 commits to released: https://git.io/fhYON
<{^_^}> [ofborg] @grahamc pushed 0 commits to request-maintainers: https://git.io/fhYOA
<gchristensen> hrm.
<gchristensen> it isn't working .
Mic92 has quit [Quit: WeeChat 2.3]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 250 seconds]
orivej has joined #nixos-borg