gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 250 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 258 seconds]
dtz has quit [Read error: Connection reset by peer]
timokau[m] has quit [Remote host closed the connection]
dtz has joined #nixos-borg
timokau[m] has joined #nixos-borg
orivej has joined #nixos-borg
<timokau[m]> Why isn't ofBorg requesting peterhoeg here: https://github.com/NixOS/nixpkgs/pull/53447
<{^_^}> #53447 (by timokau, 34 minutes ago, open): neovim-qt: wrap in separate derivation
<timokau[m]> Is it because of the wrapper?
<gchristensen> waiting on the evaluation to look, timokau[m]
<timokau[m]> The wrappped package with the metadata still changed though, that doesn't matter?
<gchristensen> the attribute which changed is neovim-qt
<gchristensen> and the neovim-qt attribute has no maintainers
<timokau[m]> Oh that makes sense
<timokau[m]> Thanks for having a look
<gchristensen> I've looked at 3-4 PRs this morning and I've managed to poo-poo them all
<gchristensen> maybe I should stop for the morning
orivej has quit [Ping timeout: 250 seconds]
orivej has joined #nixos-borg
<samueldr> gchristensen: what's wrong with passthru = { inherit unwrapped; }? while I find the whole wrapper/unwrapped concept clumsy in nixpkgs, I think it's better in the end that the wrapper derivation in some way provides what was wrapped; any downside I'm missing?
<gchristensen> I wasn't remarking specifically on passthru, sorry
<samueldr> it wasn't about `unwrapped`, but the file?
<gchristensen> about compiling with one neovim and then swapping it out with a differently compiled one only in PATH
<samueldr> s/file/whole change/
<samueldr> ah
<samueldr> yeah, that smells of unintended consequences :)
<gchristensen> I should have written more
<gchristensen> I think I woke up a bit sour today :(
<timokau[m]> Its the same neovim, the one at runtime just has an added wrapper that passes it configuration