worldofpeace changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 20.09 Nightingale ✨ https://discourse.nixos.org/t/nixos-20-09-release/9668 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 20.09 RMs: worldofpeace, jonringer | https://logs.nix.samueldr.com/nixos-dev
srk has quit [Read error: Connection reset by peer]
srk has joined #nixos-dev
orivej has quit [Ping timeout: 264 seconds]
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-dev
cole-h has joined #nixos-dev
rajivr has joined #nixos-dev
<supersandro2000> How do I resolve a circular dependency in python packages?
<hexa-> usually happens during tests, disable them on one end.
<supersandro2000> makes sense. thanks.
<supersandro2000> I think I will go the pytest hypothesis way and disable the test for one dependency
<supersandro2000> seems like a common problem around that lib
<supersandro2000> "lets quickly update that one dependency and then only one is missing for that package for python 3.9"
<supersandro2000> me rebuilding pytest because a dependency of it needed an update because the update to the lib draws in a new dependency which required that 🤯
red[evilred] has quit [Quit: Idle timeout reached: 10800s]
tokudan has quit [Remote host closed the connection]
tokudan has joined #nixos-dev
<supersandro2000> Can someone explain https://github.com/NixOS/nixpkgs/projects/39 to me?
janneke has quit [Quit: janneke quits Mes'sing]
janneke has joined #nixos-dev
cole-h has quit [Ping timeout: 264 seconds]
regnat has quit [Quit: Idle for 30+ days]
orivej has joined #nixos-dev
orivej has quit [Ping timeout: 265 seconds]
Rovanion has quit [Quit: WeeChat 2.8]
<worldofpeace> Hey, is there anyone here willing to review some qemu PRs, or who usually does?
<qyliss> I can review QEMU PRs
<qyliss> I should add myself as a maintainer
<qyliss> worldofpeace: can't easily access my GH account for the next few days, but I'm happy to look over them / test them and let you know if they're good to merge in the meantime
<qyliss> (although I do realise that some of the PRs you're talking about are probably mine :P)
<{^_^}> #112746 (by mkg20001, 3 days ago, open): qemu-vm: add virtualisation.fileSystems to allow extra vm mounts
<{^_^}> #111462 (by jakobrs, 1 week ago, open): nixos/qemu-vm: add virtualisation.msize option
<{^_^}> #112954 (by TredwellGit, 1 day ago, open): qemu: set sysconfdir
<worldofpeace> I should probably review ur ones as well
<qyliss> looking
<worldofpeace> thx
<qyliss> worldofpeace: #112954 is good
<{^_^}> https://github.com/NixOS/nixpkgs/pull/112954 (by TredwellGit, 1 day ago, open): qemu: set sysconfdir
<qyliss> I'm not as familiar with the QEMU NixOS module as I am with the package, but will have a look at them
__monty__ has joined #nixos-dev
<worldofpeace> merged, does this one need backport?
<qyliss> A backport would fix bugs and would be very unlikely to hurt anything
<worldofpeace> qyliss: requested
<qyliss> I'm not sure if #112746 is a good idea
<{^_^}> https://github.com/NixOS/nixpkgs/pull/112746 (by mkg20001, 3 days ago, open): qemu-vm: add virtualisation.fileSystems to allow extra vm mounts
<qyliss> a lot of the time when you're running a NixOS VM you _want_ it to ignore filesystems because you don't want it to try to mount things that don't exist
<worldofpeace> qyliss: perhaps qemu should have it's own filessytems option?
<worldofpeace> * qyliss: perhaps qemu should have its own filessytems option?
<qyliss> Yeah I'd say so
<qyliss> At least to start with
mkg20001 has joined #nixos-dev
<mkg20001> #112746 is about qemu getting it's own filesystems option... virtualisation.fileSystems isn't fileSystems
<{^_^}> https://github.com/NixOS/nixpkgs/pull/112746 (by mkg20001, 3 days ago, open): qemu-vm: add virtualisation.fileSystems to allow extra vm mounts
<qyliss> mkg20001: yes, but it shouldn't default to options.fileSystems
<mkg20001> afaik config.fileSystems contains the filesystems and options.fileSystems simply contains the layout of the option, meaning you can set values like in fileSystems but it doesn't copy the contents of it
<worldofpeace> hmm I'm seeing a lot of nixos tests with fileSystems = pkgs.lib.mkVMOverride
<qyliss> mkg20001: ah whoops sorry I misread
<qyliss> yeah in that case #112746 LGTM although I haven't tested it
<{^_^}> https://github.com/NixOS/nixpkgs/pull/112746 (by mkg20001, 3 days ago, open): qemu-vm: add virtualisation.fileSystems to allow extra vm mounts
<qyliss> worldofpeace: can you link one?
<worldofpeace> in 19 files
<qyliss> #111462 looks good (haven't tested), although the lines could do with being broken before the ++
<{^_^}> https://github.com/NixOS/nixpkgs/pull/111462 (by jakobrs, 1 week ago, open): nixos/qemu-vm: add virtualisation.msize option
<qyliss> interesting
<qyliss> I haven't seen mkVMOverride before
<qyliss> oh it's just a mkOverride
<qyliss> ah, yes, I see
<qyliss> yeah I think #112746 is a good idea then
<{^_^}> https://github.com/NixOS/nixpkgs/pull/112746 (by mkg20001, 3 days ago, open): qemu-vm: add virtualisation.fileSystems to allow extra vm mounts
<qyliss> it would be nice if all those tests were updated to use it (would prove it works very well!) but that shouldn't block getting it merged
<worldofpeace> yeah that would be cool
<mkg20001> I already did the linked one to test
<mkg20001> The ones without also works
<mkg20001> What's the commit msg for updating a test?
<worldofpeace> you can build all tests like nixosTests.gnome3
<worldofpeace> corresponding to the attribute in I think all-tests.nix
<mkg20001> pushed a commit to update all testss to virtualisation.fileSystems
<mkg20001> running the changes ones so far looks good
<mkg20001> qyliss: can I merge the PR?
<qyliss> lgtm
orivej has joined #nixos-dev
justanotheruser has quit [Ping timeout: 260 seconds]
justanotheruser has joined #nixos-dev
<gchristensen> would anyone be opposed to me backporting all the tailscale updates in unstable to stable? it brings in some features that are otherwise unavailable (magic dns)
<qyliss> Where are the packages required for nixos-unstable-small defined?
<flokli> gchristensen: tell me more about that magic ;-)
<flokli> ah, reading https://tailscale.com/kb/1081/magic-dns, they give you a subzone, and set a search domain probably?
<flokli> yup
<flokli> heh, and I thought it was yet another NSS module, heh
<flokli> gchristensen: considering it's opt-in, it's probably fine?
<Profpatsch> wat, git-send-email is gone
<Profpatsch> It exists as a manpage, but there’s no binary
<Profpatsch> I am confuse
<Profpatsch> gchristensen: tailscale has pretty sweet compat, both ways, right? I haven’t seen their clients break
<__monty__> Is it not accessible as a subcommand either?
<Profpatsch> So I’d say go for it
<Profpatsch> __monty__: yeah
<Profpatsch> I’m on 7cbec40a09533dd9c525d6ab94dddfe77768101a
<Profpatsch> But on the train rn, so can’t really check if it was fixed
AlwaysLivid has joined #nixos-dev
<Profpatsch> somebody must have noticed. Maybe I’m holding it wrong
<Profpatsch> gitFull should have it, right?
<__monty__> I'm not on a recent channel checkout but I use nixpkgs-unstable.git and it has send-email. gitFull sounds like it should be a superset.
<Profpatsch> __monty__: nvm, looks like my system doesn’t pick up the gitFull for some reaso
<Profpatsch> I can confirm it’s in gitFUll
<Profpatsch> okay, wild, there must be some collision
<qyliss> yeah it pulls in a lot of Perl libraries so it's not in the default git package
<Profpatsch> I switched, and I added it to my system closure, still not theer
<Profpatsch> some path setup maybe?
<qyliss> shouldn't be
<Profpatsch> They are in libexec
<qyliss> yeah every git program is
<Profpatsch> maybe need to log out and log in
<qyliss> are you trying to run git-send-email instead of git send-email ?
<qyliss> because you can't do that, with any git command
<Profpatsch> both don’t exist
<qyliss> can you post the results of strace -f git send-email
<__monty__> Ah, apologies tested another git. nixpkgs.git indeed doesn't include send-email.
<qyliss> that's not good
<qyliss> oh, you mean git not gitFull
<Profpatsch> qyliss: It’s strange, it’s git not gitFull
<__monty__> Yeah, was only correcting an earlier mistake to avoid confusion. I see I failed spectacularly : )
<Profpatsch> But I’m 100% certain I have gitFull in my system closure
<Profpatsch> All the strace lookups are pointing to the git one
<Profpatsch> I’m now paranoid and checking my PATH in order
<Profpatsch> > type -p git
<{^_^}> undefined variable 'type' at (string):475:1
<Profpatsch> /run/current-system/sw/bin/git
<Profpatsch> I think I did get some collision warnings though
<Profpatsch> aha! I did get lots of collision warnings about igt
<Profpatsch> ohhh, I have git in my base, and gitFull in my base-workstation which inherits from base
<Profpatsch> that explains it
<Profpatsch> works \o/
<qyliss> should we make gitFull hiPrio or something?
srk has quit [Ping timeout: 268 seconds]
srk has joined #nixos-dev
<sterni> seems like it would make sense for it to shadow git
cole-h has joined #nixos-dev
cole-h has quit [Ping timeout: 240 seconds]
rajivr has quit [Quit: Connection closed for inactivity]
srk has quit [Remote host closed the connection]
srk has joined #nixos-dev
AlwaysLivid has quit [Ping timeout: 268 seconds]
mkaito has joined #nixos-dev
mkaito has quit [Changing host]
mkaito has joined #nixos-dev
<supersandro2000> jtojnar: you are around?
<supersandro2000> https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-flags-array.md could be solved by ``buildFlagsArray=($buildFlagsArray)`` as long as the array has no spaces which is unfortunately the sometimes the case.
<supersandro2000> disabledTestFiles has the same issue...
<jtojnar> supersandro2000: in that case, you can just use buildFlags
justanotheruser has quit [Ping timeout: 260 seconds]
justanotheruser has joined #nixos-dev
<lovesegfault> When using update.nix to update a pkg, how can I manually specify the version to update to?
<lovesegfault> trying to update something hosted on gitlab and it complains that it's unable to automatically find the latest release
<supersandro2000> you can't
<supersandro2000> either add an update script or use nix-update
<lovesegfault> Got it, will use nix-update
<lovesegfault> supersandro2000++
<{^_^}> supersandro2000's karma got increased to 33
<worldofpeace> there's an updateScript that uses nix-update
<worldofpeace> oh nvm not relevant
<lovesegfault> worldofpeace: it was for this fwiw: https://github.com/NixOS/nixpkgs/pull/113163
<{^_^}> #113163 (by lovesegfault, 19 minutes ago, open): lollypop: 1.4.5 -> 1.4.16
<lovesegfault> worldofpeace++
<{^_^}> worldofpeace's karma got increased to 264
<lovesegfault> oh, sorry
<lovesegfault> ✨ worldofpeace
<{^_^}> worldofpeace's karma got increased to 265
<lovesegfault> :D
<worldofpeace> ahh, all is right in the world again lovesegfault
<worldofpeace> yeah, if u do `nix-shell maintainers/scripts/update.nix --argstr path lollypop` it should just work
<rmcgibbo[m]> Well, luckily that one wouldn't actually trigger because the outer construct is a List.
<rmcgibbo[m]> It only falls to that branch of trawling the value for lists if the value that's assigned to the `patches` key isn't itself a list.
<jtojnar> rmcgibbo: aactually, fetchpack takes some list arguments (e.g. excludes)
<jtojnar> *fetchpatch
<rmcgibbo[m]> oh oh oh... you're totally right, i think that dooms it.
<jtojnar> maybe only match lists that are not inside another list?
<jtojnar> that still adds false negatives but no false positives
<jtojnar> AFAICS
<jtojnar> (stopping the traversal in the patches value node, of course)
<rmcgibbo[m]> `patches = lib.singleton substituteAll { src = ...; path = makeBinPath [ foo bar]; }` would still be a false positive in that scheme
<jtojnar> hmm, right
<rmcgibbo[m]> or `lib.singleton fetchpatch {... excludes = [foo bar]}` is probably more likely in practice
<rmcgibbo[m]> all of these are pretty rare though
<Gaelan> Anyone able to help with some git-fu? I'm trying to fix the merge conflict in 110571 (a staging PR), but I can't seem to do it without github pulling in a bunch of random PRs