gchristensen changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | 18.09 release managers: vcunat and samueldr | https://logs.nix.samueldr.com/nixos-dev
asymmetric_ has quit [Ping timeout: 245 seconds]
<ekleog> oh nice, so it wasn't the tests after all :)
<{^_^}> #50372 (by srhb, 1 hour ago, merged): nixos/tests/all-tests.nix: Fix incron test path
* ekleog can't do a sed properly, or so it seems
<ekleog> thank you srhb! and sorry :'(
pie_ has quit [Ping timeout: 268 seconds]
drakonis_ has joined #nixos-dev
drakonis has quit [Ping timeout: 252 seconds]
drakonis_ has quit [Client Quit]
drakonis has joined #nixos-dev
lassulus_ has joined #nixos-dev
lassulus has quit [Ping timeout: 245 seconds]
lassulus_ is now known as lassulus
drakonis has quit [Quit: WeeChat 2.3]
drakonis has joined #nixos-dev
drakonis_ has joined #nixos-dev
drakonis has quit [Ping timeout: 245 seconds]
orivej has quit [Ping timeout: 268 seconds]
jtojnar has joined #nixos-dev
drakonis has joined #nixos-dev
drakonis_ has quit [Ping timeout: 252 seconds]
thoughtpolice has quit [Ping timeout: 250 seconds]
thoughtpolice has joined #nixos-dev
jtojnar has quit [Ping timeout: 244 seconds]
ckauhaus[afk] has quit [Quit: WeeChat 2.2]
<srhb> ekleog: Haha, no problem. :-)
__Sander__ has joined #nixos-dev
orivej has joined #nixos-dev
init_6 has joined #nixos-dev
primeos has quit [Ping timeout: 240 seconds]
primeos has joined #nixos-dev
primeos has quit [Client Quit]
primeos has joined #nixos-dev
drakonis_ has joined #nixos-dev
drakonis has quit [Ping timeout: 252 seconds]
<infinisil> Okay, for options that give extra arguments to a command (extraArgs or extraArguments), what do you think the type should be?
<infinisil> types.str is the simplest, but you can't set it multiple times, so not ideal
<infinisil> types.listOf types.str can be set multiple times, but it's annoying, because to set the arguments "--foo --bar --baz" you need `[ "--foo" "--bar" "--baz" ]`
<infinisil> types.separatedString " " is probably much better, allows you to set `"--foo --bar --baz"` directly, but it's not used often in nixos
<infinisil> I suggested the latter in a PR I reviewed
<qyliss^work> My experience in Homebrew was always that argument lists should be arrays, because then you can escape them and have arguments with spaces or whatever if you need to.
<qyliss^work> But nixpkgs doesn't really seem to bother with escaping a lot of the time...
<qyliss^work> Seeing an array implies, to me, that arguments will be escaped. If they aren't going to be, separatedString is probably clearer.
<infinisil> qyliss^work: Yeah the escaping is a good point
<infinisil> > lib.escapeArgs [ "foo" "bar'" "\"test" ]
<{^_^}> attribute 'escapeArgs' missing, at (string):206:1
<infinisil> > lib.escapeShellArgs [ "foo" "bar'" "\"test" ]
<{^_^}> "'foo' 'bar'\\''' '\"test'"
<infinisil> qyliss^work: There is this one could use with arrays ^
<qyliss^work> I would recommend `listOf str`, but also making sure in reviews that extraArgs are escaped.
<infinisil> qyliss^work: Thanks, did that :) https://github.com/NixOS/nixpkgs/pull/50382/files#r233819714
<infinisil> I'll make sure they don't forget the escaping before merging
drakonis has joined #nixos-dev
drakonis_ has quit [Ping timeout: 272 seconds]
drakonis has quit [Ping timeout: 264 seconds]
ma27 has quit [Quit: WeeChat 2.2]
ma27 has joined #nixos-dev
<nbp> gchristensen: Do you have any experience setting up NixOS on arm64?
<samueldr> (he's on leave for a couple days)
<samueldr> nbp: anything particular you want to ask, other users may have experience :)
<nbp> samueldr: I figure at the end that the reason the device does not boot on the usb drive is because it is too small :/
<samueldr> nbp: if you want, you can also hop in #nixos-aarch64, a couple enthusiasts idle there
<samueldr> but otherwise, nbp, which device?
<samueldr> as far as drive size, as long as sd-image-aarch64.img fits, for SBCs, it always worked for me, even if tight
<samueldr> :/ no direct experience with that one or similar, sadly
<nbp> samueldr: the sd_image is 2.3 GB, and I had tried with 2 USB drives of 1.9 GB before noticing.
<samueldr> ah, this could be causing issues :)
<nbp> samueldr: Some coworkers managed to get fedora installed on it.
jtojnar has joined #nixos-dev
__Sander__ has quit [Quit: Konversation terminated!]
drakonis has joined #nixos-dev
drakonis_ has joined #nixos-dev
drakonis has quit [Ping timeout: 260 seconds]
drakonis has joined #nixos-dev
drakonis_ has quit [Ping timeout: 252 seconds]
Drakonis__ has joined #nixos-dev
drakonis has quit [Ping timeout: 244 seconds]
<sphalerite> nbp: yeah step 1 would be see if you can get it working with a bigger USB stick, or netboot (it should have enough RAM for that)
<samueldr> (from a followup in aarch64) it could be also from the fact that sd-image-aarch64 isn't EFI ready
drakonis has joined #nixos-dev
init_6 has quit [Ping timeout: 240 seconds]
drakonis has quit [Quit: WeeChat 2.3]
drakonis has joined #nixos-dev
ma27 has quit [Quit: WeeChat 2.2]
obadz- has joined #nixos-dev
obadz has quit [Ping timeout: 272 seconds]
obadz- is now known as obadz
ma27 has joined #nixos-dev
drakonis has quit [Quit: WeeChat 2.3]
hedning has joined #nixos-dev
drakonis has joined #nixos-dev
Drakonis__ has quit [Ping timeout: 264 seconds]
hedning has quit [Ping timeout: 244 seconds]
<domenkozar> if anyone is still up, I'd appreciate a proof-read
<domenkozar> otherwise in the morning :)
drakonis_ has joined #nixos-dev
drakonis has quit [Ping timeout: 252 seconds]
drakonis has joined #nixos-dev