* samueldr
is finally looking at nixpkgs things again
<samueldr>
#45345 might need some comments from other users with experience in the tests infra; the feature itself seems to work flawlessly (at least when I last tested it, it did)
<Mic92>
infinisil: many small things. It orders pull requests by update date instead of creation date. It allows to merge pull request when the CI is finished. It shows the current CI status next to the project title. Quit a few new shortcuts ...
<Mic92>
easier to reach patch links and the compare view.
lassulus_ has joined #nixos-dev
lassulus has quit [Ping timeout: 245 seconds]
lassulus_ is now known as lassulus
hyperfekt has quit [Ping timeout: 256 seconds]
dtz has quit [Ping timeout: 250 seconds]
Ericson2314 has quit [Ping timeout: 264 seconds]
roberth has quit [Ping timeout: 250 seconds]
sphalerit has quit [Ping timeout: 250 seconds]
thefloweringash has quit [Ping timeout: 250 seconds]
yegortimoshenko has quit [Ping timeout: 260 seconds]
florianjacob has quit [Ping timeout: 264 seconds]
peterHK has joined #nixos-dev
Ericson2314 has joined #nixos-dev
dtz has joined #nixos-dev
florianjacob has joined #nixos-dev
thefloweringash has joined #nixos-dev
yegortimoshenko has joined #nixos-dev
sphalerit has joined #nixos-dev
roberth has joined #nixos-dev
roberth has quit [Ping timeout: 250 seconds]
sphalerit has quit [Ping timeout: 252 seconds]
thefloweringash has quit [Ping timeout: 252 seconds]
dtz has quit [Ping timeout: 252 seconds]
yegortimoshenko has quit [Ping timeout: 264 seconds]
Ericson2314 has quit [Ping timeout: 250 seconds]
florianjacob has quit [Ping timeout: 264 seconds]
peterHK has quit [Ping timeout: 256 seconds]
florianjacob has joined #nixos-dev
thefloweringash has joined #nixos-dev
Ericson2314 has joined #nixos-dev
sphalerit has joined #nixos-dev
dtz has joined #nixos-dev
yegortimoshenko has joined #nixos-dev
roberth has joined #nixos-dev
peterHK has joined #nixos-dev
Lisanna has joined #nixos-dev
peterHK has quit [Ping timeout: 256 seconds]
peterHK has joined #nixos-dev
drakonis has quit [Ping timeout: 240 seconds]
drakonis has joined #nixos-dev
peterHK has quit [Ping timeout: 256 seconds]
peterHK has joined #nixos-dev
orivej has quit [Ping timeout: 252 seconds]
orivej has joined #nixos-dev
orivej has quit [Ping timeout: 252 seconds]
__Sander__ has joined #nixos-dev
orivej has joined #nixos-dev
phreedom has quit [Ping timeout: 256 seconds]
ckauhaus has joined #nixos-dev
phreedom_ has joined #nixos-dev
peterHK has quit [Ping timeout: 256 seconds]
drakonis has quit [Ping timeout: 268 seconds]
drakonis has joined #nixos-dev
<Profpatsch>
gchristensen: The mupdf library update broke zathura (the PDF viewer). Can I tell ofborg: “when you update this application, please check if you can still build this other one”?
<Profpatsch>
I think meta.tests is merged, so we could add support for reading that attrset.
<Profpatsch>
cc ekleog
<ekleog>
Profpatsch: meta.tests isn't merged yet :( planned to poke again within a few days, as everyone seems to agree
<Profpatsch>
ekleog: Should we think about how to integrate these checks?
<Profpatsch>
Just unconditionally run them?
<ekleog>
also, technically meta.tests's specification wouldn't include building other packages, as it requires the timeout and needsVMSupport attributes, meaning that you'd need to override the other deriation to turn it into a test
<Profpatsch>
Huh?
<Profpatsch>
That’s a major oversight then.
<Profpatsch>
These infos should not influence the derivations in *any* way.
<ekleog>
as for integration, my opinion is to run them depending on the timeout and needsVMSupport values, actually
<Profpatsch>
Bear in mind that `meta` does not influence the derivation hashes
<ekleog>
yes yes, I just mean that zathura likely doesn't have the `meta.timeout` and `meta.needsVMSupport`, does it?
<ekleog>
so we'd need to override the zathura derivation to add these meta fields
<Profpatsch>
ekleog: Yeah, but that doesn’t change the hash.
<Profpatsch>
Because meta is excluded from the hash.
<ekleog>
well, either that or remove the requirement for meta.{timeout,needsVMSupport} that was added for [don't remember which reason]
<ekleog>
oh I must have misspoke then, I just meant you can't just do `meta.tests = { zathura-builds = pkgs.zathura; }`
<Profpatsch>
Yeah, but that’s not expected, right?
<ekleog>
(also, I wonder whether this wouldn't cause an infinite loop, actually :/ and this would be an oversight indeed)
<Profpatsch>
That can be a function.
<ekleog>
I thought that was what you expected :)
<Profpatsch>
Nope, should not cause an infinite loop.
<Profpatsch>
Because meta is excluded. :P
<Profpatsch>
If it does we can’t do it like we planned.
<ekleog>
so I support the idea of having ofborg just building `pkg.meta.tests` everytime it builds `pkg` (if the attrset exists), but it'll have to be after meta.tests is actually merged I think :p
<{^_^}>
#49766 (by roberth, 1 day ago, open): Add writeOnly options to the module system
<Profpatsch>
ekleog: awesome!
<Profpatsch>
The joy of fixpoints. :)
<ekleog>
:)
init_6 has joined #nixos-dev
<nbp>
roberth: how urgent is this, can this wait until Saturday?
<roberth>
nbp: sure
<nbp>
roberth: Thanks for all the good your you are doing, I will try do review it by Saturday ;)
<nbp>
roberth: 3 remarks, without looking at the implementation: Why is this useful, why don't we want to open this computation to other modules? WriteOnly sounds miss-leading as this something used to declared that only the current module is allowed to set it. "only the current module" breaks the modularity of the module system.
<nbp>
^ not modular => you cannot split your module in 2 and get the same behaviour
<roberth>
nbp: it is useful because it lets us set an error message when modules access options that should not be accessed. The reason I wrote it is so we can disallow access to the nixpkgs.hostSystem setting, which is wrong when cross-compiled. The error message will tell module authors what else to use. It is not something to use often. Technically it doesn't break modularity because it isn't enforced. The value is still
<roberth>
reachable through options.foo.internalValue, which should be sufficiently discouraging - the normal ways of getting the value throw the error
<nbp>
roberth: how isn't that solved by the `uniq` type?
<nbp>
roberth: and the `internal = true` flag
<nbp>
I understand the need for a better error message, but if the goal is only to have it set once, `uniq` should be the way to go.
<roberth>
nbp: It should be still possible to set it as usual
orivej has quit [Remote host closed the connection]
<Profpatsch>
Maybe we can steal some of these attributes
<ekleog>
Profpatsch: tbh I'd rather go with the strict minimal set of attributes just so that it gets merged without too much nitpicking, and add more attributes later when we have time to lose nitpicking :°
<Profpatsch>
.sure
Sigyn has quit [Quit: People always have such a hard time believing that robots could do bad things.]
Sigyn has joined #nixos-dev
ivan has quit [Quit: lp0 on fire]
niska has quit [Write error: Connection reset by peer]
ivan has joined #nixos-dev
niska has joined #nixos-dev
drakonis_ has joined #nixos-dev
drakonis1 has joined #nixos-dev
drakonis has quit [Ping timeout: 244 seconds]
drakonis has joined #nixos-dev
drakonis_ has quit [Read error: Connection reset by peer]
__Sander__ has quit [Ping timeout: 252 seconds]
__Sander__ has joined #nixos-dev
drakonis1 has quit [Ping timeout: 268 seconds]
Synthetica has joined #nixos-dev
timokau has joined #nixos-dev
phreedom_ has quit [Ping timeout: 256 seconds]
phreedom has joined #nixos-dev
init_6 has quit []
drakonis has quit [Read error: Connection reset by peer]
drakonis has joined #nixos-dev
drakonis has quit [Read error: Connection reset by peer]
drakonis has joined #nixos-dev
drakonis has quit [Read error: Connection reset by peer]
drakonis has joined #nixos-dev
__Sander__ has quit [Quit: Konversation terminated!]
drakonis has quit [Read error: Connection reset by peer]