gchristensen changed the topic of #nixops to: NixOps related talk | logs: https://logs.nix.samueldr.com/nixops/ https://meet.jit.si/NixOpsReview
DigitalKiwi has quit [Quit: quite.]
DigitalKiwi has joined #nixops
DigitalKiwi has quit [Quit: quite.]
DigitalKiwi has joined #nixops
ixxie has joined #nixops
<ixxie> gchristensen - is there an example of a plugin which has already been modernized?
<ixxie> DigitalKiwi: do you think `DigitalOceanX` classes should be renamed `DropletX`?
<DigitalKiwi> ohhi
<ixxie> DigitalKiwi: the AWS plugin uses the AWS resource name for their classes: https://github.com/NixOS/nixops-aws/blob/master/nixops_aws/backends/ec2.py
<DigitalKiwi> ah yeah i see
<DigitalKiwi> yeah that makes sense especially when we have volumes, dns, floating ips...
<ixxie> Alrighty, I will rename them
<DigitalKiwi> just make sure to rename them all ;D
<DigitalKiwi> i miss ghc already :(
<ixxie> lol sure
<DigitalKiwi> start with working code, rename something, and then with ghcid it'll just keep helpfully pointing out where something else needs to be changed as you go along. and when it goes green you're done! :D
* DigitalKiwi should learn mypy i guess
* ixxie should too
<ixxie> DigitalKiwi: this rename will break the API
<ixxie> DigitalKiwi: does the plugin have semantic versioning?
<ixxie> hmm doesn't seem to have any versioning :P
<DigitalKiwi> i don't even think it has a version...
<ixxie> okay well, I guess we can release 1.0
<DigitalKiwi> and clearly it should follow this https://pvp.haskell.org/faq/
<DigitalKiwi> as far as i know there are ~3 people that have used/tried to use this
<DigitalKiwi> and i haven't heard from the other one in a while...
<DigitalKiwi> and the last time i tried to use it it wouldn't work :(
<ixxie> yeah that is clearly a deterent :D
<ixxie> this PVP seems like overkill to me
<DigitalKiwi> i'm mostly joking
<DigitalKiwi> but it is superior :D
<ixxie> hah
* DigitalKiwi looks for a screenshot
<DigitalKiwi> THAT WAS MATURE
<ixxie> :P
<DigitalKiwi> local VERSION = '0.03.15'
<DigitalKiwi> local LUALPM_VERSION = '0.03'
<DigitalKiwi> lol
<DigitalKiwi> it's this https://github.com/Kiwi/clyde
<ixxie> DigitalKiwi: well I pushed the rename but I still can't figure out what goes wrong with the plugin atm
<DigitalKiwi> i'm a few steps behind it seems lol
<DigitalKiwi> +-------------------+
<DigitalKiwi> | Installed Plugins |
<DigitalKiwi> +-------------------+
<DigitalKiwi> +-------------------+
<DigitalKiwi> when i do the steps from the aws repo
lordcirth has quit [Ping timeout: 244 seconds]
<ixxie> no sure, I only got it to work on my branch of the DO plugin
<ixxie> DigitalKiwi: made some more progress it seems!
<ixxie> DigitalKiwi: check the latest push, and the report of where I got stuck https://gist.github.com/ixxie/36c3830e931bcf8e03f86f893f79bf99
<ixxie> DigitalKiwi: its some kind of type error now
<ixxie> DigitalKiwi: time for your statically typed mind to shine by leveraging mypy to figure this out :D
<DigitalKiwi> ixxie: what nixpkgs do you use
<ixxie> DigitalKiwi: unstable
<DigitalKiwi> huh
<DigitalKiwi> it erros on unstable here :/
<DigitalKiwi> nix-shell
<DigitalKiwi> but nix-shell -I nixpkgs=channel:nixos-20.03 went through
<ixxie> nix-shell errors... weird
<DigitalKiwi> i've made a few local changes too
<DigitalKiwi> idk if they helped or made it worse anymore
<ixxie> did you pull recently
<ixxie> I just made some fixes which I pushed a few minutes ago
<ixxie> maybe try to repull my branch in a seperate directory
<ixxie> I think at this point we would benefit from adding type hints and letting mypy help us
<ixxie> it would also help us understand what is going on
chiiba has joined #nixops
<ixxie> DigitalKiwi: if you feel like looking into the mypy thingy do read the end of my log gist, I recorded my thoughts. Its not trivial to figure out how to type hint everything :/
<ixxie> DigitalKiwi: btw I guess we can delete the travis.yml
<ixxie> DigitalKiwi: pushed my latest work on type hints... still got a ways to go but *something* is there now
<ixxie> DigitalKiwi: also styled stuff with black
<ixxie> DigitalKiwi: could you add yourself and grahamc (=gchristiansen's github username) as reviewers to the PR?
<ixxie> DigitalKiwi: also, maybe consider moving this repo to the `nix-community` organization?
<chiiba> ixxie: The issue was fairly simple, wrote about it in your PR. Not sure how quick/easy would it be to roll-out a patch to make nixops v1.7 work though. As I understand you guys are currently working on creating a DigitalOcean plugin for the NixOps 2.0 version, but it would be nice if 1.7 could be patched while development is still happening.
<ixxie> chiiba: I'm sure DigitalKiwi would accept a PR if you wanna submit one
<ixxie> chiiba: oh wait, so nixops needs patching, not the plugin?
<chiiba> ixxie: I think so, yes.
<chiiba> ixxie: The issue existed before the plugin was even created essentially
<ixxie> chiiba: this is so simple, I think you can submit a PR to nixops and they will fast track it
<chiiba> Ok, will try to do that then
<ixxie> chiiba: I'm not involved, I think gchristensen is coordinating the push to 2.0 so he might be the guy to ping about this
<ixxie> chiiba: grahamc on Github
raghavsood has joined #nixops
<raghavsood> Anyone know how I'd go about using a remote builder with nixops? The github issues lead me to believe it is not currently fully possible, but I'd like to confirm since they occasionally tend to be out of date
<raghavsood> I already have a remote builder set up, just that nixops doesn't seem to use it
<ixxie> raghavsood: it seems most the core people are not online yet... I think they are mostly in the American timezones
<raghavsood> I might come back later, just on the off chance that someone who is around doesn't know :)
<ixxie> sounds good
ixxie has quit [Quit: Lost terminal]
<gchristensen> raghavsood: in the end, nixops is just ar egular nix-build running on the same machine running nixops. the machine running nixops has a working remote builder?
<raghavsood> Yes, a non-nixops nix-build successfully uses the remote machine
<raghavsood> The remote machine is managed by nixops, would that cause any issues?
pinkieval has quit [Ping timeout: 240 seconds]
pinkieval has joined #nixops
meh` has joined #nixops
meh` has quit [Ping timeout: 246 seconds]
meh` has joined #nixops
cole-h has joined #nixops
teto1 has joined #nixops
teto1 has quit [Ping timeout: 256 seconds]
teto1 has joined #nixops
johnny101a has quit [Quit: Konversation terminated!]
johnny101 has joined #nixops
* colemickens wonders how nixops + flakes intersect, given nixops lack of support for multiple nixpkgs in a single network
meh` has quit [Ping timeout: 240 seconds]
tokudan has quit [Remote host closed the connection]
tokudan has joined #nixops