abathur has joined #nixops
<
gchristensen>
:D :D :D
<
{^_^}>
nixops#1236 (by AmineChikhaoui, 10 minutes ago, open): deployment.py: more mypy type checking
abathur has quit [Ping timeout: 258 seconds]
abathur has joined #nixops
abathur has quit [Ping timeout: 260 seconds]
abathur has joined #nixops
abathur has quit [Ping timeout: 255 seconds]
<
gchristensen>
aminechikhaoui: so you think we should create the pre-python3 branch now from master, and then merge the python 2->3 update whenever?
abathur has joined #nixops
myskran has joined #nixops
abathur has quit [Ping timeout: 240 seconds]
pbb has joined #nixops
abathur has joined #nixops
myskran has quit [Ping timeout: 256 seconds]
abathur has quit [Ping timeout: 256 seconds]
abathur has joined #nixops
pbb has joined #nixops
abathur has quit [Read error: Connection reset by peer]
<
aminechikhaoui>
gchristensen yeah, makes sense to you ?
<
gchristensen>
aminechikhaoui: looks like you need to run `black .` on your branch
<
aminechikhaoui>
yeah
<
DigitalKiwi>
is the py3 branch far/working enough that i can start using it to convert nixops-digitalocean to py3?
<
DigitalKiwi>
or should i wait
<
gchristensen>
DigitalKiwi: it is a bit tricky to use plugins with it right now... but we'll probably merge it ~tomorrow :)
<
gchristensen>
aminechikhaoui: are you good to look at that branch's failures, or would you like me to?
<
aminechikhaoui>
gchristensen yeah I can look at it
<
gchristensen>
since that PR fixes the only bug we've found, I'm thinking we should merge the overall branch after?
<
aminechikhaoui>
TravisCI looks happy now
<
aminechikhaoui>
gchristensen merging sounds good
<
aminechikhaoui>
what was the workflow to port to python 3 btw ? run 2to3/test and fix then start playing with mypy ?
<
DigitalKiwi>
will mypy work with plugins ~tomorrow
<
gchristensen>
aminechikhaoui: yeah pretty much just that
<
gchristensen>
2to3... run mypy ... fix the complaints. easy, right? :)
<
gchristensen>
I had to do extra work to undo the weird first try PR of 2to3-ing
<
gchristensen>
aminechikhaoui: let's not merge before tomorrow, though. aanderse is going to test it on his deployments
<
aminechikhaoui>
Sure