<red[evilred]>
"not start a bunch of pull requests and let them go stale :(" on irc that bothered me
<red[evilred]>
if I'm missing something I need to be doing, please tell me - and I'll try to learn first time
<red[evilred]>
your comment implies (unintentionally maybe) that I'm just dumping into the queue without caring about the quality of the work that I'm doing.
<hexa->
Let me address this when I'm back on my pc
<red[evilred]>
no worries.
<hexa->
<red[evilred]> Because the last thing I saw was a request for a change which I implemented
<red[evilred]>
How many people should a typical PR involve fort reviewsa?
<red[evilred]>
so I can get started on this and make sure any others I have also have that done
<red[evilred]>
because I want to do the right thing, I just plainly missed your expectation here.
<hexa->
so, back at my pc.
<red[evilred]>
I guess the original author of the patch I cherry-picked?
<hexa->
the xorg backport is two weeks old, you say you were going to do a nixpkgs-review pr and "brb", nothing further happened
<hexa->
yes, or the reviewers of that pull request
<hexa->
also I feel the cassandra pull requests are going nowhere, and as I stated I'm not familiar with cassandra
<hexa->
sure, that might not be your fault per se
<hexa->
heh fault is a shitty topic in open source, and I don't mean "fault", english is not my first language
<red[evilred]>
I reached out to the maintainer and they said they didn't use it anymore
<red[evilred]>
so didn't have any way to help
<red[evilred]>
Let's just look forward - I just want to help as best I can
<hexa->
for cassandra? check who else did commits related to cassandra recently
<hexa->
sure, let's do that
<hexa->
sorry for possible snark
<red[evilred]>
and since I've ramped up working on packages that aren't mine - I'm hitting issues like this that I don't know how to address
<red[evilred]>
before, I was excluisively working on modules that I wrote / maintaines
<red[evilred]>
maintained
<red[evilred]>
so I'm hitting new cultural issues
<red[evilred]>
no worries <3
<hexa->
I'll request some reviewers
<red[evilred]>
it happens
<red[evilred]>
Thanks -
<red[evilred]>
how useful is the "suggested reviewers" section?
<hexa->
depends
<cole-h>
Basically just suggests people who touched the files you touched last
<red[evilred]>
what is the etiquite for requesting - do I just add them?
<red[evilred]>
or do I try and contact them first?
<hexa->
I'd rather log at `git log` for a certain file and see who did actual changes to the package/module
<cole-h>
^
<hexa->
just do imo
<red[evilred]>
okay
<hexa->
don't be spammy with requests, should be fine as long as there is a relationship
<red[evilred]>
So, since I know that the previous maintainer is now disengaged - should I try and find a new maintainer?
<hexa->
especially when there is no maintainer, like in this case
<hexa->
uh no
<red[evilred]>
it seems a waste of knowledge to just throw away that fact that I know that the maintainer is no longer current
<hexa->
maintainers should probably step up themselves, you could make users aware of the lack of maintainership though.
<red[evilred]>
should they raise a PR changing the maintainer field to [] ?
<red[evilred]>
or should I encorage them to do so?
<hexa->
pretty sure cransom did that already
<hexa->
see f6e974e701fba2de89e24637d6478aee69de0546
<red[evilred]>
ah yes - in master - now I see it
<red[evilred]>
I really should be writing down each of these things as I come across them and put them in some kind of FAQ
<red[evilred]>
being a new developer can sometimes feel like a thousand paper-cuts
<hexa->
yep
<red[evilred]>
and I'm sure you guys get sick and tired of asking the same questions
<red[evilred]>
or having to reject PRs for the exact same thing every single time
supersandro2000 has quit [Read error: Connection reset by peer]
<hexa->
re #103552, please pick #105631, then try to find a test that uses xorg.xorgserver and run it, then look up the reviewers in 105631.