andi- changed the topic of #nixos-security to: Vulnerability Roundup Issues: https://github.com/NixOS/nixpkgs/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+Vulnerability+roundup + https://broken.sh | Currently supported releases: unstable (master), 20.09, 20.03 (until 27th of November)
<lukegb> Hah
<lukegb> You don't even need to redo it, just cherrypick into a new PR? :P
<hexa-> Yes, that is easily done, but will likely fck up things more.
<lukegb> Honestly? If they're throwing a tantrum, I don't really care :P
<andi-> We *must* have proper commit messages
<andi-> nixpkgs is already enough of a dumpster of all sorts of shitty commits.
<hexa-> Only having history because it's on GitHub is not good enough, which is why I agree that commits need to properly document stuff.
<andi-> Exactly.
<hexa-> this is the fix, and it doesn't apply
<hexa-> File slirp is not a regular file -- refusing to patch
<hexa-> ideas?
<hexa-> they've just updated the submodule
<lukegb> It's not going to be particularly easy :P
<lukegb> Probably grab the actual source archive, unpack it, finagle the slirp patch into applying cleanly?
<hexa-> hrhr
<hexa-> hm ok
<hexa-> fair enough
tilpner_ has joined #nixos-security
tilpner has quit [Ping timeout: 260 seconds]
tilpner_ is now known as tilpner
cole-h has joined #nixos-security
ris has quit [Ping timeout: 264 seconds]
supersandro2000 has joined #nixos-security
kreyren has joined #nixos-security
kreyren is now known as kreyren2
kreyren2 is now known as kreyren
star_cloud has quit [Remote host closed the connection]
star_cloud has joined #nixos-security
star_cloud has quit [Excess Flood]
star_cloud has joined #nixos-security
rajivr has joined #nixos-security
kalbasit has joined #nixos-security
red[evilred] has joined #nixos-security
<red[evilred]> erk
<red[evilred]> fun times.
kalbasit has quit [Ping timeout: 256 seconds]
cole-h has quit [Ping timeout: 260 seconds]
FRidh has joined #nixos-security
tilpner has quit [Remote host closed the connection]
tilpner has joined #nixos-security
tilpner has quit [Remote host closed the connection]
tilpner has joined #nixos-security
red[evilred] has quit [Quit: Idle timeout reached: 10800s]
<MichaelRaskin> The most annoying things to debug are minor updates messed up by upstream toi be not so minor anyway.
<MichaelRaskin> If you want something to be on record about a package, do not write a suggestion of a commit message, suggest (or push on top…) code comment addition already.
ris has joined #nixos-security
<andi-> Whatever way. I still think the motivation for that change (if not in a comment in the code; which arguable here is fine as it is just flipping a configure flag) should be on record somewhere. For any kind of "special care" I do agree that it should always have a comment in the code. Here it could be but doesn't have to be but it should be in the commit message (briefly).
<andi-> Anyway I think I'll not review any more nixpkgs PRs in the near future.. It is such a shitshow of auto-updates & commit messages that lack detail that it just depresses me.
<FRidh> andi-: maybe it helps to use the filters to select what you're interested in reviewing or not. Commit messages and code comment wise, yes, that is unfortunate.
<andi-> I was interested in QEMU and this is what happened.. Not sure that helps. I also have a grudge with all those running nixpkgs-review unattended and then not having any details of their failures.. We lowered the barrier for contribution to a level that is just annoying.
<andi-> If you do not mean to review something anymore but just run a tool then your review is useless.
kreyren has quit [Ping timeout: 240 seconds]
KREYREEN has joined #nixos-security
red[evilred] has joined #nixos-security
<red[evilred]> Well, since we're talking about PR quality - my latest PRs were the Cassandra ones
<red[evilred]> they're just sitting there after review with no comments other than people have looked at it
<red[evilred]> does that mean that I"m missing anything?
<red[evilred]> eg: #104841
<{^_^}> https://github.com/NixOS/nixpkgs/pull/104841 (by redvers, 3 days ago, open): cassandra_3_0: 3.0.17 -> 3.0.23
KREYREEN has quit [Remote host closed the connection]
KREYREEN has joined #nixos-security
KREYREEN has quit [Remote host closed the connection]
KREYREEN has joined #nixos-security
<FRidh> red[evilred]: no, it just means nobody that has seen the issue has decided to act on it. And the maintainer apparently isn't part of the maintainers team and thus gets no notification automatically. Best is if you, as contributor, cc the maintainer of the package.
cole-h has joined #nixos-security
star_cloud has quit [Remote host closed the connection]
star_cloud has joined #nixos-security
KREYREEN has quit [Remote host closed the connection]
KREYREEN has joined #nixos-security
star_cloud has quit [Excess Flood]
star_cloud has joined #nixos-security
cole-h has quit [Ping timeout: 264 seconds]
maljub01 has quit [Read error: Connection reset by peer]
maljub01 has joined #nixos-security
KREYREEN has quit [Remote host closed the connection]
FRidh has quit [Ping timeout: 265 seconds]
KREYREEN has joined #nixos-security
mschwaig1 has joined #nixos-security
mschwaig has quit [Ping timeout: 264 seconds]
red[evilred] has quit [Quit: Idle timeout reached: 10800s]
rajivr has quit [Quit: Connection closed for inactivity]
justanotheruser has joined #nixos-security
tilpner has quit [Quit: tilpner]
julm has quit [Remote host closed the connection]
julm has joined #nixos-security
KREYREEN has quit [Remote host closed the connection]
KREYREEN has joined #nixos-security