<jtojnar> worldofpeace yeah, you are right, multisession could not work without session files in XDG_DATA_DIRS
<jtojnar> we should probably add the fix you mention
<jtojnar> Though I do not think this ever worked (or did we install the session files before switching to upstream ones?)
jtojnar has quit [Quit: killed]
worldofpeace has quit [Quit: killed]
lndn[m] has quit [Quit: killed]
hpfr has quit [Quit: killed]
mkg20001 has quit [Quit: killed]
kevincox[m] has quit [Quit: killed]
hpfr has joined #nixos-gnome
mkg20001 has joined #nixos-gnome
worldofpeace has joined #nixos-gnome
jtojnar has joined #nixos-gnome
kevincox[m] has joined #nixos-gnome
lndn[m] has joined #nixos-gnome
lndn[m] has quit [*.net *.split]
julm has quit [*.net *.split]
lndn[m] has joined #nixos-gnome
julm has joined #nixos-gnome
<worldofpeace> Jan Tojnar: that's what I'm wondering. We have gnome-session sessions into a separate output, but I still think it wasn't system wide because we were setting XDG_DATA_DIRS into the dm environment
<worldofpeace> Jan Tojnar: should sessionData.desktops be installed by default?
<worldofpeace> err, that's probably too big of a change for 20.09 anyways
<jtojnar> worldofpeace: I would not expect it to break anything
<worldofpeace> Jan Tojnar: oh, I was thinking because there is `sessions-directory` in lightdm you could get duplicate sessions.
<worldofpeace> but I see it sets it to the sessionData paths. not sure if it only seaches sessions-directory
<jtojnar> yeah, IIRC, it does
<worldofpeace> <jtojnar "cool, NixOS mentioned in https:/"> yeah, they're pretty cool. they actually added me to their org.
<worldofpeace> Jan Tojnar: Oh right, we didn't have wayland-sessions before and they weren't loaded
<worldofpeace> So the question is, do we make it so the dm's load from the sessionData dirs, or global ones?
<jtojnar> I would rely on global ones through XDG_DATA_DIRS when supported
<jtojnar> and store path for lightdm
<jtojnar> to prevent duplicates as you mentioned
<worldofpeace> Jan Tojnar: yeah, I just looked at sddm and lightdm and I don't think they have an elegant loading like that. Will do that and have the displaymanager module install sessionData.desktops
<worldofpeace> Jan Tojnar: woah, I dropped the XDG_DATA_DIRS and it can't find any session. I guess that means XDG_DATA_DIRS just isn't set in the greeter. I'm not sure how that's true, we have the pam environment which fixed this for lightdm
<jtojnar> Would systemd services even use pam environment?
<worldofpeace> yeah, I just commented that. It seems user services will, but not system
<worldofpeace> should XDG_DATA_DIRS be globalEnvironment?
<jtojnar> So is the gdm used by GNOME shell introspected libgdm in gnome-shell process?
<jtojnar> I guess it is kind of nice that system services are kind of hermetic wrt global directory
<jtojnar> So I retract the suggestion to remove the explicit XDG_DATA_DIRS
<worldofpeace> <jtojnar "So is the gdm used by GNOME shel"> I believe so from the code you linked in gnome-shell
<worldofpeace> <jtojnar "I guess it is kind of nice that "> I'm not totally sure about that or not, yet. At least for XDG_DATA_DIRS
<jtojnar> IMHO, ideally all services should be totally hermetic
<jtojnar> But it is difficult for some that depend on some nexi like /share/sessions
<jtojnar> And we will have to deal with them on case by case basis
<jtojnar> so that we do not contaminate the rest of services
<jtojnar> Maybe we could add an option systemd.services.<name>.requiresImpureFhs to máje that easier
<jtojnar> * Maybe we could add an option systemd.services.<name>.requiresImpureFhs to make that easier
<jtojnar> But ideally we would have explicit nexus management in systemd instead of relying on FHS paths
<jtojnar> Maybe using systemd templates
<jtojnar> or some similar mechanism
<worldofpeace> If we take that route then it would then make sense, in the case of systemd.services.display-manager, to have requiresImpureFHS
<jtojnar> yup
<jtojnar> * yup, if we wanted to cop out
<jtojnar> But ideally we would not cop out and map the dependencies explicitly
<jtojnar> Conceptually, the display manager should not care about much else than what sessions are available
<jtojnar> User management would be handled by accountsservice
<jtojnar> * Conceptually, the display manager should not care about much else than what sessions are available and then ask systemd to start them
<worldofpeace> Jan Tojnar: maybe we could do a xdgBaseDirectories option