worldofpeace changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 20.09 Nightingale ✨ https://discourse.nixos.org/t/nixos-20-09-release/9668 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html | https://r13y.com | 20.09 RMs: worldofpeace, jonringer | https://logs.nix.samueldr.com/nixos-dev
ris has quit [Ping timeout: 260 seconds]
rajivr has joined #nixos-dev
<gchristensen> supersandro2000: I'm not on the board :)
<gchristensen> and thankfully I don't do license compliance, haha
<supersandro2000> damn it
<supersandro2000> would it be alright for nixos to source an OSC 7 & 133 script for a terminal https://github.com/wez/wezterm/blob/main/assets/shell-integration/wezterm.sh ?
orivej has joined #nixos-dev
cole-h has joined #nixos-dev
supersandro2000 has quit [Remote host closed the connection]
supersandro2000 has joined #nixos-dev
supersandro2000 has quit [Remote host closed the connection]
supersandro2000 has joined #nixos-dev
spacekookie has quit [*.net *.split]
sphalerite has quit [*.net *.split]
ghuntley has quit [*.net *.split]
tetdim has quit [*.net *.split]
delroth has quit [*.net *.split]
b42 has quit [*.net *.split]
elvishjerricco has quit [*.net *.split]
misuzu_ has quit [*.net *.split]
zhaofeng_alt has quit [*.net *.split]
davidtwco has quit [*.net *.split]
mcint has quit [*.net *.split]
stew has quit [*.net *.split]
stew has joined #nixos-dev
misuzu has joined #nixos-dev
tetdim has joined #nixos-dev
spacekookie has joined #nixos-dev
davidtwco has joined #nixos-dev
ghuntley has joined #nixos-dev
elvishjerricco has joined #nixos-dev
zhaofeng_alt has joined #nixos-dev
sphalerite has joined #nixos-dev
delroth has joined #nixos-dev
b42 has joined #nixos-dev
mcint has joined #nixos-dev
pmy has quit [Quit: WeeChat 3.1]
maljub01 has quit [Quit: maljub01]
maljub01 has joined #nixos-dev
pmy has joined #nixos-dev
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-dev
beertoagunfight has quit [Remote host closed the connection]
evils has quit [Ping timeout: 265 seconds]
orivej has quit [Ping timeout: 246 seconds]
cole-h has quit [Ping timeout: 252 seconds]
orivej has joined #nixos-dev
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
tomberek has quit [Ping timeout: 240 seconds]
FRidh has joined #nixos-dev
tomberek has joined #nixos-dev
capisce has joined #nixos-dev
orivej has quit [Ping timeout: 260 seconds]
jonringer has quit [Ping timeout: 258 seconds]
orivej has joined #nixos-dev
ris has joined #nixos-dev
orivej has quit [Ping timeout: 252 seconds]
orivej has joined #nixos-dev
dotlambda has quit [Quit: ZNC 1.8.1 - https://znc.in]
dotlambda has joined #nixos-dev
AlwaysLivid has joined #nixos-dev
orivej has quit [Ping timeout: 252 seconds]
spacekookie has quit [Quit: **aggressive swooshing**]
spacekookie has joined #nixos-dev
Synthetica has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
contrapumpkin has joined #nixos-dev
copumpkin has quit [Ping timeout: 265 seconds]
AlwaysLivid has quit [Ping timeout: 240 seconds]
AlwaysLivid has joined #nixos-dev
evils has joined #nixos-dev
<FRidh> looking again at https://github.com/NixOS/nixpkgs/pull/102613 I was worried about the performance hit basically reimplementing propagation with nix, however, all the stats go down in value
<{^_^}> #102613 (by FRidh, 21 weeks ago, open): WIP: Python: wrap and patch using `requiredPythonModules` instead of `propagatedBuildInputs`
zimbatm has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
zimbatm has joined #nixos-dev
contrapumpkin is now known as copumpkin
__monty__ has joined #nixos-dev
ehmry has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
ehmry has joined #nixos-dev
jonringer has joined #nixos-dev
orivej has joined #nixos-dev
asbachb has joined #nixos-dev
rajivr has quit [Quit: Connection closed for inactivity]
kpcyrd has left #nixos-dev [#nixos-dev]
FRidh has quit [Quit: Konversation terminated!]
<supersandro2000> Why do commits like https://github.com/NixOS/nixpkgs/commit/6f845f7622dab936ff76a7c340134a54decd724f seemingly don't receive any review?
<samueldr> this is on a feature branch, no?
<samueldr> might even be on a special branch intended only to get hydra tests running?
* samueldr is waiting on hydra
pmy has quit [Ping timeout: 260 seconds]
pmy has joined #nixos-dev
cole-h has joined #nixos-dev
asbachb has quit [Ping timeout: 240 seconds]
<supersandro2000> python-unstable is the staging for python and eventually merged into staging or staging-next most of the time
<supersandro2000> but staging or staging-next are not reviewed one by one but only looked for breakages at least that how it look like for me right now
<supersandro2000> I am just a bit concerned that half of python is broken because something somewhere was overlooked
<supersandro2000> and if propagatedBuildInputs goes away we need to adjust the reviewing process and for that reviewers need to be aware of that
<supersandro2000> which should most likely happen in advance
<supersandro2000> Also do I now need to create a second GitHub account because everyone is blocking me to give important feedback!?
<supersandro2000> FRidh
<supersandro2000> Also I am hearing of that change the first time right now and squeezing it into 21.05 is a bit short planned for my liking
<supersandro2000> the stdenv.lib removal got planned for 21.11 a couple of months ago which is a simpler to fix breaking eval change
<supersandro2000> I don't think pythonPackages should receive a bigger rework one month before release especially if not converted packages will fail at runtime. This sounds like we need to do a lot of cleanup and test this properly. The plan for 21.05 was that it will be smoother release than 20.09 was.
<sterni> this is a feature branch for a WIP PR which has a hydra jobset for testing
<sterni> I don't think it's time yet to panic about any breakages being rushed in
<supersandro2000> As far as I know python-unstable is used to mass update python packages and then gets merged into staging which slowly bubbles into master
<supersandro2000> like https://github.com/NixOS/nixpkgs/pull/117452. Maybe I am wrong but thats just the information I collected over the last months.
<{^_^}> #117452 (by FRidh, 1 week ago, merged): Python packages set: major upgrades
<samueldr> since fridh isn't here, supersandro2000, comment on the commit itself to get more info
<supersandro2000> Maybe it should have been part of this WIP PR https://github.com/NixOS/nixpkgs/pull/102613 but I don't know
<{^_^}> #102613 (by FRidh, 21 weeks ago, open): WIP: Python: wrap and patch using `requiredPythonModules` instead of `propagatedBuildInputs`
<supersandro2000> samueldr: well I would if I would be allowed to.
<supersandro2000> but I need to block evade already to ask such questions https://github.com/NixOS/nixpkgs/commit/2a1f172184741709f645905c21d66cb32e466e8d#r49091270
<sterni> well python-unstable has hydra-jobset, so it's useful for testing and stabilizing mass changes
<supersandro2000> or bring in any feedback
<sterni> doesn't mean that it's a law it's automatically being merged into staging
<supersandro2000> sterni: then you think it is only in there temporarily for testing?
<sterni> I'm pretty sure there will be plenty of time to give feedback on the change
<supersandro2000> Maybe I am just missing information here. Would be nice if such things would be communicated more openly
<sterni> well there is the wip pr
<sterni> I mean you can't really inform ppl about much if it isn't ready
<sterni> from your comments here I get the impression you suspect some kind of ill intent or the plan to rush in changes without them being ready past feedback
<supersandro2000> well from the branch it looked to me it was ready already
<sterni> I think that would be being unfair
<supersandro2000> samueldr: thanks
<supersandro2000> samueldr++
<{^_^}> samueldr's karma got increased to 330
<supersandro2000> sterni: to be honest I am just confused right now because it is in that branch and the commit is 4 hours old
<supersandro2000> also another recent change which did not really receive any communication that reached me except the push to the branch is the split out of python2Packages https://github.com/NixOS/nixpkgs/blob/staging/pkgs/top-level/python2-packages.nix
<supersandro2000> I am not sure how I need to adjust reviews to reflect that change if something about python2 would change
<supersandro2000> I think based on https://github.com/NixOS/nixpkgs/commit/187d0371ab3220ee40da1f616e4c48d85ac28986 it just moved all package definitions for python2 into another file but I am not sure.
<supersandro2000> which would be important for me if someone upgrades a python package to a python3 only version which is still required for python2.
<sterni> “move python 2 only expressions to python2-packages.nix” seems clear enough to me
<supersandro2000> yeah I think you are right but I would have loved some more communication here especially for reviewers and commiters
<supersandro2000> also I can't find a section in the python language docs about this
<supersandro2000> which means I can't point someone to a written guide if they have questions about this. I get asked this a lot and I usually cannot satisfy this question because I don't know the docs well enough to know where to find such information or there is nothing to point to
<lukegb> from the commit message: "TODO: update documentation"
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
jonringer has quit [Ping timeout: 258 seconds]
AlwaysLivid has quit [Ping timeout: 240 seconds]
tomberek has quit [Quit: Connection closed]
zimbatm has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
AlwaysLivid has joined #nixos-dev
<MichaelRaskin> supersandro2000: I am pretty sure, given Nixpkgs manual does have some style guide, that there is only Nixpkgs manual and RFCs for any kind of official status
<MichaelRaskin> Some of the changes you propose lack not just official documentation, but also consensus that they are a good idea
<supersandro2000> MichaelRaskin: what about nix pills? they should also work
<MichaelRaskin> For the record: there is no consensus that Flakes as currently implemented, or as documented in RFC, are good enough
<MichaelRaskin> We have that level of problems with consensus
<MichaelRaskin> I am pretty sure some parts of Pills are suspected by some to be obsolete
<MichaelRaskin> Which does not improve my confidense in prescriptive advice there
<supersandro2000> mmmm. That does not make it easier 😅
<MichaelRaskin> It kind of does
<symphorien[m]> the manual still has examples with packageOverrides when it should use overlays
<MichaelRaskin> There is Nixpkgs manual, and there are accepted RFCs (not many), and that's it
<symphorien[m]> so even canonical example can be "wrong"
<supersandro2000> ufff. thats not great.
<supersandro2000> If we don't have consensus on most things then you will end up with the likings of the reviewer.
<MichaelRaskin> Which eventually means merging while ignoring a large subset of feedback, yes
<supersandro2000> as long as I don't propose general bad ideas then I just try to give overall feedback and not care to much about small nouances
<MichaelRaskin> Yeah, surely there are too few consensus-recognised-bad ideas for you to suggest any
<supersandro2000> MichaelRaskin: I don't think that is a good idea. Even if we lack official documentation if some idea is not meaningless or bad advice than we should think about it
<supersandro2000> I think there are enough bad patterns which should be avoided even if they are not document
<supersandro2000> for example you should use makeFlags instead of calling make manually
<MichaelRaskin> Also depends
<supersandro2000> or simple replace patterns should use substituteInPlace rather than a patch
<MichaelRaskin> Ahhahahaha
<supersandro2000> well I assume the standard case, not some special exception right now
<MichaelRaskin> I think by now I have seen all combinations of opinions on that
<MichaelRaskin> For the record, the easiest to read for me is sed
<supersandro2000> well, python depedency patching is always done like this because it less likely breaks and is easier to update
<supersandro2000> sed has the small disadvantage that we can't detect if it does not match
<supersandro2000> but yeah those are small things which are nice but not required
<supersandro2000> if someone merges it than the person thinks it is good to merge and can take responsibility for merging it
<MichaelRaskin> Well, it's true that I usually use sed for things that just plain fail the build if not fixed
<supersandro2000> thats alright but if the build silently fails than thats not easy to catch necessarily
<supersandro2000> If I see such things I usually drop a small comment that it could be that but if it is not changed I don't care to much either
AlwaysLivid has quit [Ping timeout: 240 seconds]
justanotheruser has joined #nixos-dev
<MichaelRaskin> Crazy idea: once level of linebreak-nonagression of nixpkgs-fmt is considered OK, format just the changed lines
<supersandro2000> hexa-: fyi going to fix home-assistant on staging right now
<hexa-> supersandro2000: where is the breakage?
<hexa-> is it fridhs revert?
<supersandro2000> python mass update broke at least pandas and ipywidgets
<supersandro2000> jonringer did a WIP fix PR which I am going to build on
<hexa-> oh, we rely on pandas?
<supersandro2000> pandas is probably used for some docs somewhere
<hexa-> aye, thanks anyway!"
<supersandro2000> and it crashes in the tests which I fixed already a couple of days ago but on the wrong branch
<supersandro2000> I did the PR against master
<supersandro2000> yeah, I need home-assistant to test the pytest update ;P
<hexa-> such is the python life
AlwaysLivid has joined #nixos-dev
AlwaysLivid has quit [Remote host closed the connection]
AlwaysLivid has joined #nixos-dev
risson has quit [Quit: pouet]
tomberek has joined #nixos-dev
ChanServ has quit [shutting down]
Scriptkiddi has quit [Quit: Bridge terminating on SIGTERM]
das_j has quit [Quit: Bridge terminating on SIGTERM]
ajs124 has quit [Quit: Bridge terminating on SIGTERM]
<abathur> "nixpkgs’ sphinx package is missing certifi as a dependency. Nixpkgs maintainers are often not aware of misisng deps, since some sub dependency has the missing dependency inside checkInputs, making the dependency present for the hydra build. But as soon as doCheck is disabled, those dependencies are missing, and the build fails."
ajs124 has joined #nixos-dev
Scriptkiddi has joined #nixos-dev
ChanServ has joined #nixos-dev
das_j has joined #nixos-dev
das_j has quit [Remote host closed the connection]
ajs124 has quit [Remote host closed the connection]
Scriptkiddi has quit [Remote host closed the connection]
ajs124 has joined #nixos-dev
das_j has joined #nixos-dev
Scriptkiddi has joined #nixos-dev
<abathur> source: https://discourse.nixos.org/t/python-package-rodeo/12282/5 and related: #118452
<{^_^}> https://github.com/NixOS/nixpkgs/issues/118452 (by DavHau, 12 hours ago, open): python: fix checkInputs leakage into runtime dependencies
<abathur> seems like maybe nixpkgs-(hammering|review) or ofborg could be backstopping issues like this by checking for *new* failures caused by setting doCheck or doInstallCheck to false?
<supersandro2000> this would require to rebuild everything...
<supersandro2000> at least the package in question and everything if we disable it globally. I think just for the package we could probably hack something together.
AlwaysLivid has quit [Ping timeout: 240 seconds]
__monty__ has quit [Quit: leaving]
jonringer has joined #nixos-dev
orivej has quit [Ping timeout: 240 seconds]
AlwaysLivid has joined #nixos-dev
rajivr has joined #nixos-dev
bpye has quit [Ping timeout: 240 seconds]
bpye has joined #nixos-dev
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-dev