sphalerite changed the topic of #nixos-dev to: NixOS Development (#nixos for questions) | NixOS 19.03 released! https://discourse.nixos.org/t/nixos-19-03-release/2652 | https://hydra.nixos.org/jobset/nixos/trunk-combined https://channels.nix.gsc.io/graph.html https://r13y.com | 19.03 RMs: samueldr,sphalerite | https://logs.nix.samueldr.com/nixos-dev
webster23 has quit [Ping timeout: 250 seconds]
justanotheruser has quit [Ping timeout: 244 seconds]
<lopsided98> This patch pretty much eliminates platform impurities for autotools based packages: https://github.com/lopsided98/nixpkgs/commit/6d1c649a0110dd7c1c032882521d4ad82f4f06d8
<lopsided98> My implementation is complicated because I made it only apply to armv6l and not cause a mass rebuild on other platforms
<lopsided98> Certain (mostly non-autotools) packages still have issues, but I've fixed all the ones I've found in upstream nixpkgs
justanotheruser has joined #nixos-dev
noonien has quit [Quit: Connection closed for inactivity]
<gchristensen> samueldr: is adding wrapQtAppsHook to buildInputs enough?
<gchristensen> (obs)
<samueldr> I think it should
<samueldr> though maybe there's some other breakage?
<{^_^}> #65448 (by ivan, 12 minutes ago, open): Qt programs segfault on startup in master
<{^_^}> #65399 (by ttuegel, 1 day ago, open): Tracking issue for wrapQtAppsHook
<gchristensen> cool
<worldofpeace> nativeBuildInputs that is
<worldofpeace> #65449 samueldr
<{^_^}> https://github.com/NixOS/nixpkgs/pull/65449 (by worldofpeace, 2 minutes ago, open): nixos/xdg: disable portals (again, again)
<worldofpeace> should satiate the people who suddenly can't use filechoosers 🤣
<samueldr> (which is why I was looking for the documentation instead)
phreedom has quit [Ping timeout: 260 seconds]
phreedom has joined #nixos-dev
Drakonis has quit [Ping timeout: 250 seconds]
<tilpner> Is it really useful to insist on "maintainers" being set, even when the PR author may have no intention of ever maintaining that package?
<tilpner> Like this, you end up with a package that claims it's being maintained, but actually is not
orivej has quit [Ping timeout: 248 seconds]
orivej has joined #nixos-dev
FRidh has joined #nixos-dev
__monty__ has joined #nixos-dev
<andi-> Should we even accept packages without anyone trying to maintain it? Is the upgrade bot enough? Should we remove packages that are stale without maintainers (or with inactive maintainers)?
<FRidh> ideally all new packages should have a maintainer
* tilpner tries to sneak in orphaned-from-the-start packages from time to time
<FRidh> in practice, that does not mean much though
<tilpner> Hey FRidh, I updated a pythonPackage, but it required a new dependency. I added that dependency, but I don't care about maintaining it
<tilpner> I see some point in maintainership of applications, but for some random pythonPackages entry?
<FRidh> tilpner: it's very common to do that. However, as soon as your package fails because the dep fails...then you will check it?
<tilpner> That will never happen, I updated PyGithub, which I don't maintain
<tilpner> #65262
<{^_^}> https://github.com/NixOS/nixpkgs/pull/65262 (by tilpner, 4 days ago, open): python3Packages.PyGithub: 1.36 -> 1.43.8
<FRidh> as the package set(s) grow, it gets increasingly harder to make sure things work because most people only care about the leaf packages, and not the dependencies
<tilpner> If I end up needing a newer pygithub, I may end up updating it again, including updates to deprecated, if those are required
<tilpner> But I'll probably not just go and check for new deprecated versions once a week
<tilpner> If you insist, I'll add my name there, but it won't do much unless I get pinged about something
<FRidh> I think that's fine
<tilpner> Or I can withdraw the PR and put them into the NUR
<FRidh> in my opinion we try to update too often
<FRidh> aiming for rolling release increases the maintenance burden a lot
<tilpner> Well, I should be able to do once a release
<tilpner> Added the maintainer line, thank you
<__monty__> Is there a bot to actually ping maintainers? I maint
<__monty__> ain the ranger package but changes were accepted without any notification whatsoever. This currently prevents people from installing it using pypypackages or pythonPackages for that matter.
<FRidh> __monty__: no, unfortunately not.
<gchristensen> an RFC is merged to address this. implementation not yet done
<__monty__> Ah, that's good. Gonna look for that.
<FRidh> it got merged?
<gchristensen> yeah
<gchristensen> __monty__: link to the PR?
<FRidh> ok
<__monty__> gchristensen: The one I mentioned? That was a while ago.
<{^_^}> #55270 (by jlesquembre, 24 weeks ago, merged): ranger: add pillow dependency
<gchristensen> oh quite some time ago
<gchristensen> what is your github handle?
<__monty__> toonn
<gchristensen> ok cool
<gchristensen> ofborg would have requested you review https://github.com/NixOS/nixpkgs/pull/55270/files if rfc39 had been implemented
<__monty__> (Just fyi, I decided not to bother keeping track of the current derivation because I want to write up an overlay for development of ranger or installation with all the config options. Then try to get part of that to replace what's in nixpkgs.)
<worldofpeace> it would be nice if `maintainers` had more meaning. active maintainer/inactive maintainer
<__monty__> Yes, also maybe some sort of "Looking for someone to replace me" or "Abandoned" indications.
<gchristensen> my hope is that if people are pinged for reviews they will either do the work, or remove themselves
<__monty__> I'd definitely actively review if I got notified.
<__monty__> Maybe there should also be a pool of random reviewers. People who'd get pinged to review a random PR x times a week?
* gchristensen shuttles the "implement 39 rfc" closer to the top of the todo list
<worldofpeace> lol I guess that would be me "people who'd get pinged to review a random PR x times a week"
<infinisil> rfcs#39
<{^_^}> https://github.com/NixOS/rfcs/pull/39 (by grahamc, 27 weeks ago, merged): RFC-0039: unprivileged maintainer team
<__monty__> Well it wouldn't be real maintainers. It'd be volunteers who wouldn't mind doing a review now and then but don't quite overcome the inertia to actively go looking for a PR to review.
<worldofpeace> nixpkgs reviewers team would be a good idea
<gchristensen> I think smaller, topical teams would be better
<gchristensen> I would think there are too many PRs for just a "nixpkgs reviewers group"... do you think it would be okay?
<gchristensen> off to my next flight
<__monty__> Oh, yeah. I'd definitly sign up for a haskell group, though haskell.nix *is* pretty exciting and has taken my interest away from the haskell infrastructure somewhat.
<__monty__> gchristensen: Be honest, are you a bird? You fly too much.
<worldofpeace> correct it would be to general, people unspecialized to review things won't be able to give specialized feedback
<infinisil> I mean there is the CODEOWNERS file
<infinisil> I'm using this to get notifications for idris stuff and new NixOS modules
<__monty__> Don't you have to be a real maintainer for that?
<worldofpeace> huh, I think the topic drifted into a indefinite territiory
<worldofpeace> * an
<infinisil> __monty__: It might be intended for *actual* code owners/maintainers, but it sure is useful for not only that
webster23 has joined #nixos-dev
FRidh has quit [Remote host closed the connection]
orivej has quit [Ping timeout: 245 seconds]
johanot has joined #nixos-dev
johanot has quit [Quit: WeeChat 2.4]
__monty__ has quit [Ping timeout: 268 seconds]
__monty__ has joined #nixos-dev
johnny101m2 has joined #nixos-dev
johnny101m has quit [Ping timeout: 245 seconds]
johnny101m has joined #nixos-dev
johnny101m2 has quit [Ping timeout: 245 seconds]
Drakonis has joined #nixos-dev
justanotheruser has quit [Ping timeout: 245 seconds]
<pie_> Is there a tracker for r13y repro failures or somesuch?
<samueldr> I don't think per se
<samueldr> though it'd be a good 6.topic: label
<samueldr> oh, already there
johnny101 has quit [Ping timeout: 244 seconds]
johnny101 has joined #nixos-dev
noonien has joined #nixos-dev
justanotheruser has joined #nixos-dev
<samueldr> I went ahead and marked all PRs with WIP in the title with the wip label, though I did open them all to see, just in case, if they weren't ready
<samueldr> (not the first time I do that, did it earlier this year, there only was two pages to deal with)
__monty__ has quit [Quit: leaving]
justanotheruser has quit [Read error: Connection reset by peer]
johnny101m2 has joined #nixos-dev
johnny101m has quit [Ping timeout: 245 seconds]
johnny101m has joined #nixos-dev
johnny101m2 has quit [Ping timeout: 245 seconds]
justanotheruser has joined #nixos-dev
justanotheruser has quit [Ping timeout: 245 seconds]
webster23_ has joined #nixos-dev
webster23 has quit [Ping timeout: 264 seconds]
justanotheruser has joined #nixos-dev
justanotheruser has quit [Ping timeout: 258 seconds]