<{^_^}>
#54696 (by tilpner, 13 weeks ago, open): standardnotes: use appimageTools instead of appimage-run
<dtz>
oh, I merged it in my fork, for testing purposes? Maybe that's what you're seeing? Not any branch on NixOS/nixpkgs repo AFAIK
<tilpner>
dtz: Oh, yes, I got that wrong
<tilpner>
dtz: I don't want to be harsh, I'm a little off today, sorry about that
<dtz>
it's okay. I did break things despite explicitly being told it would :(, I'd be furious in such a situation and hard-pressed to stay civil :P. But appreciate the comment and sorry about your day.
<tilpner>
Can you move the defaulting of extraPkgs into wrapAppImage and wave that through with maintainers powers?
<tilpner>
See the comment on the minetime PR for why
<tilpner>
And then you make a point I hadn't considered about multiPkgs/extraPkgs
<tilpner>
I just copied that from the Steam chroot, but I imagine a lot fewer AppImages need that than games do (I don't really know though)
<tilpner>
Feel free to fix up that situation by clearing most of multiPkgs
<dtz>
oh, did you see what I've been doing (kinda kludge) for dropping the 32bit packages? :3 it's not the worst but ...
<dtz>
oh I assumed, dumbly apparently, appimage spec or something 'required' we have both 32 and 64
<tilpner>
No, I never thought about that
<dtz>
haha okay :)
<tilpner>
I just wanted a quick way to run one AppImage
<tilpner>
I've since not needed another AppImage, yet somehow I felt required to maintain this nonsense
<dtz>
I... oh! the defaulting, I couldn't figure out what you meant but it probably works if drop entirely from wrapType{1,2} (but forwarded via @args)
<tilpner>
And then someone started using appimage-run in packages, and that was so horrible I had to fix that too
<dtz>
many of these are electron and hopefully we can package them in another way soon... but in the meantime it's nice to use them in a more nix-y way
<dtz>
hahaha
<dtz>
and now you're the appimage build infrastructure maintainer
<dtz>
:P
<tilpner>
I believe you touched it last, you're it now c.c
<dtz>
nooooo
<dtz>
haha
* dtz
accepts his fate
<tilpner>
So, I want to remove the .overrideAttrs from the standardnotes PR
<dtz>
mmhmm
<tilpner>
That requires that you add the defaulting to wrapAppImage
<tilpner>
And then you merge that, and I never touch this part of nixpkgs again
* dtz
is sending PR for that shortly
chrisaw has joined #nixos-dev
* tilpner
reviews
<chrisaw>
Just pushed my first ever package to master so please do let me know if I've missed anything. :)
<chrisaw>
Or rather *PR'd my first ever package...
<dtz>
tilpner: LMK if you know a way to leverage something like wrapGAppsHook, instead of the partial kludge I'm doing re:setting XDG_DATA_DIRS and such. Couldn't come up with a reasonable approach :/