supersandro2000 has quit [Ping timeout: 264 seconds]
supersandro2000 has joined #nixos-borg
lassulus has quit [Ping timeout: 256 seconds]
lassulus has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
supersandro2000 has quit [Ping timeout: 246 seconds]
supersandro2000 has joined #nixos-borg
supersandro2000 has quit [Ping timeout: 264 seconds]
supersandro2000 has joined #nixos-borg
<gchristensen>
LnL: can you spin up some more builders?
<gchristensen>
we should probably use terraform to actually create the instances, as it is a bit more reliable for that -- then just use nixops to do the deploy
<LnL>
yeah, I prefer terraform for that kind of stuff
<LnL>
you want me to just scale up?
<gchristensen>
I guess so, yeah, we have only 1 evaluator actually evaluating
<LnL>
oh, what happened?
<gchristensen>
not sure, can't look yet :(
<LnL>
metrics claim 3 in progress
<gchristensen>
look at the evals finished per hour
<LnL>
gchristensen: seems like the agent is offline, in which case I don't think I can do anything
<gchristensen>
eeuhh
<gchristensen>
okay, that I can look at, I think :P
<LnL>
oh hold on, wrong project
<LnL>
might be a good idea to remove ofborg/ofborg :)
<LnL>
no logging from eval-1 after a deploy so I scaled to 5, I think just 3 has been on the slow side recently
superherointj has joined #nixos-borg
cole-h has joined #nixos-borg
<cole-h>
Strange, still no logging from eval-1.
<LnL>
yeah, assuming it's dead
superherointj has quit [Remote host closed the connection]
superherointj has joined #nixos-borg
<LnL>
oh boy I totally forgot what I was doing with this eval stuff
<supersandro2000>
😂
<samueldr>
github doesn't want apps to produce comments...
<samueldr>
... but can apps edit the PR body to tack data at the end?
<LnL>
I remember something about race conditions with checkboxes :D
<samueldr>
heh
<samueldr>
though what I had in mind wouldn't work because of github "camo"
<samueldr>
if we were able to just add an SVG, tack that SVG once, the SVG itself is updated
<samueldr>
but I believe github caches all assets added that way
<samueldr>
(and rightfully so, otherwise you'd be able to add tracking to comments and PR bodies)
<LnL>
cole-h: I think this is maybe a good point to stop the pr all the github stub goes through traits now, next would either be breaking stuff apart or adding more traits for other stuff
<LnL>
what about comments for user triggered builds?
<LnL>
alltho, if I remember correctly the main issue was the fanout of platforms which would still be a problem
<supersandro2000>
all the profile visitor badges (ab)use this
<cole-h>
LnL: Oh, right.
<cole-h>
LnL: WDYT about creating a `gh` or `github` module that houses `ghgist`, `ghrepo`, and `ghevent`?
<cole-h>
(Could be saved for a future PR, just wondering if you think it's worth it)
<LnL>
right, might be a bit nicer
<cole-h>
LnL: Any reason you chose to use `dyn Trait` over `impl Trait` (or even `T: Trait` bounds)? I don't play much with traits, so maybe the other ways wouldn't actually work.