gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
supersandro2000 has quit [Disconnected by services]
supersandro2000 has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
cole-h has quit [Ping timeout: 260 seconds]
supersandro2000 has quit [Quit: The Lounge - https://thelounge.chat]
supersandro2000 has joined #nixos-borg
orivej has joined #nixos-borg
supersandro2000 has quit [Ping timeout: 264 seconds]
supersandro2000 has joined #nixos-borg
lassulus has quit [Ping timeout: 256 seconds]
lassulus has joined #nixos-borg
orivej has quit [Ping timeout: 260 seconds]
supersandro2000 has quit [Ping timeout: 246 seconds]
supersandro2000 has joined #nixos-borg
supersandro2000 has quit [Ping timeout: 264 seconds]
supersandro2000 has joined #nixos-borg
<gchristensen> LnL: can you spin up some more builders?
<gchristensen> we should probably use terraform to actually create the instances, as it is a bit more reliable for that -- then just use nixops to do the deploy
<LnL> yeah, I prefer terraform for that kind of stuff
<LnL> you want me to just scale up?
<gchristensen> I guess so, yeah, we have only 1 evaluator actually evaluating
<LnL> oh, what happened?
<gchristensen> not sure, can't look yet :(
<LnL> metrics claim 3 in progress
<gchristensen> look at the evals finished per hour
<LnL> gchristensen: seems like the agent is offline, in which case I don't think I can do anything
<gchristensen> eeuhh
<gchristensen> okay, that I can look at, I think :P
<LnL> oh hold on, wrong project
<LnL> might be a good idea to remove ofborg/ofborg :)
evanjs has quit [Quit: ZNC 1.8.2 - https://znc.in]
evanjs has joined #nixos-borg
<LnL> no logging from eval-1 after a deploy so I scaled to 5, I think just 3 has been on the slow side recently
superherointj has joined #nixos-borg
cole-h has joined #nixos-borg
<cole-h> Strange, still no logging from eval-1.
<LnL> yeah, assuming it's dead
superherointj has quit [Remote host closed the connection]
superherointj has joined #nixos-borg
<LnL> oh boy I totally forgot what I was doing with this eval stuff
<supersandro2000> 😂
<samueldr> github doesn't want apps to produce comments...
<samueldr> ... but can apps edit the PR body to tack data at the end?
<LnL> I remember something about race conditions with checkboxes :D
<samueldr> heh
<samueldr> though what I had in mind wouldn't work because of github "camo"
<samueldr> if we were able to just add an SVG, tack that SVG once, the SVG itself is updated
<samueldr> but I believe github caches all assets added that way
<samueldr> (and rightfully so, otherwise you'd be able to add tracking to comments and PR bodies)
<LnL> cole-h: I think this is maybe a good point to stop the pr all the github stub goes through traits now, next would either be breaking stuff apart or adding more traits for other stuff
<LnL> what about comments for user triggered builds?
<LnL> alltho, if I remember correctly the main issue was the fanout of platforms which would still be a problem
<cole-h> LnL: Sorry, brain slow -- "stop the pr"?
<supersandro2000> samueldr: IIRC cache-control: 0
<supersandro2000> should work
<{^_^}> #535 (by LnL7, 2 weeks ago, open): eval: partially split up github interactions
<supersandro2000> all the profile visitor badges (ab)use this
<cole-h> LnL: Oh, right.
<cole-h> LnL: WDYT about creating a `gh` or `github` module that houses `ghgist`, `ghrepo`, and `ghevent`?
<cole-h> (Could be saved for a future PR, just wondering if you think it's worth it)
<LnL> right, might be a bit nicer
<cole-h> LnL: Any reason you chose to use `dyn Trait` over `impl Trait` (or even `T: Trait` bounds)? I don't play much with traits, so maybe the other ways wouldn't actually work.
<LnL> depends where
<LnL> for those functions impl might work
<cole-h> but tbh those could probably be trait methods instead of taking something that impls that trait, no?
<cole-h> So, `repo_client.request_reviews(...)` rather than `request_review(repo_client, ...)`
<cole-h> (Not that it really makes a difference...)
supersandro2000 has quit [Ping timeout: 265 seconds]
<LnL> hmm I'm not actually sure what the advantage is of impl Trait for arguments, I've only used it for return values to avoid boxes
<LnL> and the equivalent to the current type is &(impl ghgist::Client + ?Sized) which is kind of awkward
supersandro2000 has joined #nixos-borg
<cole-h> Got it.
<LnL> I think you'd want impl Trait when taking ownership
<cole-h> I just don't come across many `dyn`s, so it made me a little "suspicious" :P
<LnL> dyn used to be implicit, so maybe that's why?
<cole-h> Oh, that's true. I do remember reading about that.
<cole-h> Is it not implicit any longer?
<LnL> not sure if it's still a warning or a full failure now
superherointj has quit [Quit: Leaving]
orivej has joined #nixos-borg