hmpffff has quit [Quit: nchrrrr…]
andi- has quit [*.net *.split]
{^_^} has quit [*.net *.split]
andi- has joined #nixos-systemd
{^_^} has joined #nixos-systemd
hmpffff has joined #nixos-systemd
hmpffff has quit [Quit: nchrrrr…]
hmpffff has joined #nixos-systemd
<flokli> ma27[m]: did you have a chance to take a look at the PR?
<ma27[m]> flokli: not yet unfortunately, today was a rather busy day, sorry! Will try to test tonight or tomorrow if that's okay :)
<flokli> okay, no worries :-)
<arianvp> hmm
<arianvp> I see in our patches that we read systemd unit files also from /nix/var/nix/profiles/system
<arianvp> in that case, why do we move systemd's units to $out/example, why not keep them in $out/lib/systemd/system ?
<arianvp> they'll be loaded correctly no?
<arianvp> this patch
<arianvp> hmm
<arianvp> it even looks in /nix/var/nix/profiles/default which doesnt even exist on my system?
<arianvp> flokli:does it do on yours? if not; can we just drop this patch?
<arianvp> i thought it was looking in the system profile but it isnt
<flokli> arianvp: so the systemd-mutable stuff is dysnomia
<flokli> maybe the other string should have been /nix/var/nix/profiles/system/lib/systemd, so stuff is installed when installed via nix-env
<flokli> but as it never worked, we can probably drop it from that patch
<arianvp> to summarise
<arianvp> the patch 1. does things for dysonmia and a profile that doesnt exist anymore in named "default"
<arianvp> 2. the patch removes redundant lookups on directories that dont exist on nixos
<arianvp> but afaics it the code wont fail if those directories dont exist
<arianvp> so seems like another micro-optimisaiton; AKA we can just drop the entire patch no?
<arianvp> seems to me it can be completely dropped without affecting behaviour
<arianvp> (Except for dysomnia)
<flokli> we probably should refactor out the dysnomia-specific stuff into a custom systemd, and encourage dysnomia users to set systemd.package to that.
<flokli> But I'd probably leave this for another PR
<flokli> not sure if we want to touch that patch now, or want to do this in a follow-up
<flokli> TBH, I'd prefer to merge the stuff we currently have, and keep going from there.
<arianvp> Yep agreed