<cole-h>
sad how a part of the critical boot chain is unmaintained...
<hexa->
yep
<cole-h>
(well, unmaintained in nixpkgs)
<hexa->
at least no pseudomaintainers in that package :)
<hexa->
I've been rolling with that since 10 days on my desktop
<cole-h>
I'd say merge it tbh, considering it seems to be relatively tested
<hexa->
but no secure boot here
<hexa->
> The error message about missing "share/locale" is still visible when the bootloader gets installed. I have the impression that --enable-nls was already implied before it got set explicitely, so the new commit probably has no effect at all.
<{^_^}>
error: syntax error, unexpected ',', expecting ')', at (string):492:190
<hexa->
ther e is this review message
<cole-h>
well, it'll hit unstable and then you'll get more (unwitting) volunteers :)
<hexa->
lmao :)
<cole-h>
my verdict is: merge it when you're happy with it
<hexa->
fair enough
<cole-h>
but I'm also not a part of the security team :P
<gchristensen>
are you happy about with it hexa-?
<hexa->
gchristensen: I'm not happy about that nls stuff
<hexa->
I'm dropping the latest commit as it doesn't seem to have an affect according to the reviewer
<hexa->
fwiw: I couldn't see the warning anymore
<hexa->
but I'm by no means a grub expert :3
<gchristensen>
I'll press the button and take the heat
<cole-h>
well, if you couldn't see it with the latest, chances are they messed something up locally?
<hexa->
*shrug*
<hexa->
I don't expect there to be much heat
<hexa->
so let's go ahead
<gchristensen>
1s
<cole-h>
alternatively
<cole-h>
we could check the sources to validate the claim that nls is enabled implicitly
<cole-h>
:P
<hexa->
yep, I'm doing that rn
<hexa->
I kinda expected nls to have been enabled, since gettext was already in the inputs
<hexa->
include/grub/i18n.h
<hexa->
25:/* NLS can be disabled through the configure --disable-nls option. */
<hexa->
the only reference I could quickly find
<gchristensen>
I'm deploying to AWS as a check
<cole-h>
gchristensen++
<{^_^}>
gchristensen's karma got increased to 0b110110111
<gchristensen>
those machines are particularly annoying to rescue
<hexa->
nice
<cole-h>
yeah, looks like nls is enabled by default
<cole-h>
so I'd drop that commit
<hexa->
do you have a reference?
<hexa->
fwiw: result/share/locale is missing either way
<hexa->
commit removed
<cole-h>
sorry, maybe not by default, but for us it's enabled by default :p
<hexa->
*shrug* :)
<cole-h>
`nix-build -A grub2 --check 2>| rg -i nls` on master shows `checking whether NLS is requested...` and `checking whether to use NLS...` as yes
<gchristensen>
someone ping me when it is green?
<cole-h>
gchristensen: any chance you could see if that locale error is present prior to this PR as well?
<gchristensen>
uhm
<cole-h>
(if not, no sweat)
<hexa->
there is no result/share/locale before that either
<cole-h>
maybe it's because LOCALE / LANG isn't set in the ssh connection?
<cole-h>
idk; I guess if it doesn't affect functionality it isn't *too* important...
<hexa->
same
<hexa->
guess we'll let it sit for a while before backporting it
<cole-h>
warning is probably from util/grub-install-common.c @ 660
<hexa->
uh, so … do we need to mkdir $out/share/locale? :o
<hexa->
uh, but yeah, it seems to read LC_MESSAGES ig?
<hexa->
so I'm not exactly sure what nls get us at this point
<gchristensen>
so I am trying to do a test deploy but wouldn't you know it I'm out of disk space
<gchristensen>
so ... waiting for DC
<cole-h>
lol
<hexa->
lol
<gchristensen>
GC*
<gchristensen>
I'm still just deleting .lock files
<gchristensen>
idk maybe I should gc more than, uh, literally no idea
<cole-h>
hehe
<cole-h>
reading ABOUT-NLS, it seems like it relies on LANG. so if the environment running `grub-install` doesn't have LANG set, it'll whine about that?
<cole-h>
maybe?
<gchristensen>
it is so silly that nix-collect-garbage onl ytakes bytes deleting '/nix/store/x27wqxpy0d41mxgl6yvsg5n9h9c81mhr-linux-4.19.116.tar.xz'
<gchristensen>
deleted or invalidated more than 40000000 bytes; stopping